Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

On Mon, Apr 16, 2018 at 01:33:56PM +0100, Leif Lindholm wrote: > On Mon, Apr 02, 2018 at 10:51:53AM +0800, Guo Heyi wrote: > > Hi Ray and Leif, > > > > Any comments? > > > > > > On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > > > Thank

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

BTW, there is actually a bug with ATU configuration which will cause IO access failure, and we need to apply an additional patch (this patch is generated after PCI host bridge patch series) as attached to fix this. Regards, Heyi On Tue, Apr 17, 2018 at 09:20:44AM +0800, Guo Heyi wrote: > Hi

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

and regards, Heyi On Mon, Apr 16, 2018 at 09:57:09PM +0800, Guo Heyi wrote: > Thanks, I will test mm command and let you know the result. > > Regards, > > Heyi > > On Fri, Apr 13, 2018 at 09:19:53AM +0200, Ard Biesheuvel wrote: > > On 13 April 2018 at 04:05, Guo Heyi

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

Thanks, I will test mm command and let you know the result. Regards, Heyi On Fri, Apr 13, 2018 at 09:19:53AM +0200, Ard Biesheuvel wrote: > On 13 April 2018 at 04:05, Guo Heyi <heyi@linaro.org> wrote: > > Hi Ard, > > > > Any comments? > > > > Apologie

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

Hi Ard, Any comments? Anyway we can modify the code if you insist on using an intermediate CPU IO address space. Thanks, Heyi On Sat, Mar 31, 2018 at 09:37:47AM +0800, Guo Heyi wrote: > Hi Ard, > > Thanks for your time of reviewing the patches. > Please see my opinions below.

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

> -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, > > Jian J > > Sent: Tuesday, April 3, 2018 9:24 AM > > To: Zeng, Star <star.z...@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>;

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

Hi Ray and Leif, Any comments? On Mon, Mar 26, 2018 at 05:03:10PM +0800, Guo Heyi wrote: > Thanks Ray. > > Does that mean we need build the dynamic command driver separately and store > it > in other media instead of UEFI fd image? Right now if I include the driver > i

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

Hi Ard, Thanks for your time of reviewing the patches. Please see my opinions below. On Fri, Mar 30, 2018 at 05:40:20PM +0200, Ard Biesheuvel wrote: > On 29 March 2018 at 02:20, Guo Heyi <heyi@linaro.org> wrote: > > On Wed, Mar 28, 2018 at 10:43:41AM +0100, Ard Biesheuvel wr

Re: [edk2] [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base

Yes, it is https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix-v2 I just put in the cover letter :) Thanks, Heyi On Fri, Mar 30, 2018 at 11:56:01AM +0100, Ard Biesheuvel wrote: > On 29 March 2018 at 01:06, Guo Heyi <heyi@linaro.org> wrote: > > Ah, I made the

Re: [edk2] [RFC 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

t; -Original Message- > > From: Wang, Jian J > > Sent: Thursday, March 29, 2018 2:13 PM > > To: Guo Heyi <heyi@linaro.org> > > Cc: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Yi Li > > <phoenix.l...@huawei.com>; Renhao Liang <liang

Re: [edk2] [RFC 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

ifferentiate such situation. > I think there's flaw in the interface design. But it's hard to change it now. > > Regards, > Jian > > > > -----Original Message- > > From: Guo Heyi [mailto:heyi@linaro.org] > > Sent: Thursday, March 29, 2018 1:09 PM > >

Re: [edk2] [RFC 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Original Message- > > From: Zeng, Star > > Sent: Thursday, March 29, 2018 11:20 AM > > To: Heyi Guo <heyi@linaro.org>; edk2-devel@lists.01.org > > Cc: Yi Li <phoenix.l...@huawei.com>; Renhao Liang > > <liangren...@huawei.com>; Dong, Eri

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

On Wed, Mar 28, 2018 at 10:43:41AM +0100, Ard Biesheuvel wrote: > On 28 March 2018 at 02:05, Guo Heyi <heyi@linaro.org> wrote: > > Hi Leif, Ard, > > > > Any comments for this series of patches? > > > > Hello Heyi, > > Thanks for sending

Re: [edk2] [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base

Ah, I made the change locally but forgot to send it out... Now it is there :) Thanks and regards, Heyi On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: > On 26 March 2018 at 10:25, Heyi Guo <heyi@linaro.org> wrote: > > Sm750Dxe is a generic PCIe device drive

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

Hi Leif, Ard, Any comments for this series of patches? Thanks, Heyi On Wed, Mar 21, 2018 at 09:03:06AM +0800, Heyi Guo wrote: > For BAR address translation support was added to edk2 generic PciHostBridge by > commit 74d0a33, now we can also use it for D03/D05 platforms. > This series of patches

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

t; instead of network download to store the final target. Thanks, Heyi On Fri, Mar 23, 2018 at 12:51:45PM +0800, Ni, Ruiyu wrote: > On 3/20/2018 8:15 PM, Guo Heyi wrote: > >I've no idea about how to use Driver; let me spend some time to learn > >first > >:) > > Heyi

Re: [edk2] [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base

On Fri, Mar 23, 2018 at 05:25:54PM +0800, Ard Biesheuvel wrote: > On 22 March 2018 at 19:02, Heyi Guo <heyi@linaro.org> wrote: > > The code in SM750 driver treated the address returned from > > PciIo->GetBarAttributes() as device address; this should be fixed >

Re: [edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

+cc Maintainers of MdeModulePkg. On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: > Hi folks, > > The SetAttributes() interface of generic SerialDxe driver in > MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to > use > default time out va

[edk2] MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec

Hi folks, The SetAttributes() interface of generic SerialDxe driver in MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to use default time out value when the input "Timeout" is 0, but the current implementation will set timeout to 0 directly. It tries to pass "Timeout"

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

. > > Since it is now a dynamic command, is there any way of loading this > dynamically (perhaps via DRIVER) where you feel the need for it? > > / > Leif > > On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: > > Ping :) > > > > > > On

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

Ping :) On Wed, Mar 07, 2018 at 04:02:30PM +, Ard Biesheuvel wrote: > On 7 March 2018 at 03:03, Heyi Guo <heyi@linaro.org> wrote: > > Since D0x platforms always have network enabled, we would like to > > enable tftp command by default so that we can download somet

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

e any idea about the possible reason of this issue. Regards, Heyi On Wed, Mar 14, 2018 at 02:50:41PM +, Ard Biesheuvel wrote: > On 14 March 2018 at 07:45, Marc Zyngier <marc.zyng...@arm.com> wrote: > > On Wed, 14 Mar 2018 00:25:09 +, > > Guo Heyi wrote: > >> >

Re: [edk2] [PATCH v6 0/6] Add translation support to generic PciHostBridge

On Thu, Mar 15, 2018 at 01:27:59PM +0800, Ni, Ruiyu wrote: > On 3/15/2018 12:00 PM, Heyi Guo wrote: > >v6: > >- Patch 1, 2: implement 3 comments from Laszlo. > >- Patch 4: implement 3 comments from Ray. > > > >Patch v5 inherits the code from RFC v4; we don't restart the version number > >for >

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Ecc.exe on Windows. It success and produced a "Report.csv" with only a titel line. I guess this means there is no error in the coding style, isn't it? Please let me know if there is anything wrong with what I did. Thanks and regards, Heyi On Wed, Mar 14, 2018 at 03:57:14PM +0800, Ni, Ruiyu wrot

Re: [edk2] [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload

re this instruction is executed before enabling > > CPU IRQ, or else we may get spurious timer interrupts. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi@linaro.org> > > Signed-off-by: Yi Li <phoenix.l...@hu

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Ard Biesheuvel wrote: > >On 7 March 2018 at 04:30, Ni, Ruiyu <ruiyu...@intel.com> wrote: > >>On 3/6/2018 10:44 AM, Guo Heyi wrote: > >>> > >>>Hi Ray, > >>> > >>>Any comments for v5? > >> > >> > >>Heyi, > &

Re: [edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

Hi Marc, I just tested with an ISB and it also worked for our platform. So is it acceptable to add an ISB after reloading timer compare value? Regards, Heyi On Mon, Mar 12, 2018 at 06:26:43PM +0800, Guo Heyi wrote: > Thanks, I can try if ISB works. The issue was observed on Hisilicon

Re: [edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

tatus, if timer interrupt is level sensitive, so a "DSB SY" > > is needed to make sure this change effect is synchronized. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi@linaro.org> > > Signed-

Re: [edk2] [PATCH 3/3] Hisilicon/D05: Support SBSA watchdog

On Wed, Mar 07, 2018 at 04:10:23PM +, Ard Biesheuvel wrote: > On 7 March 2018 at 06:55, Heyi Guo <heyi@linaro.org> wrote: > > From: Chenhui Sun <sunchen...@huawei.com> > > > > Add description of SBSA watchdogs to ACPI GTDT on D05. > > > > Contri

Re: [edk2] [PATCH 1/3] Hisilicon/D0x: Set ACPI GTDT always-on flag

er is always working on Hisilicon D0x, even system enters WFI/WFE, > > and there is no other low power status, so we set "always-on" flag in > > ACPI GTDT. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jason Zhang &l

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Thanks. Please let me know if any further changes are needed. Regards, Heyi On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote: > On 3/6/2018 10:44 AM, Guo Heyi wrote: > >Hi Ray, > > > >Any comments for v5? > > Heyi, > Some backward compatibility concer

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

ack the repair result. > > > >We also remove a duplicated declaration of BmRepairAllControllers() in > >InternalBm.h in this patch, for it is only a trivial change. > > > >Contributed-under: TianoCore Contribution Agreement 1.1 > >Signed-off-by: Heyi Guo <heyi@lina

Re: [edk2] [PATCH v5 4/6] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

STRICTION: to simplify the situation, we require the alignment of > Translation must be larger than any BAR alignment in the same root > bridge, so that resource allocation alignment can be applied to both > device address and host address. > > Contributed-under: TianoCore Con

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

On Fri, Mar 02, 2018 at 11:19:31AM +0100, Laszlo Ersek wrote: > On 03/01/18 11:48, Guo Heyi wrote: > > On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: > >> On 03/01/18 07:57, Heyi Guo wrote: > > >>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenS

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

extension: when we add new fields to > > PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can > > safely be zero, this code will not suffer from an additional > > change. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-o

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

er: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi@linaro.org> > > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Anthony Perard <anthony.per...@citrix.com> > > Cc: Julien Grall <julien.gr...@linaro.org&

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

t; > > >RESTRICTION: to simplify the situation, we require the alignment of > >Translation must be larger than any BAR alignment in the same root > >bridge, so that resource allocation alignment can be applied to both > >device address and host address. > (1). I'd li

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

lBm.h in this patch, for it is only a trivial change. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Cc: Star Zeng <star.z...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Wed, Feb 28, 2018 at 10:39:24AM +0100, Laszlo Ersek wrote: > On 02/28/18 08:53, Guo Heyi wrote: > > On Wed, Feb 28, 2018 at 03:25:03PM +0800, Ni, Ruiyu wrote: > > >> Heyi, > >> My understanding is this whole change is backward compatible. > >> Which m

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Wed, Feb 28, 2018 at 03:25:03PM +0800, Ni, Ruiyu wrote: > On 2/28/2018 10:29 AM, Ni, Ruiyu wrote: > >On 2/27/2018 7:44 PM, Guo Heyi wrote: > >>Hi all, > >> > >>I believe we have come to conclusion for major parts, so I'm going to > >>send o

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

:01PM +0800, Guo Heyi wrote: > On Tue, Feb 27, 2018 at 05:59:48PM +0800, Ni, Ruiyu wrote: > > On 2/27/2018 5:33 PM, Guo Heyi wrote: > > >Hi Ray, > > > > > >Thanks for your comments. It seems comments 10 and 12 are the major issue; > > >let's >

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On Tue, Feb 27, 2018 at 11:43:35AM +0100, Laszlo Ersek wrote: > On 02/27/18 10:23, Ard Biesheuvel wrote: > > On 27 February 2018 at 01:50, Guo Heyi <heyi@linaro.org> wrote: > >> Hi Ard, > >> > >> Sorry for the late of seeing this patch. I have

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Tue, Feb 27, 2018 at 05:59:48PM +0800, Ni, Ruiyu wrote: > On 2/27/2018 5:33 PM, Guo Heyi wrote: > >Hi Ray, > > > >Thanks for your comments. It seems comments 10 and 12 are the major issue; > >let's > >discuss that first. > > > >1

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Thanks Ray and Laszlo, I will create v2 according to your comments. Regards, Heyi On Tue, Feb 27, 2018 at 11:29:18AM +0100, Laszlo Ersek wrote: > On 02/27/18 06:48, Ni, Ruiyu wrote: > > On 2/27/2018 8:48 AM, Guo Heyi wrote: > >> Hi Laszlo, > >> > >> I agree t

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

in the same root > >bridge, so that resource allocation alignment can be applied to both > >device address and host address. > (1). I'd like to see this restriction be reflected in code. > Both assertion and if-check are needed to ensure debug firmware hang > and releas

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

per UEFI 2.7 definition. > > > > 4. Addresses used in GCD manipulation are host address. > > > > 5. Addresses in ResAllocNode of PCI_ROOT_BRIDGE_INSTANCE are host > > address, for they are allocated from GCD. > > > > 6. Address passed to PciHostB

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

Hi Ard, Sorry for the late of seeing this patch. I have one question: why don't we implement a runtime serial port lib, which will switch UART base address in virtual address map change? I think this will be useful when we want to debug runtime driver in OS stage. And if we have a runtime version

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

tRequired into one > variable (i.e. not multiple instances of the same local variable on the > stack) and to act upon it at the very end. > > > Feel free to ignore my comments -- I just think we should be moving in > the opposite direction; that is, away from recursion (espe

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi > Guo > Sent: Monday, February 26, 2018 4:30 PM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Heyi Guo <heyi@linaro.org>; Eric Dong &

Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

Hi Peter, Thanks for your detailed explanation. I still have one question: On normal platforms, there are more boot options created by UEFI other than the hard disk boot option created by OS installation, like PXE network boot, USB stick boot, etc. If we use the PlatformRecovery method,

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Sat, Feb 24, 2018 at 04:30:42PM +0800, Ni, Ruiyu wrote: > On 2/24/2018 11:59 AM, Guo Heyi wrote: > >On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: > >>On 2/24/2018 9:51 AM, Guo Heyi wrote: > >>>On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrot

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

Sure. On Sat, Feb 24, 2018 at 08:40:20AM +, Ni, Ruiyu wrote: > Will you submit a patch for this change? > > Thanks/Ray > > > -Original Message----- > > From: Guo Heyi [mailto:heyi@linaro.org] > > Sent: Saturday, February 24, 2018 4:29 PM > > To: N

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

On Sat, Feb 24, 2018 at 04:20:52PM +0800, Ni, Ruiyu wrote: > On 2/24/2018 2:23 PM, Guo Heyi wrote: > >Hi folks, > > > >In BmDriverHealth.c, function BmRepairAllControllers may recursively call > >itself > >if some driver health protocol returns > >

[edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

Hi folks, In BmDriverHealth.c, function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, if there is something wrong in some 3rd party driver (e.g. PCI oprom), the driver health protocol of that driver may

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: > On 2/24/2018 9:51 AM, Guo Heyi wrote: > >On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > >>Thanks for writing up the details! > >> > >>Comments: > >> > >>On 02/23/

Re: [edk2] [PATCH edk2-non-osi v3 7/7] Hisilicon/D05: Update binary of trusted-firmware

On Fri, Feb 23, 2018 at 09:02:46AM +, Ard Biesheuvel wrote: > On 23 February 2018 at 03:17, Guo Heyi <heyi@linaro.org> wrote: > > Hi Jeremy, > > > > This TF binaries have not been patched the latest SMCCC workaround; it is > > based > > o

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

> > per UEFI 2.7 definition. > > > > 4. Addresses used in GCD manipulation are host address. > > > > 5. Addresses in ResAllocNode of PCI_ROOT_BRIDGE_INSTANCE are host > > address, for they are allocated from GCD. > > > > 6. Address passed to PciHostB

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

> > per UEFI 2.7 definition. > > > > 4. Addresses used in GCD manipulation are host address. > > > > 5. Addresses in ResAllocNode of PCI_ROOT_BRIDGE_INSTANCE are host > > address, for they are allocated from GCD. > > > > 6. Address passed to PciHostB

Re: [edk2] [PATCH edk2-non-osi v3 7/7] Hisilicon/D05: Update binary of trusted-firmware

; > > >2 Upgrade trusted firmware to 1.4 > > > >Contributed-under: TianoCore Contribution Agreement 1.1 > >Signed-off-by: Ming Huang <huangmin...@huawei.com> > >Signed-off-by: Heyi Guo <heyi@linaro.org> > >Reviewed-by: Leif Lindholm <leif.l

Re: [edk2] [RFC v2 2/2] MdeModulePkg/PciBus: return CPU address for GetBarAttributes

der: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi@linaro.org> > > Cc: Ruiyu Ni <ruiyu...@intel.com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Star Zeng <star.z...@intel.com> > > Cc: Eric Dong <er

Re: [edk2] [RFC v2 0/2] Add translation support to generic PCIHostBridge

Thanks Ray and Laszlo; I think I'd better refine comments and commit message first, or it is rather confusing for review. I'll send v3 ASAP. Regards, Gary On Thu, Feb 22, 2018 at 11:06:13AM +0100, Laszlo Ersek wrote: > On 02/22/18 07:54, Heyi Guo wrote: > > v2: > > Changs are made according to

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On Tue, Feb 13, 2018 at 12:59:50AM +, Haojian Zhuang wrote: > On 02/13/2018 08:23 AM, Guo Heyi wrote: > > Hi Haojian, > > > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > > isn't such device on Hikey, then you can't use t

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

Hi Haojian, Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed. But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

On Thu, Feb 08, 2018 at 04:02:39PM +, Ard Biesheuvel wrote: > On 8 February 2018 at 16:01, Haojian Zhuang wrote: > > On 7 February 2018 at 01:29, Leif Lindholm wrote: > >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >

Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > >>> Sent: Friday, February 2, 2018 4:22 PM > >>> To: Ni, Ruiyu <ruiyu...@intel.com> > >>> Cc: Guo Heyi <heyi@linaro.org>,Dong Wei <dong@arm.com>; Dong, > >>> Eric &l

Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Sorry for the late; I caught cold and didn't work for several days last week :( Please see my comments below: On Mon, Jan 22, 2018 at 11:36:14AM +0800, Ni, Ruiyu wrote: > On 1/18/2018 9:26 AM, Guo Heyi wrote: > >On Wed, Jan 17, 2018 at 02:08:06PM +, Ard Biesheuvel wrote: > >

Re: [edk2] [RFC] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Wed, Jan 17, 2018 at 02:08:06PM +, Ard Biesheuvel wrote: > On 15 January 2018 at 14:46, Heyi Guo <heyi@linaro.org> wrote: > > This is the draft patch for the discussion posted in edk2-devel > > mailing list: > > https://lists.01.org/pipermail/edk2-deve

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

Ard Biesheuvel wrote: > >> > >> On 21 December 2017 at 09:48, Ni, Ruiyu <ruiyu...@intel.com> wrote: > >>> > >>> On 12/21/2017 5:14 PM, Guo Heyi wrote: > >>>> > >>>> > >>>> On Thu, Dec 21, 2017 at

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

On Thu, Dec 21, 2017 at 05:43:17PM +0800, Ni, Ruiyu wrote: > On 12/20/2017 11:26 PM, Ard Biesheuvel wrote: > >On 20 December 2017 at 15:17, gary guo <heyi@linaro.org> wrote: > >>On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: > >>>Hi Heyi,

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

On Thu, Dec 21, 2017 at 08:32:37AM +, Ard Biesheuvel wrote: > On 21 December 2017 at 08:27, Guo Heyi <heyi@linaro.org> wrote: > > On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: > >> On 20 December 2017 at 15:17, gary guo <heyi@linaro.org>

Re: [edk2] [RFC] MdeModulePkg/PciHostBridge: Add address translation support

On Wed, Dec 20, 2017 at 03:26:45PM +, Ard Biesheuvel wrote: > On 20 December 2017 at 15:17, gary guo <heyi@linaro.org> wrote: > > On Wed, Dec 20, 2017 at 09:13:58AM +, Ard Biesheuvel wrote: > >> Hi Heyi, > >> > >> On 20 December 2017 at 0

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

gt; > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Guo Heyi > > Sent: Monday, December 11, 2017 6:43 PM > > To: Wu, Jiaxin <jiaxin...@intel.com> > > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

u, Jiaxin 写道: > >>>Hi Gary, > >>> > >>>IcmpErrorRcvToken is only used to get ICMP error from IP layer, and the > >>data will be copied to Mode->IcmpError. So, I think the RxData should be > >>recycled. > >>>Besides, EFI_IP_PROTO_IC

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

Hi Jiaxin, We are still having our QA to finally verify the patches (including the ICMP error listener bug fix), so I will post the formal patch after regression test completes. Regards, Gary (Heyi Guo) On Fri, Dec 08, 2017 at 10:04:20AM +0800, Guo Heyi wrote: > On Fri, Dec 08, 2017 at

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

t; function, and then call Ip4Output. However, if Ip4Output gets some > > >> error and exits early, e.g. fails to find the route entry, memory > > >> buffer of "Data" gets no chance to be freed and memory leak will be > > >> caused. If there is such an att