I am good with more clear error information coming to the user.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, June 06, 2017 2:26 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Tapan Shah ; Carsey, Jaben
>
> Subject: Re: [e
the list has nothing to do with the shell’s version.
Sadly, the UEFI Shell spec doesn’t assume that shell applications will want
access to the handle index concept that I can think of.
I think that your current solution is the best one.
-Jaben
From: GN Keshava [mailto:keshava...@gmail.com
, then maybe we should
consider that missing information to be added to the shell protocol.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Keshava
> Sent: Tuesday, June 06, 2017 9:12 AM
> To: Carsey, Jaben ; edk2-dev
That library may require the module to be linked into the shell. Remember that
the sermode command is actually in the same binary as the shell and the shell
and the command are sharing information through libraries.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@list
I like removing the special local version of the function.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Tuesday, June 06, 2017 1:44 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.or
Ok. I see now. Thanks!
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 7:32 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Shah, Tapan
> (tapands...@hpe.com)
> Subject: RE: [PATCH] Shell
I think we have to leave the behavior the same. The spec says this: " If the
environment variable does not exist and the Value is an empty string, there is
no action."
I do not think we can change that to an error return without a spec change.
-Jaben
> -Original Messag
I just think we may want to have the behavior act the same as it does today for
delete.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 8:19 AM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Shah, Tapan
> (tapands...@hpe.c
mment before: "We
dont check the error return on purpose since the variable may not exist."
-Jaben
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 7:12 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Kinney, Michael D
>
> Subject
Keshava,
After you remove and replug it, I think you need to do "connect -r" to
recursively reconnect drivers, then do the "map -r" to generate a new mapping.
Reconnecting drivers is standard user behavior after plug in a USB device. It
is not expected to happen au
I think that you will always need to inform the UEFI Shell of the change. It
is not designed to automatically do detection of added/removed/changed devices.
I think that your solution to use the code from mount makes the most sense.
-Jaben
From: GN Keshava [mailto:keshava...@gmail.com]
Sent
You can "disconnect" the driver
You can do "map -d" to delete a mapping
I am unsure what your goals are for mount/unmount
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Keshava
> Sent: Wednesday,
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, May 22, 2017 7:04 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Ni, Ruiyu ;
> Carsey, Jaben
> Subject: [PATCH] ShellPkg/UefiShellLib: Avoid reading undefined content
> before s
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Monday, May 15, 2017 10:18 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Westfahl ; Ni, Ruiyu ;
> Carsey, Jaben
> Subject: [edk2][PATCH v2] ShellPkg/Ls: Handl
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff
> Westfahl
> Sent: Friday, May 12, 2017 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [edk2] [PATCH]
I think that since the UEFI Shell Spec does not mention creating new files and
no one has mentioned it before, we just didn't think of it. I don't see that
it would violate the spec; I would welcome such a enhancement.
-Jaben
> -Original Message-
> Fro
For series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, May 11, 2017 3:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2] ShellPkg/memmap: Dump memory
I agree with Ray's commentary. Good positive changes to UEFI Shell!
For the series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Friday, May 05, 2017 5:25 AM
> To: Ni, Ruiyu
> Cc: Jeff Westfahl ; edk
> To: Carsey, Jaben
> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org
> Subject: Re: [edk2] ShellPkg: Difference in behavior of 'dh' between old shell
> and new
> Importance: High
>
> Hi Jaben,
>
> No PI protocols can be required means that I can try to use them? A
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, May 02, 2017 2:34 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg/UefiHandleParsingLib: Fix memory leak
> Importance: Hig
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, May 01, 2017 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg: Update package version to 1.01
> Importance: High
>
> Contributed-un
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Leif Lindholm
> Sent: Wednesday, April 26, 2017 2:49 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org
That makes sense. When I wrote that I was unsure where to draw the line between
which characters to print and which to replace.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Wednesday, April 26, 2017 12:59 PM
> To
I think that this is a correct change, but I do not understand the problem this
solves.
-Jaben
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Wednesday, April 26, 2017 10:41 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Westfahl ; Ni, R
Tim,
Doesn't that assumption/behavior violate the current spec?
"All the files must begin with a Unicode BOM character."
-Jaben
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: Wednesday, April 26, 2017 9:15 AM
> To: Kinney, Mich
I am good with the series. Good research and description!
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, April 25, 2017 6:57 AM
> To: edk2-devel-01
> Cc: Carsey, Jaben ; Marvin Häuser
> ; Qiu Sh
Slight cleanup suggestion.
Since you are already linking MemoryAllocationLib, you could just call FreePool
in that library instead of using UefiBootServicesTableLib and using
gBS->FreePool (since you have no other use of gBS that I see).
-Jaben
> -Original Message-
> From: e
I am not sure here, but I think that you may have issues running multiple
threads in the UEFI environment. Have you tried not using multiple threadS?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of KT
> Sent: Monday, April 24, 2017 5:32 AM
>
I would say the shell should not free the GUID.
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Monday, April 24, 2017 5:46 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [edk2] Possible UEFI Shell Drv
Do we need to localize that in HII? I am unsure, but I don't have strong
opinion.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Wednesday, April 19, 2017 7:51 PM
> To: edk
-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Wednesday, April 19, 2017 10:36 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] ShellPkg: Difference in behavior of 'dh' between old shell and
> new
> Importance: Hi
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, April 16, 2017 11:29 PM
> To: edk2-devel@lists.01.org
> Cc: Michael Turner ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg/ConsistMapping: Remove unneeded memory
> realloc
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, April 16, 2017 8:13 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Jim Dailey
> Subject: [PATCH] ShellPkg/Pci: Always dump the extended config space for PCIE
> Importance: Hig
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, April 06, 2017 7:22 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Daryl McDaniel li...@mc2research.org>; Carsey, Jaben
> Subject: [PATCH] AppPkg/Applications/Python/PyMod-2.7.2:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, April 06, 2017 8:04 PM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A
> Subject: [edk2] [PATCH] ShellPkg: Fi
Andrew,
I was assuming not wanting ShellExecute() might extend to the rest of the
shell.
If the shell is in use, that can definitely help. While those 2 APIs do exist
in theory, there is a single one that does all I think:
GetDevicePathFromFilePath.
-Jaben
From: af...@apple.com [mailto:af
That's the way to do it. the hard work is around finding the DevicePath for
the application you want to run to pass to LoadImage.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Amit kumar
> Sent: Thursday, April 06, 2017 9:45 AM
> To: Andr
Glad to help.
I do not think that UEFI drivers really have the concept of command line
parameters... they use other methods for configuration...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim.dai...@dell.c
Jim,
That protocol must be installed on your applications own image handle for it to
be valid. Locating the protocol on some other image would result with finding
the other image's command line parameters and the like...
-Jaben
> -Original Message-
> From: edk2-devel [
Hi all,
I will be gone until the 3rd of April and unable to check email.
Mike has graciously agreed to approve patches from Ray in my absence.
-Jaben
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, March 22, 2017 10:29 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg/mm: Support UINT16 segment number
> Importance: High
>
> It
x27;s most recent patch series.
-Jaben
> -Original Message-
> From: Carsey, Jaben
> Sent: Wednesday, March 22, 2017 8:19 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: RE: [PATCH] ShellPkg: Add Shell invocation option '-
That would be quite nice. I know that spinning GUIDs due to a non-backwards
compatible change can be a scary thing.
-Jaben
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, March 22, 2017 8:40 AM
> To: Carsey, Jaben ; Ard Biesheuvel
> ; Kinney, Michae
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, March 22, 2017 8:38 AM
> To: edk2-devel@lists.01.org; Leif Lindholm ; Laszlo
> Ersek ; Carsey, Jaben ; Ni,
> Ruiyu ; Kinney, Michael D
&g
Yes. that looks great.
For the changes to ShellPkg.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, March 22, 2017 8:20 AM
> To: Carsey, Jaben
> Cc: Ni, Ruiyu
Sent: Wednesday, March 22, 2017 1:09 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: [PATCH] ShellPkg: Add Shell invocation option '-exit'
> Importance: High
>
> From: Chen A Chen
>
> According to Shell spec 2.2 '-exit&#
...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, March 22, 2017 7:04 AM
> To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; ler...@redhat.com;
> Carsey, Jaben ; Ni, Ruiyu ;
&
Looks good.
Reviewed-by: Jaben Carsey
Note that I have no experience with "WindowSize" and FTP so I am talking about
my understanding based on the code and not on the theory.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behal
I'm a little confused by the constants you defined. 2 questions inline...
Maybe we need another #define so we have: the max, the min, and the default?
-Jaben
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, March 16, 2017 1:36 AM
> To: edk2-devel@lists.01.org
&g
launched than other images.
Hence my question.
I am good with this patch.
Ray can you review and push it if you agree?
-Jaben
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Wednesday, March 15, 2017 2:09 PM
> To: Carsey, Jaben
> Cc
Does the print call need to be updated to print this out properly?
-Jaben
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Tuesday, March 14, 2017 2:02 PM
> To: edk2-devel@lists.01.org
> Cc: Jeff Westfahl ; Ni, Ruiyu ;
> Carsey, Jaben
&g
Looks good to me.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Monday, March 13, 2017 6:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [e
Looks good to me.
Ray?
> -Original Message-
> From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com]
> Sent: Monday, March 06, 2017 10:15 AM
> To: edk2-devel@lists.01.org; Carsey, Jaben ; Ni,
> Ruiyu
> Cc: Vladimir Olovyannikov
> Subject: [PATCH
. What
"external command" is missing from the shell? Except for the DP command (which
is not in the spec), I am unaware of "missing" commands.
BCFG command can configure the BOOT and DRIVERXXXX variables.
-Jaben
> -Original Message-
> From: edk2-devel [mailt
Agree with comments. Great way to make build easier.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, February 28, 2017 11:57 PM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Gao, Liming
>
> Subject: RE: [PATC
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, February 26, 2017 11:23 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH v2 09/11] ShellPkg/Debug1CommandLib: Use
> StrToGuid/StrHexToBytes in BaseL
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, February 24, 2017 9:13 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [PATCH v3 10/12] ShellPkg: Refine casting expression result to bigge
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, February 24, 2017 8:05 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [PATCH v3 6/6] ShellPkg: Refine type cast for pointer subtraction
> I
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, February 21, 2017 11:46 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Chen, Chen A
>
> Subject: [edk2] [
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, February 21, 2017 11:47 PM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: [PATCH 2/2] ShellPkg/comp: Add "-n "/"-s "
> suppo
; To: Carsey, Jaben
> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org;
> jeff.westf...@ni.com
> Subject: RE: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format
> specifier for LoadedImage
> Importance: High
>
> My point was that printing one byte of the data as hex is not much b
I was reading the email. I was also waiting and making sure there was
consensus since I didn't have a strong opinion. I will let Ray check also, but
I think the fix is good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.
The reason for the structs is as Tapan said. The Shell must support all dumps
that customers require.
The reason for the includes is that it needs to include each protocol that it
may dump.
I agree that the number of includes looks insane.
-Jaben
From: Shah, Tapan [mailto:tapands...@hpe.com
Ok. That makes sense.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, February 10, 2017 8:36 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Subject: RE: [PATCH] ShellPkg/pci: Report error when invalid value is
> specified for "-ec"
> Importance:
Reviewed-by: Jaben Carsey
Ray,
What is the intended behavior if the user does -ec with no data after it?
-Jaben
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, February 10, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] Sh
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, February 09, 2017 1:24 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ;
> Carsey, Jaben
> Subject: [PATCH] ShellPkg SmbiosView: Correct some outputs for Type
> 0
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Thursday, February 09, 2017 1:23 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> ; Zeng, Star
> Subject:
Laszlo - Nice article. Maybe you posted the link before, but if so I had
missed it.
On a SVN-related note, I noticed that SVN via github also seems to be out of
date. Basically the message is: use git.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
I am good with this change. I like the idea of changing platforms that build
the shell from source in a separate patch series.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Michael Kinney
> Se
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Friday, February 3, 2017 12:06 AM
> To: Thomas Palmer ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [P
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, January 25, 2017 8:34 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Chris J Phillips
> ; Tapan Shah
> Subject: [PATCH] ShellPkg/cd: Do not print the destination dir when
That seems good to me.
Reviewed-by: Jaben Carsey
Ray, what do you think?
-Jaben
> -Original Message-
> From: Witt, Sebastian [mailto:sebastian.w...@siemens.com]
> Sent: Thursday, January 26, 2017 1:01 AM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Subject: RE: [PAT
The "if" command supports some numeric comparison, but I don't think we have
much more.
Can you elaborate on the goal of arithmetic using env vars?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Foster, Ma
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 23, 2017 10:43 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg/pci: Support interpreting specific PCIE ext cap thru
> "-ec&qu
I didn't mean a 400 static, I meant start by allocating 400 and simplify the
end of the function...
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Witt, Sebastian
> Sent: Tuesday, January 24, 2017 8:48 AM
> To: Carsey
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 23, 2017 10:43 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg/pci: Fix extended register dumping for MFVC
> capability
> Imp
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 23, 2017 10:52 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg/pci: Use PCI definitions defined in MdePkg
> Importance: High
>
> htt
Is there a reason to not just always start with allocating the 400 and then we
don't need to complicate the end to conditionally free the buffer?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Witt,
> Sebastian
> Sent: Tuesday, January 24, 20
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Monday, January 23, 2017 10:42 PM
> To: edk2-devel@lists.01.org
> Cc: Jaben Carsey
> Subject: [edk2] [PATCH] ShellPkg/pci
I was wondering if some replaced version of HiiLib could use the StrDefs.h
differently and save the overhead if only one language is present...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim
> Lewis
> Sent: Monday
Tim,
I meant some customers do localize the shell and we don't want to arbitrarily
restrict that.
Do you have any ideas on how to remove the overhead when localization is not
required?
-Jaben
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: M
strings meet that criterion.
-Jaben
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: Monday, January 23, 2017 12:52 PM
> To: Carsey, Jaben ; Ni, Ruiyu
> ; Zeng, Star ; edk2-
> de...@lists.01.org
> Subject: RE: [PATCH 3/3] ShellPkg Smbios
Reviewed-by: Jaben Carsey
I think that string mixed use existed in the EDK version of the command and was
just never removed.
-Jaben
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, January 22, 2017 1:49 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zeng, Star
> Sent: Monday, January 16, 2017 7:23 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Carsey, Jaben ;
> Ni, Ruiyu
> Subject: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zeng, Star
> Sent: Monday, January 16, 2017 7:24 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Carsey, Jaben ;
> Ni, Ruiyu
> Subject: [PATCH] ShellPkg SmbiosView: Add missing decoding of SMBIOS spec
&g
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Sunday, January 15, 2017 6:04 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [patch] ShellPkg/HandleParsingLib: Fix coding style issue
> Importance: High
>
Reviewed-by: Jaben Carsey
For the ShellPkg content.
> -Original Message-
> From: Zeng, Star
> Sent: Monday, January 16, 2017 7:25 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Gao, Liming ;
> Kinney, Michael D ; Tian, Feng
> ; Ni, Ruiyu ; Carsey, Jaben
>
Sounds good.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 09, 2017 6:24 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org;
> Kinney, Michael D
> Cc: Wu, Hao A
> Subject: RE: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID
> a
Oh.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 09, 2017 6:25 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Chen, Chen A
> Subject: RE: [PATCH 4/5] ShellPkg/Dh: Fix coding style issues
Rafael,
Actually it's the opposite. EFI_SHELL_INTERFACE is the older and deprecated
protocol. I do not know of any active development using that protocol.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rafael
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, January 7, 2017 11:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben ;
> Kinney, Michael D
> Subject: [Patch] Nt32Pkg/WinNtSimpleFileSystemDxe:
Looks good.
Reviewed-by: Jaben Carsey
I had one inline question.
I would also propose that the String to GUID conversion be placed in a shared
library. Maybe even baselib with the other string functions?
Mike, do you have any thoughts on StringToGuid conversion?
> -Original Mess
One question inline.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 9, 2017 1:31 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: [PATCH 4/5] ShellPkg/Dh: Fix coding style issues
> Importance: High
>
> From
Reviewed-by: Jaben Carsey
Please verify appropriate copyright before commit (I guess this file needs year
update).
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, January 03, 2017 7:23 PM
> To: edk2
ShellBinPkg should be the right location to get a UEFI Shell from (for the
record the EdkShellBinPkg would be the old version).
If you do "ver -s" the ourput will provide additional version information about
the shell itself.
Have you updated your git version recently?
-Jaben
>
I don't think that facility exists.
Seems like configuration is a common use for the UEFI Shell so I don't see that
as a major downside myself.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Konrad Adamczy
I wonder if the firmware supplier is using an older version of the shell
binary? Maybe it is EDK Shell and not UEFI Shell? I am unsure how to fix the
issue.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Kesha
Right. The question is can the user from the shell prompt trigger the assert.
I didn't see clear protection from the users input to the function's assert.
-Jaben
From: Ni, Ruiyu
Sent: Thursday, December 22, 2016 9:43 PM
To: Carsey, Jaben ; edk2-devel@lists.01.org
Cc: Carsey, Ja
That function is not in the shell library.
LocateHandle would be useful is you wanted to find the image handle for the
shell binary whereas LocaetProtocol would be just getting a pointer to the
protocol.
Which version of the UEFI Shell are you using? (what does “ver” command say)
-Jaben
d then your application?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Keshava
> Sent: Tuesday, December 20, 2016 11:32 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] LocateHandle for gEfiShellProtocolGuid i
601 - 700 of 1061 matches
Mail list logo
