Re: [edk2] TPM 2.0 ACPI tableTPM2 table event log

2018-06-06 Thread Lin, Derek (HPS UEFI Dev)
Created in Bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=978 Thanks, Derek From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Tuesday, June 5, 2018 11:14 PM To: Lin, Derek (HPS UEFI Dev) ; Zhang, Chao B Cc: edk2-devel@lists.01.org; Spottswood, Jason Subject: RE: TPM 2.0 ACPI

[edk2] TPM 2.0 ACPI tableTPM2 table event log

2018-06-05 Thread Lin, Derek (HPS UEFI Dev)
Hi Chao and Jiewen, There are new fields in TPM2 ACPI table for getting TCG event log under OS. https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf Page 11. Log Area Minimum Length (LAML) Log Area Start Address (LASA) I remember they are not existed in

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-16 Thread Lin, Derek (HPS UEFI Dev)
erformance. Thanks, Derek -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Thursday, May 17, 2018 12:20 AM To: Zhu, Yonghong ; Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Subject: RE: [PATCH] BaseTools: Fix --hash Package and Module hash value. Derek, The

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
Hi Yonghong, Thanks for notify about this. I resend the patch. Thanks, Derek -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Wednesday, May 9, 2018 4:35 PM To: Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: RE: [PATCH

[edk2] [PATCH] BaseTools: Fix python error with --genfds-multi-thread.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
When self.Alignment is None, it ran into python error since there is no strip() in None. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin --- BaseTools/Source/Python/GenFds/GuidSection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Base

[edk2] [PATCH] BaseTools: Remove dsc nested include checking.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
The dsc nested include checking make unexpected build error when building project A and switch to project B. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin --- BaseTools/Source/Python/Workspace/MetaFileParser.py | 19 +++ 1 file changed, 15 inse

[edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
The order of List enumeration is arbitrary. Need to be sorted while calculating Package/Module hash, otherwise it generate different hash value even nothing changes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin --- BaseTools/Source/Python/AutoGen/AutoGen.py |

[edk2] [PATCH] BaseTools: Remove dsc nested include checking.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
From: Lin, Derek (HPS UEFI Dev) Sent: Wednesday, May 9, 2018 3:39 PM To: Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Remove dsc nested include checking. The dsc nested include checking make unexpected build error when building project A and switch to project B. --- BaseTools/Source

[edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
From: Lin, Derek (HPS UEFI Dev) Sent: Wednesday, May 9, 2018 3:39 PM To: Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Fix --hash Package and Module hash value. The order of List enumeration is arbitrary. Need to be sorted while calculating Package/Module hash, otherwise it generate

[edk2] [PATCH] BaseTools: Fix python error with --genfds-multi-thread.

2018-05-09 Thread Lin, Derek (HPS UEFI Dev)
From: Lin, Derek (HPS UEFI Dev) Sent: Wednesday, May 9, 2018 3:39 PM To: Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Fix python error with --genfds-multi-thread. When self.Alignment is None, it ran into python error since there is no strip() in None. --- BaseTools/Source/Python

[edk2] MdePkg: UefiTcgPlatform.h: Fix Startup Locality Indicator Definitions

2018-04-09 Thread Lin, Derek (HPS UEFI Dev)
Fix Locality Indicator Definitions according to Table 8 of PC Client PTP 00.43. https://www.trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2-0-v43-150126.pdf Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chris Phillips --- Md

Re: [edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-25 Thread Lin, Derek (HPS UEFI Dev)
I agree. Add comments to make this clear seems good. It's good enough for me. Thanks, Derek -Original Message- From: Zhang, Chao B [mailto:chao.b.zh...@intel.com] Sent: Saturday, February 24, 2018 2:26 PM To: Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Cc: Yao, Jiewen ;

Re: [edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-23 Thread Lin, Derek (HPS UEFI Dev)
m: Zhang, Chao B [mailto:chao.b.zh...@intel.com] Sent: Friday, February 23, 2018 11:03 AM To: Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star Subject: RE: TPM 2.0 Manufacutre ID wrong byte order Hi Derek: Can you specify the "reversed" ManufactureId i

[edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-22 Thread Lin, Derek (HPS UEFI Dev)
Hi TPM expert, The line in https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2fddd4d7633537c9620#diff-76abe1c1ebf05982ed72eaf56f489029R192 change the byte order of Manufacture ID in Tpm2GetCapabilityManufactureID (). I see it return "reversed" ManufactureId for two TPM vendor's modu

Re: [edk2] [PATCH] BaseTools: Skip module AutoGen by comparing timestamp.

2016-11-20 Thread Lin, Derek (HPS UEFI Dev)
Hi Yonghong, Thanks for review. I just sent a patch v2 to fix them. Thanks, Derek -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Saturday, November 19, 2016 9:43 PM To: Lin, Derek (HPS UEFI Dev) ; 'edk2-devel@lists.01.org' Cc: Gao, Liming ; Zhu

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

2016-10-27 Thread Lin, Derek (HPS UEFI Dev)
That make sense to me, I will update patch to remove it, and not change order. Thanks, Derek -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, October 27, 2016 1:53 PM To: Lin, Derek (HPS UEFI Dev) ; af...@apple.com Cc: edk2-devel@lists.01.org Subject

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

2016-10-26 Thread Lin, Derek (HPS UEFI Dev)
nks, Derek -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, October 27, 2016 1:25 PM To: Lin, Derek (HPS UEFI Dev) Cc: edk2-devel@lists.01.org; Shia, Cinnamon Subject: Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file. > On Oct 26, 201

Re: [edk2] [BaseTools] Library GUIDs missing from Guid.xref file.

2016-10-26 Thread Lin, Derek (HPS UEFI Dev)
Hi Andrew, We also see this issue recently. And we have a fix. I've send email patch minutes ago. Thanks, Derek From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Thursday, October 27, 2016 9:08 AM To: edk2-devel Subject: [edk2] [BaseTools] Library GUIDs

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

2016-04-29 Thread Lin, Derek (HPS UEFI Dev)
Thanks. I agree, will send a patch soon. Derek -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Friday, April 29, 2016 6:29 PM To: Lin, Derek (HPS UEFI Dev) ; Zhang, Chao B ; El-Haj-Mahmoud, Samer ; edk2-devel@lists.01.org Subject: RE: [PATCH] SecurityPkg

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

2016-04-29 Thread Lin, Derek (HPS UEFI Dev)
To: Zhang, Chao B ; El-Haj-Mahmoud, Samer ; edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Lin, Derek (HPS UEFI Dev) ; Yao, Jiewen Subject: RE: [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe Chao I have question on this patch. I asked in another mail. If there is no TPM 2.0 part

Re: [edk2] [PATCH] SecurityPkg: Fix bug in TPM 1.2 SelfTest

2016-04-28 Thread Lin, Derek (HPS UEFI Dev)
This has been sent and reviewed, but not committed yet. From: El-Haj-Mahmoud, Samer Sent: Friday, April 29, 2016 4:29:27 AM To: edk2-devel@lists.01.org Cc: chao.b.zh...@intel.com; El-Haj-Mahmoud, Samer; El-Haj-Mahmoud, Samer; Lin, Derek (HPS UEFI Dev

Re: [edk2] [PATCH] SecurityPkg: Fix TPM 1.2 NV Storage Command Size byte order

2016-04-28 Thread Lin, Derek (HPS UEFI Dev)
This patch has been sent and reviewed month ago, but not committed. -Original Message- From: El-Haj-Mahmoud, Samer Sent: Friday, April 29, 2016 4:24 AM To: edk2-devel@lists.01.org Cc: chao.b.zh...@intel.com; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer ; Lin, Derek (HPS UEFI Dev

Re: [edk2] [PATCH] MdeModulePkg: Rescale ConSplitter Absolute Pointer.

2016-03-19 Thread Lin, Derek (HPS UEFI Dev)
The U64 mult/div fix seems good. Thanks for fixing it! Thanks, Derek -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, March 17, 2016 9:13 AM To: Laszlo Ersek Cc: Ni, Ruiyu ; Tian, Feng ; Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Subject: Re