Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-23 Thread Marcin Wojtas
Hi Laszlo, pt., 22 lut 2019 o 21:08 Laszlo Ersek napisał(a): > > On 02/22/19 20:21, Ard Biesheuvel wrote: > > On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: > >> > >> Reviewed-by: Liming Gao > >> > > > > Incremental builds are still broken for me, even with this patch. Is > > anyone else

Re: [edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-31 Thread Marcin Wojtas
czw., 31 sty 2019 o 11:28 Leif Lindholm napisał(a): > > On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote: > > Hi Leif, > > > > Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h > > / ArmPkg/Library/ArmLib/ArmLib.c would be a pr

Re: [edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-30 Thread Marcin Wojtas
roken-out function to ArmPkg at some point.) > > For the series: > Reviewed-by: Leif Lindholm > > Pushed as b0bb325f20..0a7d8e7d93. > > On Mon, Jan 28, 2019 at 10:45:10AM +0100, Marcin Wojtas wrote: > > Hi, > > > > The third version of the patchset move

[edk2] [platforms: PATCH v3 5/5] Marvell/Armada7k8k: Read DRAM settings from ARM-TF

2019-01-28 Thread Marcin Wojtas
Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 3 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.h | 25 Silicon/Marvell/Include/IndustryStandard/MvSmc.h

[edk2] [platforms: PATCH v3 4/5] Marvell/Library: ArmadaSoCDescLib: Add North Bridge description

2019-01-28 Thread Marcin Wojtas
From: Grzegorz Jaszczyk For upcomming patch there is need to get AP806 base, provide required getter function for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib

[edk2] [platforms: PATCH v3 3/5] Marvell/Library: Introduce common header for the SMC ID's

2019-01-28 Thread Marcin Wojtas
Marvell firmware allows to use SiP services other than for ComPhy handling. In order to avoid spreading the SMC ID's definitions across many files, introduce common header for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell

[edk2] [platforms: PATCH v3 2/5] Marvell/Armada7k8k: Shift PEI stack base and extend memory reservation

2019-01-28 Thread Marcin Wojtas
: * the ARM-TF (0x400 - 0x420) * OP-TEE (0x440 - 0x540) * additional reserved region (0x420 - 0x440) Describe regions with the new PCDs and set the PEI stack base address in the latter (0x43F). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v3 1/5] Marvell/Armada7k8k: Refactor reserving memory regions

2019-01-28 Thread Marcin Wojtas
Extract reserving memory region in the Hob list into a separate routine. It is a preparation for adding multiple of such regions in a following patch. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library

[edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-28 Thread Marcin Wojtas
* 4/4 - Move new SMC ID to MvSmc.h - Include ArmadaSoCDescLib.h directly (instead indirectly via BoardDesc.h) - Remove ARMADA7K8K_AP806_INDEX macro Grzegorz Jaszczyk (2): Marvell/Library: ArmadaSoCDescLib: Add North Bridge description Marvell/Armada7k8k: Read DRAM settings from ARM-TF

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-23 Thread Marcin Wojtas
Hi Leif, śr., 23 sty 2019 o 10:42 Leif Lindholm napisał(a): > > On Wed, Jan 23, 2019 at 09:28:40AM +0100, Marcin Wojtas wrote: > > wt., 22 sty 2019 o 22:10 Leif Lindholm > > napisał(a): > > > > > > On Tue, Jan 22, 2019 at 09:56:14PM +0100, Marcin Wojtas wr

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-23 Thread Marcin Wojtas
Hi Leif, wt., 22 sty 2019 o 22:10 Leif Lindholm napisał(a): > > On Tue, Jan 22, 2019 at 09:56:14PM +0100, Marcin Wojtas wrote: > > > > > I think I gave my suggestion for the resolution of this problem (with > > > > > moving StackBase to 0x054

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-22 Thread Marcin Wojtas
Hi Leif, wt., 22 sty 2019 o 21:26 Leif Lindholm napisał(a): > > On Tue, Jan 22, 2019 at 08:27:10PM +0100, Marcin Wojtas wrote: > > > > > > In order to fix this, extend the region which is non-accessible > > > > > > by the OS to cover both th

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-22 Thread Marcin Wojtas
Hi Leif, wt., 22 sty 2019 o 20:06 Leif Lindholm napisał(a): > > On Tue, Jan 22, 2019 at 07:26:58PM +0100, Marcin Wojtas wrote: > > Hi Leif, > > > > wt., 22 sty 2019 o 18:26 Leif Lindholm > > napisał(a): > > > > > > On Tue, Jan 22, 2019 at 02:32

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-22 Thread Marcin Wojtas
Hi Leif, wt., 22 sty 2019 o 18:26 Leif Lindholm napisał(a): > > On Tue, Jan 22, 2019 at 02:32:19AM +0100, Marcin Wojtas wrote: > > Recent changes in the ARM-TF configure its runtime serices region > > as protected, hence the hitherto PEI stack base address (0x41F

Re: [edk2] [platforms: PATCH v2 2/4] Marvell/Library: Introduce common header for the SMC ID's

2019-01-22 Thread Marcin Wojtas
Hi Leif, wt., 22 sty 2019 o 18:36 Leif Lindholm napisał(a): > > On Tue, Jan 22, 2019 at 02:32:20AM +0100, Marcin Wojtas wrote: > > Marvell firmware allows to use SiP services other than > > for ComPhy handling. In order to avoid spreading the SMC > > ID's definitions acro

[edk2] [platforms: PATCH v2 4/4] Marvell/Armada7k8k: Read DRAM settings from ARM-TF

2019-01-21 Thread Marcin Wojtas
Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 3 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.h | 25 Silicon/Marvell/Include/Library/MvSmc.h | 1 + Silicon/Marvell

[edk2] [platforms: PATCH v2 3/4] Marvell/Library: ArmadaSoCDescLib: Add North Bridge description

2019-01-21 Thread Marcin Wojtas
From: Grzegorz Jaszczyk For upcomming patch there is need to get AP806 base, provide required getter function for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6

[edk2] [platforms: PATCH v2 2/4] Marvell/Library: Introduce common header for the SMC ID's

2019-01-21 Thread Marcin Wojtas
Marvell firmware allows to use SiP services other than for ComPhy handling. In order to avoid spreading the SMC ID's definitions across many files, introduce common header for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell

[edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Shift PEI stack base

2019-01-21 Thread Marcin Wojtas
- 0x540) within a single area (0x400 - 0x540). Set the PEI stack base address between both images (0x43F). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [platforms: PATCH v2 0/4] Armada7k8k memory handling update

2019-01-21 Thread Marcin Wojtas
ell/Library: ArmadaSoCDescLib: Add North Bridge description Marvell/Armada7k8k: Read DRAM settings from ARM-TF Marcin Wojtas (2): Marvell/Armada7k8k: Shift PEI stack base Marvell/Library: Introduce common header for the SMC ID's Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.

Re: [edk2] [platforms: PATCH 3/3] Marvell/Armada7k8k: Read DRAM settings from ARM-TF

2019-01-21 Thread Marcin Wojtas
Hi Leif, pon., 21 sty 2019 o 12:51 Leif Lindholm napisał(a): > > On Mon, Jan 21, 2019 at 11:52:11AM +0100, Marcin Wojtas wrote: > > From: Grzegorz Jaszczyk > > > > The memory controller registers are marked as secure in the latest > > ARM-TF for Armada SoCs. It is

Re: [edk2] [platforms: PATCH 2/3] Marvell/Library: ArmadaSoCDescLib: Add North Bridge description

2019-01-21 Thread Marcin Wojtas
Hi Leif, pon., 21 sty 2019 o 12:32 Leif Lindholm napisał(a): > > On Mon, Jan 21, 2019 at 11:52:10AM +0100, Marcin Wojtas wrote: > > From: Grzegorz Jaszczyk > > > > For upcomming patch there is need to get AP806 base, provide required > > getter function for

Re: [edk2] [platforms: PATCH 1/3] Marvell: Armada7k8k: Shift PEI stack base

2019-01-21 Thread Marcin Wojtas
Hi Leif, pon., 21 sty 2019 o 12:26 Leif Lindholm napisał(a): > > On Mon, Jan 21, 2019 at 11:52:09AM +0100, Marcin Wojtas wrote: > > Recent changes in the ARM-TF configure its runtime serices region > > as protected, hence the hitherto PEI stack base address (0x41F

[edk2] [platforms: PATCH 3/3] Marvell/Armada7k8k: Read DRAM settings from ARM-TF

2019-01-21 Thread Marcin Wojtas
Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 3 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.h | 27 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c | 55

[edk2] [platforms: PATCH 2/3] Marvell/Library: ArmadaSoCDescLib: Add North Bridge description

2019-01-21 Thread Marcin Wojtas
From: Grzegorz Jaszczyk For upcomming patch there is need to get AP806 base, provide required getter function for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 1

[edk2] [platforms: PATCH 1/3] Marvell: Armada7k8k: Shift PEI stack base

2019-01-21 Thread Marcin Wojtas
- 0x540) within a single area and set the PEI stack base address between both images. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [platforms: PATCH 0/3] Armada7k8k memory handling update

2019-01-21 Thread Marcin Wojtas
Marvell/Armada7k8k: Read DRAM settings from ARM-TF Marcin Wojtas (1): Marvell: Armada7k8k: Shift PEI stack base Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +- Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 3

Re: [edk2] [platforms: PATCH v3 03/12] Marvell/Library: Introduce MvGpioLib class

2019-01-17 Thread Marcin Wojtas
Thanks a lot! Best regards, Marcin czw., 17 sty 2019 o 15:18 Leif Lindholm napisał(a): > > Series pushed as 944fbb62d6..9b725b6ebb > > Thanks! > > On Thu, Jan 17, 2019 at 01:19:52PM +0100, Marcin Wojtas wrote: > > Hi Leif, > > > > Sorry for omitting. I c

Re: [edk2] [platforms: PATCH v3 00/12] Armada 7k8k GPIO support

2019-01-17 Thread Marcin Wojtas
t; Leif > > On Thu, Jan 17, 2019 at 12:15:03PM +0100, Marcin Wojtas wrote: > > Hi, > > > > I submit v3 of the GPIO patchset for the Marvell SoCs. > > The changes are not significant and they address all the comments > >

Re: [edk2] [platforms: PATCH v3 03/12] Marvell/Library: Introduce MvGpioLib class

2019-01-17 Thread Marcin Wojtas
class" from subject line) > > With that: > Reviewed-by: Leif Lindholm > > On Thu, Jan 17, 2019 at 12:15:06PM +0100, Marcin Wojtas wrote: > > Following patches will add two drivers that are capable > > of producing the generic EMBEDDED_GPIO protocol. In order > >

[edk2] [platforms: PATCH v3 12/12] Marvell/Armada7k8k: Introduce NonDiscoverable device init routines

2019-01-17 Thread Marcin Wojtas
called 'VBUS') enabling routines for supported platforms (Armada70x0Db, Armada80x0Db, Armada80x0McBin). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Marvell.dec

[edk2] [platforms: PATCH v3 11/12] Marvell/Armada7k8k: Enable GPIO drivers compilation

2019-01-17 Thread Marcin Wojtas
Enable building new GPIO drivers before adding VBUS pins handling. Update relevant boards .dsc files with IO expander information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

[edk2] [platforms: PATCH v3 10/12] Marvell/Drivers: MvPca95xxDxe: Introduce GPIO expander driver

2019-01-17 Thread Marcin Wojtas
. in the board description library to specify the expander model on a board (instead of passing a raw number). Update relevant libraries. Driver is based on initial work done by Allen Yan . Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers

[edk2] [platforms: PATCH v3 09/12] Marvell/Drivers: I2c: Use common header for macros

2019-01-17 Thread Marcin Wojtas
Hitherto I2c solution used same macros, defined in multiple places. Move them to a new common header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 --- Silicon

[edk2] [platforms: PATCH v3 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-17 Thread Marcin Wojtas
of the Armada 7k8k platforms, add a common enum type. Based on original work of Jing Hua . Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.inf | 44 +++ Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.h | 49

[edk2] [platforms: PATCH v3 07/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-17 Thread Marcin Wojtas
Introduce new callback that can provide information about GPIO SoC controllers, as well as on-board I2C IO expanders. According ArmadaSoCDescLib ArmadaBoardDescLib routines are used for obtaining required data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v3 05/12] Marvell/Armada70x0Db: Extend board description library with GPIO

2019-01-17 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada70x0Db comunity board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db

[edk2] [platforms: PATCH v3 06/12] Marvell/Armada80x0Db: Extend board description library with GPIO

2019-01-17 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0Db board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db

[edk2] [platforms: PATCH v3 03/12] Marvell/Library: Introduce MvGpioLib class

2019-01-17 Thread Marcin Wojtas
and controllers of the Armada 7k8k platforms, add the common enum types. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Marvell.dec | 1 + Silicon/Marvell/Library/MvGpioLib/MvGpioLib.inf | 32 + Silicon/Marvell/Include/Library/MvGpioLib.h | 68 ++ Silicon/Marvell

[edk2] [platforms: PATCH v3 04/12] SolidRun/Armada80x0McBin: Extend board description library with GPIO

2019-01-17 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform

[edk2] [platforms: PATCH v3 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information

2019-01-17 Thread Marcin Wojtas
This patch extends library with GPIO devices per-board description. Both embedded SoC controllers and I2C IO expanders are supported. Add a helper routine for obtaining information about the latter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed

[edk2] [platforms: PATCH v3 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2019-01-17 Thread Marcin Wojtas
EmbeddedGpio.h. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf | 1 + Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib

[edk2] [platforms: PATCH v3 00/12] Armada 7k8k GPIO support

2019-01-17 Thread Marcin Wojtas
local headers - Make STATIC names more generic - s/GetInitializerForType/NonDiscoverableDeviceInitializerGet/ - Use global enum for McBin GPIO controller Marcin Wojtas (12): Marvell/Library: ArmadaSoCDescLib: Add GPIO information Marvell/Library: ArmadaBoardDescLib: Add GPIO infor

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Marcin Wojtas
wt., 15 sty 2019 o 11:12 Leif Lindholm napisał(a): > > On Tue, Jan 15, 2019 at 11:05:12AM +0100, Marcin Wojtas wrote: > > > > Anyway, I tried to play with the MV_BOARD_GPIO_DESCRIPTION to be the > > > > global variable, but was not convinced by the outcome

Re: [edk2] [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-15 Thread Marcin Wojtas
wt., 15 sty 2019 o 11:04 Leif Lindholm napisał(a): > > On Tue, Jan 15, 2019 at 07:19:04AM +0100, Marcin Wojtas wrote: > > > > + if (MmioRead32 (BaseAddress + MV_GPIO_OUT_EN_REG) & (1 << GpioPin)) { > > > > +*Mode = GPIO_MODE_INPUT; > > > >

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-15 Thread Marcin Wojtas
wt., 15 sty 2019 o 10:56 Leif Lindholm napisał(a): > > On Tue, Jan 15, 2019 at 07:05:42AM +0100, Marcin Wojtas wrote: > > > > index f71bfc4..e348b85 100644 > > > > --- a/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > > +++ b/Silicon/

Re: [edk2] [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-14 Thread Marcin Wojtas
Hi Leif, wt., 15 sty 2019 o 00:32 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:35AM +0100, Marcin Wojtas wrote: > > Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers, > > one in AP806 and two in each south bridge hardware blocks. > > > >

Re: [edk2] [platforms: PATCH v2 07/12] Marvell/Protocol: Introduce GPIO helper header

2019-01-14 Thread Marcin Wojtas
Hi Leif, wt., 15 sty 2019 o 00:12 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:34AM +0100, Marcin Wojtas wrote: > > From: jinghua > > > > This patch introduces a helper header that can be used by > > multiple EMBEDDED_GPIO protocol producers (e.

Re: [edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-14 Thread Marcin Wojtas
Hi Leif, pon., 14 sty 2019 o 23:58 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:33AM +0100, Marcin Wojtas wrote: > > Introduce new callback that can provide information > > about GPIO SoC controllers, as well as on-board > > I2C IO expanders. Ac

Re: [edk2] [platforms: PATCH v2 04/12] Marvell/Armada70x0Db: Extend board description library with GPIO

2019-01-14 Thread Marcin Wojtas
Hi Leif, pon., 14 sty 2019 o 23:41 Leif Lindholm napisał(a): > > On Thu, Jan 10, 2019 at 02:44:31AM +0100, Marcin Wojtas wrote: > > This patch implements ArmadaBoarDescLib library for > > Armada70x0Db comunity board and introduces ArmadaBoardGpioGet > > routine with

[edk2] [platforms: PATCH v2 12/12] Marvell/Armada7k8k: Introduce NonDiscoverable device init routines

2019-01-09 Thread Marcin Wojtas
called 'VBUS') enabling routines for supported platforms (Armada70x0Db, Armada80x0Db, Armada80x0McBin). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Marvell.dec | 1 + Platform

[edk2] [platforms: PATCH v2 11/12] Marvell/Armada7k8k: Enable GPIO drivers compilation

2019-01-09 Thread Marcin Wojtas
Enable building new GPIO drivers before adding VBUS pins handling. Update relevant boards .dsc files with IO expander information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

[edk2] [platforms: PATCH v2 10/12] Marvell/Drivers: MvPca95xxDxe: Introduce GPIO expander driver

2019-01-09 Thread Marcin Wojtas
. in the board description library to specify the expander model on a board (instead of passing a raw number). Update relevant libraries. Driver is based on initial work done by Allen Yan . Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers

[edk2] [platforms: PATCH v2 09/12] Marvell/Drivers: I2c: Use common header for macros

2019-01-09 Thread Marcin Wojtas
Hitherto I2c solution used same macros, defined in multiple places. Move them to a new common header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 --- Silicon

[edk2] [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver

2019-01-09 Thread Marcin Wojtas
of the Armada 7k8k platforms, add a common enum type. Based on original work of Jing Hua . Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.inf | 44 +++ Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.h | 49

[edk2] [platforms: PATCH v2 07/12] Marvell/Protocol: Introduce GPIO helper header

2019-01-09 Thread Marcin Wojtas
controller a helper function was added - MarvellGpioGetProtocol(). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Include/Protocol/MvGpio.h | 156 1 file changed, 156 insertions(+) create mode 100644 Silicon/Marvell

[edk2] [platforms: PATCH v2 06/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support

2019-01-09 Thread Marcin Wojtas
Introduce new callback that can provide information about GPIO SoC controllers, as well as on-board I2C IO expanders. According ArmadaSoCDescLib ArmadaBoardDescLib routines are used for obtaining required data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v2 05/12] Marvell/Armada80x0Db: Extend board description library with GPIO

2019-01-09 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0Db comunity board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Contributed-under: TianoCore Contribution

[edk2] [platforms: PATCH v2 04/12] Marvell/Armada70x0Db: Extend board description library with GPIO

2019-01-09 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada70x0Db comunity board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db

[edk2] [platforms: PATCH v2 03/12] SolidRun/Armada80x0McBin: Extend board description library with GPIO

2019-01-09 Thread Marcin Wojtas
This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet routine with per-board GPIO expander description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/SolidRun/Armada80x0McBin

[edk2] [platforms: PATCH v2 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information

2019-01-09 Thread Marcin Wojtas
This patch extends library with GPIO devices per-board description. Both embedded SoC controllers and I2C IO expanders are supported. Add a helper routine for obtaining information about the latter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon

[edk2] [platforms: PATCH v2 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2019-01-09 Thread Marcin Wojtas
EmbeddedGpio.h. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf | 1 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 1 + Silicon

[edk2] [platforms: PATCH v2 00/12] Armada 7k8k GPIO support

2019-01-09 Thread Marcin Wojtas
ype/NonDiscoverableDeviceInitializerGet/ - Use global enum for McBin GPIO controller Marcin Wojtas (11): Marvell/Library: ArmadaSoCDescLib: Add GPIO information Marvell/Library: ArmadaBoardDescLib: Add GPIO information SolidRun/Armada80x0McBin: Extend board description library with GPIO Marvell/Armada70x

[edk2] [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h

2018-12-11 Thread Marcin Wojtas
Recent changes in EDK2 resulted in compilation break of all Marvell platforms, because the applications include deprecated ShellBase.h header. Fix that. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Applications/EepromCmd/EepromCmd.c

Re: [edk2] [PATCH] ShellPkg: Remove ShellPkg wrapper header files

2018-12-11 Thread Marcin Wojtas
Leif, David, Thanks for the heads up. I finally will have a slot for the edk2 today - will fix and submit. Best regards, Marcin wt., 11 gru 2018 o 08:16 David F. napisał(a): > I ran in to it too, it was easy fix, the headers changed to those in > MDEPKG and the header file name changed. IIRC

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-20 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > I think all of my comments on this patch can be summarised as "what is > > > an AP in this context"? > > > >

Re: [edk2] [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework

2018-11-20 Thread Marcin Wojtas
Thanks! Best regards, Marcin wt., 20 lis 2018 o 10:58 Ard Biesheuvel napisał(a): > > On Mon, 19 Nov 2018 at 07:54, Marcin Wojtas wrote: > > > > Hi, > > > > The sixth version of the patchset applies minor correction in the > > last patch and also simpli

Re: [edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-19 Thread Marcin Wojtas
wt., 20 lis 2018 o 06:59 Wu, Hao A napisał(a): > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Wu, Hao A > > Sent: Tuesday, November 13, 2018 4:29 PM > > To: Marcin Wojtas > > Cc: Tomasz Mic

[edk2] [platforms: PATCH v6 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-19 Thread Marcin Wojtas
of XenonDxe. In the new version of the driver apart from using SdMmcOverride protocol, this patch utilizes newly added controllers' description in MvBoardDesc protocol, as well as improved PHY configuration sequence. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v6 6/8] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Drivers

[edk2] [platforms: PATCH v6 5/8] Marvell/Armada80x0Db: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v6 4/8] Marvell/Armada70x0Db: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v6 3/8] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v6 2/8] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-18 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h

[edk2] [platforms: PATCH v6 1/8] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-18 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel

[edk2] [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework

2018-11-18 Thread Marcin Wojtas
yPhase parameter to PhaseData - update UHS_MODE_SEL only for HS200/HS400 in XenonSdMmcHcUhsSignaling - use local macros for standard SDHC registers in order not to include private MdeModulePkg header v1 -> v2 * 1/7 and 7/7 - adjust to modified SdMmcOverride NotifyPhase and Capabilit

Re: [edk2] [platforms: PATCH v5 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-18 Thread Marcin Wojtas
Hi Ard, > > +**/ > > +EFI_STATUS > > +EFIAPI > > +XenonHcRwMmio ( > > + IN EFI_PCI_IO_PROTOCOL *PciIo, > > + IN UINT8 BarIndex, > > + IN UINT32Offset, > > + IN BOOLEAN Read, > > + IN UINT8 Count, > > + IN

Re: [edk2] [platforms: PATCH 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information

2018-11-13 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 02:12 Leif Lindholm napisał(a): > > On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote: > > This patch extends library with GPIO devices per-board > > description. Both embedded SoC controllers and > > I2C IO expanders are support

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-13 Thread Marcin Wojtas
Hi Leif, śr., 14 lis 2018 o 02:10 Leif Lindholm napisał(a): > > On Sat, Oct 20, 2018 at 03:57:30AM +0200, Marcin Wojtas wrote: > > This patch introduces new library callback (ArmadaSoCDescGpioGet ()), > > which dynamically allocates and fills MV_SOC_GPIO_DESC structur

[edk2] [platforms: PATCH v5 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe

2018-11-13 Thread Marcin Wojtas
of XenonDxe. In the new version of the driver apart from using SdMmcOverride protocol, this patch utilizes newly added controllers' description in MvBoardDesc protocol, as well as improved PHY configuration sequence. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v5 6/8] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-13 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Drivers

[edk2] [platforms: PATCH v5 5/8] Marvell/Armada80x0Db: Introduce board description library

2018-11-13 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v5 4/8] Marvell/Armada70x0Db: Introduce board description library

2018-11-13 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v5 3/8] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-13 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v5 2/8] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-13 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h

[edk2] [platforms: PATCH v5 1/8] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-13 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel

[edk2] [platforms: PATCH v5 0/8] Armada7k8k Xenon driver rework

2018-11-13 Thread Marcin Wojtas
cUhsSignaling - use local macros for standard SDHC registers in order not to include private MdeModulePkg header v1 -> v2 * 1/7 and 7/7 - adjust to modified SdMmcOverride NotifyPhase and Capability routines Marcin Wojtas (2): Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

Re: [edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-13 Thread Marcin Wojtas
advance. > Ard gave his RB to 2/4 and 3/4. Moreover he pointed a typo in 3/4 commit message - should I repost, or could those be included when applying the patches (unless you don't request any code change, of course)? Best regards, Marcin > Best Regards, > Hao Wu > > > > -

[edk2] [platforms: PATCH v4 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1

[edk2] [platforms: PATCH v4 5/7] Marvell/Armada80x0Db: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v4 4/7] Marvell/Armada70x0Db: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v4 3/7] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 22 +++- 1

[edk2] [platforms: PATCH v4 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-09 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Socionext/SynQuacer

[edk2] [platforms: PATCH v4 0/7] Armada7k8k Xenon driver rework

2018-11-09 Thread Marcin Wojtas
tifyPhase and Capability routines Marcin Wojtas (1): Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride Tomasz Michalec (6): Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information SolidRun/Armada80x0McBin: Introduce board description library Marvell/Armada70x0Db: Introd

[edk2] [PATCH v4 4/4] MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency

2018-11-09 Thread Marcin Wojtas
Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 + MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 8 +++ MdeModulePkg/Include/Protocol/SdMmcOverride.h | 7 -- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/Em

[edk2] [PATCH v4 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride

2018-11-09 Thread Marcin Wojtas
-by: Marcin Wojtas --- MdeModulePkg/Include/Protocol/SdMmcOverride.h | 1 + MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 31 +--- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 18 3 files changed, 46 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg

[edk2] [PATCH v4 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-11-09 Thread Marcin Wojtas
(SdMmcHcUhsSignaling). After it is executed, the protocol producer can override the values if needed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 34 MdeModulePkg/Include/Protocol/SdMmcOverride.h| 17

[edk2] [PATCH v4 1/4] MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in NotifyPhase

2018-11-09 Thread Marcin Wojtas
: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- MdeModulePkg/Include/Protocol/SdMmcOverride.h| 4 +++- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 12 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg

[edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-09 Thread Marcin Wojtas
pdating BaseClkFreq via Capability instead of the independent callback. Marcin Wojtas (2): MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in NotifyPhase MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency Tomasz Michalec (2): MdeModulePkg/SdMmcPciHcDxe: Add UhsSig

  1   2   3   4   5   6   7   8   >