[edk2] [platforms: PATCH v2 07/25] Marvell/Library: RealTimeClockLib: Simplify obtaining base address

2018-06-17 Thread Marcin Wojtas
. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Marvell.dec | 2 +- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- Platform/Marvell

[edk2] [platforms: PATCH v2 10/25] Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol

2018-06-17 Thread Marcin Wojtas
MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 2 +- Silicon/Marvell/Include/Library/MvHwDescLib.h | 26

[edk2] [platforms: PATCH v2 06/25] Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol

2018-06-17 Thread Marcin Wojtas
MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Use the protocol and pass information to further to the library init routine. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell

[edk2] [platforms: PATCH v2 05/25] Marvell/Armada7k8k: Enable board description driver compilation

2018-06-17 Thread Marcin Wojtas
From: jinghua This patch enables compilation of MvBoardDescDxe driver for Armada70x0-DB, Armada80x0-DB and Armada80x0McBin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: jinghua Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k

[edk2] [platforms: PATCH v2 01/25] Marvell/Library: Introduce ArmadaSoCDescLib class

2018-06-17 Thread Marcin Wojtas
-by: Marcin Wojtas --- Silicon/Marvell/Marvell.dec | 4 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 +++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 35

[edk2] [platforms: PATCH v2 04/25] Marvell/Drivers: MvBoardDesc: Introduce board description driver

2018-06-17 Thread Marcin Wojtas
to that there is a separation between obtaining the platform description and the drivers. A first example of the board description callback is information about UTMI controllers and type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: jinghua Signed-off-by: Marcin Wojtas --- Silicon/Marvell

[edk2] [platforms: PATCH v2 00/25] Armada hardware description rework

2018-06-17 Thread Marcin Wojtas
age of MVHW_DEV_ENABLED *25 - add parentheses in if condition Marcin Wojtas (21): Marvell/Library: Introduce ArmadaBoardDescLib class Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol Marvell/Library: RealTimeClockLib: Simplify obtaining base address Marvell/Armada7k8k: Ext

Re: [edk2] [platforms: PATCH v2 0/4] Armada7k8k new boards support

2018-06-13 Thread Marcin Wojtas
2018-06-13 17:35 GMT+02:00 Leif Lindholm : > On Wed, Jun 13, 2018 at 05:10:08PM +0200, Ard Biesheuvel wrote: >> On 13 June 2018 at 16:23, Leif Lindholm wrote: >> > On Wed, Jun 13, 2018 at 11:02:49AM +0200, Marcin Wojtas wrote: >> >> Hi, >> >> >> &g

[edk2] [platforms: PATCH v2 0/4] Armada7k8k new boards support

2018-06-13 Thread Marcin Wojtas
comments/remarks. Best regards, Marcin Marcin Wojtas (4): Marvell/Armada7k8k: Use common .fdf file Marvell/Armada7k8k: Introduce support for Armada-8040-McBin Marvell/Armada7k8k: Introduce support for Armada-8040-Db Marvell/Armada70x0Db: Enable building with NOOPT flag Platform/Marvell

[edk2] [platforms: PATCH v2 2/4] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-13 Thread Marcin Wojtas
enabled, as no issues were observed on v1.3 board so far. However higher speed modes (HS200) and full stability will be gained after Xenon driver improvements merge. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/SolidRun/Armada80x0McBin

[edk2] [platforms: PATCH v2 3/4] Marvell/Armada7k8k: Introduce support for Armada-8040-Db

2018-06-13 Thread Marcin Wojtas
-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 158 1 file changed, 158 insertions(+) create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db

[edk2] [platforms: PATCH v2 4/4] Marvell/Armada70x0Db: Enable building with NOOPT flag

2018-06-13 Thread Marcin Wojtas
Newly added boards can build with TARGET set to NOOPT, so align the Armada70x0Db. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform

[edk2] [platforms: PATCH v2 1/4] Marvell/Armada7k8k: Use common .fdf file

2018-06-13 Thread Marcin Wojtas
changes for entire SoC family won't require any duplication and at the same time the per-board .fdf.inc will allow better suiting the .FD file contents. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada70x0Db

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-13 Thread Marcin Wojtas
> > On Fri, Jun 08, 2018 at 05:33:58PM +0200, Marcin Wojtas wrote: >> Hi, >> >> This big patchset reworks handling of the SoC and Boards' description >> to the final version. Hitherto mechanism of hardcoded structures >> and parsing PCDs inside the dri

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
;> > >> > On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: >> >> Add new board description file Armada80x0McBin.dsc, >> >> which uses common Armada7k8k.fdf file. By default >> >> build capsule components. >> >> Most of the inte

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
2018-06-12 16:27 GMT+02:00 Ard Biesheuvel : > On 12 June 2018 at 16:23, Leif Lindholm wrote: >> I have only bikeshedding-level comments on this set, inline below. >> (Applies to at lest 2-3.) >> >> On Tue, Jun 12, 2018 at 04:06:34PM +0200, Marcin Wojtas wrote: >>

Re: [edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
2018-06-12 16:11 GMT+02:00 Ard Biesheuvel : > Marcin, > > Thanks for focusing on McBin first. > > > On 12 June 2018 at 16:06, Marcin Wojtas wrote: >> Add new board description file Armada80x0McBin.dsc, >> which uses common Armada7k8k.fdf file. By default >&g

[edk2] [platforms: PATCH 2/3] Marvell/Armada7k8k: Introduce support for Armada-8040-McBin

2018-06-12 Thread Marcin Wojtas
enabled, as no issues were observed on v1.3 board so far. However higher speed modes (HS200) and full stability will be gained after Xenon driver improvements merge. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/SolidRun/Armada80x0McBin

[edk2] [platforms: PATCH 3/3] Marvell/Armada7k8k: Introduce support for Armada-8040-Db

2018-06-12 Thread Marcin Wojtas
-by: Marcin Wojtas --- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 158 1 file changed, 158 insertions(+) create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db

[edk2] [platforms: PATCH 1/3] Marvell/Armada7k8k: Use common .fdf file

2018-06-12 Thread Marcin Wojtas
changes for entire SoC family won't require any duplication and at the same time the per-board .fdf.inc will allow better suiting the .FD file contents. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc

[edk2] [platforms: PATCH 0/3] Armada7k8k new boards support

2018-06-12 Thread Marcin Wojtas
://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boards-upstream-r20180612 I'm looking forward to review and any comments/remarks. Best regards, Marcin Marcin Wojtas (3): Marvell/Armada7k8k: Use common .fdf file Marvell/Armada7k8k: Introduce support for Armada-8040-McBin Marvell

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Marcin Wojtas
Hi Ard, 2018-06-11 14:01 GMT+02:00 Ard Biesheuvel : > On 11 June 2018 at 13:49, Marcin Wojtas wrote: >> Hi Ard, >> >> 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : >>> Marcin, >>> >>> I am a bit reluctant to review another huge set of Armada patches

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Marcin Wojtas
one. Best regards, Marcin > > edk2-platforms is not intended as a baseline for Marvell customers to > base their private trees on, we actually prefer code that runs on > systems that are widely available (such as MacchiatoBin) > > Thanks, > Ard. > > > On 8 June 2018 at 1

[edk2] [platforms PATCH 22/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information

2018-06-08 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescI2cGet ()), which dynamically allocates and fills MV_SOC_I2C_DESC structure with the SoC description of I2c controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing

[edk2] [platforms PATCH 24/25] Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC

2018-06-08 Thread Marcin Wojtas
introduced MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 37 +--- Silicon/Marvell

[edk2] [platforms PATCH 25/25] Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency

2018-06-08 Thread Marcin Wojtas
Finally, after switching to new MV_BOARD_DESC solution in all drivers, stop using MvHwDescLib.h by its last user and safely remove this header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/Net/MvPhyDxe

[edk2] [platforms PATCH 21/25] Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC

2018-06-08 Thread Marcin Wojtas
introduced MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c | 35 Silicon/Marvell

[edk2] [platforms PATCH 19/25] Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support

2018-06-08 Thread Marcin Wojtas
Introduce new callback that can provide information about MDIO controllers to the Mdio driver. Extend ArmadaBoardDescLib with new structure MV_BOARD_MDIO_DESC, for holding board specific data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua

[edk2] [platforms PATCH 18/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information

2018-06-08 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescMdioGet ()), which dynamically allocates and fills MV_SOC_MDIO_DESC structure with the SoC description of Mdio controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing

[edk2] [platforms PATCH 17/25] Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC

2018-06-08 Thread Marcin Wojtas
the description from newly introduced MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Include/Library/MvHwDescLib.h | 39 --- Silicon

[edk2] [platforms PATCH 20/25] Marvell/Drivers: MvMdioDxe: Enable 64bit addressing

2018-06-08 Thread Marcin Wojtas
In order to be prepared for operating on registers in 64-bit address space, this patch adjusts the MDIO controllers base address array. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/Net/MvMdioDxe

[edk2] [platforms PATCH 16/25] Marvell/Drivers: MvBoardDesc: Extend protocol with COMPHY support

2018-06-08 Thread Marcin Wojtas
structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 60 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 + Silicon/Marvell/Include/Library

[edk2] [platforms PATCH 13/25] Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC

2018-06-08 Thread Marcin Wojtas
controller description from newly introduced MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/NonDiscoverableDxe

[edk2] [platforms PATCH 12/25] Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI

2018-06-08 Thread Marcin Wojtas
Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 180 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 2 + Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 31 Silicon

[edk2] [platforms PATCH 07/25] Marvell/Library: RealTimeClockLib: Simplify obtaining base address

2018-06-08 Thread Marcin Wojtas
. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 29 Silicon

[edk2] [platforms PATCH 15/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information

2018-06-08 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescComPhyGet ()), which dynamically allocates and fills MV_SOC_COMPHY_DESC structure with the SoC description of ComPhy SerDes controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua

[edk2] [platforms PATCH 11/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI

2018-06-08 Thread Marcin Wojtas
This patch introduces new library callbacks for NonDiscoverable devices i.e. AHCI/XHCI/SDMMC. They dynamically allocate and fill according structures with the SoC description of the devices. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua

[edk2] [platforms PATCH 14/25] Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC

2018-06-08 Thread Marcin Wojtas
newly introduced MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 1 - Silicon

[edk2] [platforms PATCH 10/25] Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol

2018-06-08 Thread Marcin Wojtas
MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 43 Silicon/Marvell/Drivers/Net

[edk2] [platforms PATCH 09/25] Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support

2018-06-08 Thread Marcin Wojtas
. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 60 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 + Silicon/Marvell/Include/Library

[edk2] [platforms PATCH 08/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information

2018-06-08 Thread Marcin Wojtas
This patch introduces new library callback (ArmadaSoCDescPp2Get ()), which dynamically allocates and fills MV_SOC_PP2_DESC structure with the SoC description of PP2 NICs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon

[edk2] [platforms PATCH 06/25] Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol

2018-06-08 Thread Marcin Wojtas
MARVELL_BOARD_DESC protocol, and removes the dependency on the hardcoded structures. Use the protocol and pass information to further to the library init routine. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell

[edk2] [platforms PATCH 01/25] Marvell/Library: Introduce ArmadaSoCDescLib class

2018-06-08 Thread Marcin Wojtas
-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 78 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 ++ Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h

[edk2] [platforms PATCH 02/25] Marvell/Library: Introduce ArmadaBoardDescLib class

2018-06-08 Thread Marcin Wojtas
. Initially ArmadaBoardDescLib defines per-board UTMI PHYs information structure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Hua Jing --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 27 Silicon/Marvell

[edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-08 Thread Marcin Wojtas
ls can be found in the commit logs. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180608 I'm looking forward to review and any comments/remarks. Best regards, Marcin Marcin Wojtas (21): Marvell/Library: Int

[edk2] [platforms PATCH 03/25] Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL

2018-06-08 Thread Marcin Wojtas
From: jinghua This patch introduces protocol that exposes generic API to get board description. It uses ArmadaSoCDescLib library, which is implemented per SoC family to get the SoC level description for hardware module controller. Together with the information obtained from ArmadaBoardDescLib

[edk2] [platforms PATCH 05/25] Marvell/Armada7k8k: Enable board description driver compilation

2018-06-08 Thread Marcin Wojtas
From: jinghua This patch enables compilation of MvBoardDescDxe driver for Armada70x0-DB, Armada80x0-DB and Armada80x0McBin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: jinghua Reviewed-by: Kostya Porotchkin --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 1 +

[edk2] [platforms PATCH 04/25] Marvell/Drivers: MvBoardDescDxe: Introduce board description driver

2018-06-08 Thread Marcin Wojtas
to that there is a separation between obtaining the platform description and the drivers. A first example of the board description callback is information about UTMI controllers and type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: jinghua Signed-off-by: Marcin Wojtas --- Silicon/Marvell

[edk2] [platforms PATCH 1/1] Marvell/Drivers: Pp2Dxe: Fix cleaning of the BM pools

2018-06-07 Thread Marcin Wojtas
Manager during ExitBootServices. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 7 --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-05 Thread Marcin Wojtas
2018-06-05 13:59 GMT+02:00 Leif Lindholm : > On Mon, Jun 04, 2018 at 09:13:45PM +0200, Ard Biesheuvel wrote: >> On 4 June 2018 at 21:08, Leif Lindholm wrote: >> > On Mon, Jun 04, 2018 at 08:53:53PM +0200, Marcin Wojtas wrote: >> >> 2018-06-04 19:46 GMT+02:00 Leif

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
2018-06-04 19:38 GMT+02:00 Leif Lindholm : > On Mon, Jun 04, 2018 at 06:58:25PM +0200, Marcin Wojtas wrote: >> Ard, >> >> 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : >> > On 4 June 2018 at 18:41, Marcin Wojtas wrote: >> >> All required components

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
2018-06-04 19:46 GMT+02:00 Leif Lindholm : > On Mon, Jun 04, 2018 at 07:11:45PM +0200, Marcin Wojtas wrote: >> All required components are in place, so we can now >> add all necessary dependencies to build and use capsule support >> for Armada7k8k platforms. It is conditionall

[edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
PLATFORM_NAME= -D FIRMWARE_IMAGE_PATH= Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Signed-off-by: David Sniatkiwicz --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 66 ++ Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc| 41

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
Ard, 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : > On 4 June 2018 at 18:41, Marcin Wojtas wrote: >> All required components are in place, so we can now >> add all necessary dependencies to build and use capsule support >> for Armada7k8k platforms. It is conditionall

[edk2] [platforms PATCH v3 2/5] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-04 Thread Marcin Wojtas
PEI phase will allow to use more robust platform initialization, with new features like the capsule support. Wire up all dependencies for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell

[edk2] [platforms PATCH v3 0/5] Armada capsule support

2018-06-04 Thread Marcin Wojtas
ARM-TF PSCI 3/5 * New patch adding progress API usage in SPI flash protocol 4/5 * Add PerformFlashWriteWithProgress David Sniatkiwicz (1): Marvell/Armada7k8k: Introduce capsule FW update implementation Marcin Wojtas (4): Marvell/Armada70x0Db: Shift main FV from 0x0 address Marvell/Aram

[edk2] [platforms PATCH v3 4/5] Marvell/Armada7k8k: Introduce capsule FW update implementation

2018-06-04 Thread Marcin Wojtas
fig to specify binary description within SystemFirmwareFile Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Sniatkiwicz Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccess

[edk2] [platforms PATCH v3 1/5] Marvell/Armada70x0Db: Shift main FV from 0x0 address

2018-06-04 Thread Marcin Wojtas
-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf b/Platform/Marvell/Armada70x0Db

[edk2] [platforms PATCH v3 3/5] Marvell/Drivers: MvSpiFlashDxe: Add progress API

2018-06-04 Thread Marcin Wojtas
In order to support new API of the PlatformFlashAccessLib, which passes and optional Progress() function, introduce new callback for updating data in the SPI flash, that can utilize it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif

[edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
PLATFORM_NAME= -D ARM_TRUSTED_FIRMWARE_IMAGE_PREFIX= Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Signed-off-by: David Sniatkiwicz --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 66 ++ Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

Re: [edk2] [platforms PATCH v2 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
Hi Leif, 2018-06-04 12:08 GMT+02:00 Leif Lindholm : > > On Mon, Jun 04, 2018 at 07:29:35AM +0200, Marcin Wojtas wrote: > > All required components are in place, so we can now > > add all necessary dependencies to build and use capsule support > > for Armada7k8k platfo

[edk2] [platforms PATCH v2 1/5] Marvell/Armada70x0Db: Shift main FV from 0x0 address

2018-06-03 Thread Marcin Wojtas
-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf b/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf index befb107

[edk2] [platforms PATCH v2 3/5] Marvell/Drivers: MvSpiFlashDxe: Add progress API

2018-06-03 Thread Marcin Wojtas
In order to support new API of the PlatformFlashAccessLib, which passes and optional Progress() function, introduce new callback for updating data in the SPI flash, that can utilize it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell

[edk2] [platforms PATCH v2 2/5] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-03 Thread Marcin Wojtas
PEI phase will allow to use more robust platform initialization, with new features like the capsule support. Wire up all dependencies for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 15

[edk2] [platforms PATCH v2 4/5] Marvell/Armada7k8k: Introduce capsule FW update implementation

2018-06-03 Thread Marcin Wojtas
fig to specify binary description within SystemFirmwareFile Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: David Sniatkiwicz Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c |

[edk2] [platforms PATCH v2 0/5] Armada capsule support

2018-06-03 Thread Marcin Wojtas
3/5 * New patch adding progress API usage in SPI flash protocol 4/5 * Add PerformFlashWriteWithProgress David Sniatkiwicz (1): Marvell/Armada7k8k: Introduce capsule FW update implementation Marcin Wojtas (4): Marvell/Armada70x0Db: Shift main FV from 0x0 address Marvell/Aramda7k8k: Enable

[edk2] [platforms PATCH v2 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-03 Thread Marcin Wojtas
requirements and glueing all binaries (BLE, ARM-TF, BL33) externally, introduce additional .dsc and .fdf file solely for creating the capsule. Prior to this step 'flash-image.bin' binary must be placed under Platform/Marvell path. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin

Re: [edk2] [platforms PATCH 2/4] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-01 Thread Marcin Wojtas
2018-06-01 18:57 GMT+02:00 Ard Biesheuvel : > On 1 June 2018 at 18:43, Marcin Wojtas wrote: >> 2018-06-01 17:30 GMT+02:00 Ard Biesheuvel : >>> On 1 June 2018 at 16:32, Marcin Wojtas wrote: >>>> PEI phase will allow to use more robust platform initializatio

Re: [edk2] [platforms PATCH 2/4] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-01 Thread Marcin Wojtas
2018-06-01 17:30 GMT+02:00 Ard Biesheuvel : > On 1 June 2018 at 16:32, Marcin Wojtas wrote: >> PEI phase will allow to use more robust platform initialization, >> with new features like the capsule support. Wire up all >> dependencies for that purpose. >> >

Re: [edk2] [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation

2018-06-01 Thread Marcin Wojtas
2018-06-01 18:08 GMT+02:00 Ard Biesheuvel : > On 1 June 2018 at 18:02, Marcin Wojtas wrote: >> Hi Ard, >> >> 2018-06-01 17:32 GMT+02:00 Ard Biesheuvel : >>> On 1 June 2018 at 16:32, Marcin Wojtas wrote: >>>> From: David Sniatkiwicz >>>> >

Re: [edk2] [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation

2018-06-01 Thread Marcin Wojtas
Hi Ard, 2018-06-01 17:32 GMT+02:00 Ard Biesheuvel : > On 1 June 2018 at 16:32, Marcin Wojtas wrote: >> From: David Sniatkiwicz >> >> This patch adds necessary code that allows to update >> firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule, >>

[edk2] [platforms PATCH 2/4] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-01 Thread Marcin Wojtas
PEI phase will allow to use more robust platform initialization, with new features like the capsule support. Wire up all dependencies for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 15

[edk2] [platforms PATCH 4/4] Marvell/Armada7k8k: Wire up capsule support

2018-06-01 Thread Marcin Wojtas
requirements and glueing all binaries (BLE, ARM-TF, BL33) externally, introduce additional .dsc and .fdf file solely for creating the capsule. Prior to this step 'flash-image.bin' binary must be placed under Platform/Marvell path. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin

[edk2] [platforms PATCH 0/4] Armada capsule support

2018-06-01 Thread Marcin Wojtas
David Sniatkiwicz (1): Marvell/Armada7k8k: Introduce capsule FW update implementation Marcin Wojtas (3): Marvell/Armada70x0Db: Shift main FV from 0x0 address Marvell/Aramda7k8k: Enable PEI booting stage Marvell/Armada7k8k: Wire up capsule support Platform/Marvell/Armada70x0Db

[edk2] [platforms PATCH 1/4] Marvell/Armada70x0Db: Shift main FV from 0x0 address

2018-06-01 Thread Marcin Wojtas
-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf b/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf index befb107..69cb4cd 100644 --- a/Platform

[edk2] [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV

2018-06-01 Thread Marcin Wojtas
Until now the possible errors returned from processing boot firmware volume were not checked, which could cause misbehavior in further booting stages. Add relevant assert. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Signed-off-by: Jan Dabros

Re: [edk2] [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

2018-05-22 Thread Marcin Wojtas
2018-05-22 13:20 GMT+02:00 Leif Lindholm <leif.lindh...@linaro.org>: > On Mon, May 21, 2018 at 12:54:01PM +0200, Marcin Wojtas wrote: >> Hi Leif, >> >> >> 2018-05-09 18:49 GMT+02:00 Leif Lindholm <leif.lindh...@linaro.org>: >> >> > A couple of

Re: [edk2] [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

2018-05-21 Thread Marcin Wojtas
; > Yes, I would appreciate that. Thanks, Marcin > On Wed, May 09, 2018 at 03:51:11PM +0200, Marcin Wojtas wrote: > > From: Evan Wang <xsw...@marvell.com> > > > > PCIE clock direction (input/output) has implications on comphy settings. > > There are 2 PCIe clocks in

[edk2] [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

2018-05-09 Thread Marcin Wojtas
bution Agreement 1.1 Signed-off-by: Evan Wang <xsw...@marvell.com> Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 216 +++- Silicon/Marvell/Library/Com

[edk2] [platforms PATCH v2 0/4] Armada7k8k x4/x2 PCIE fix and misc improvements

2018-05-09 Thread Marcin Wojtas
ic sample at reset library Marcin Wojtas (2): Marvell/Armada7k8k: Remove Intel BDS dependency Marvell/Armada70x0Db: Use more generic output fd file name Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- Silicon/Marvell/Armada7k8k/Armada7k8

[edk2] [platforms PATCH v2 1/4] Marvell/Armada7k8k: Remove Intel BDS dependency

2018-05-09 Thread Marcin Wojtas
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile is no longer needed due to usage of generic BDS and its presence results in build error. Remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Arma

[edk2] [platforms PATCH v2 3/4] Marvell/Armada7k8k: Add basic sample at reset library

2018-05-09 Thread Marcin Wojtas
block. It will be needed for proper configuration during the PCIE SerDes training. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Igal Liberman <ig...@marvell.com> Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/

[edk2] [platforms PATCH v2 2/4] Marvell/Armada70x0Db: Use more generic output fd file name

2018-05-09 Thread Marcin Wojtas
Unification of output file name will ease handling build scripts (e.g. for CI purpose) when multiple board support will be added. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2

[edk2] [platforms PATCH 1/1] Marvell/Drivers: MvFvbDxe: Fix uninstallation of protocol

2018-04-17 Thread Marcin Wojtas
ion Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c inde

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

2018-04-17 Thread Marcin Wojtas
Hi Ard, 2018-04-17 7:32 GMT+02:00 Ard Biesheuvel <ard.biesheu...@linaro.org>: > On 17 April 2018 at 07:15, Marcin Wojtas <m...@semihalf.com> wrote: >> Hi Laszlo, >> >> 2018-04-16 21:41 GMT+02:00 Laszlo Ersek <ler...@redhat.com>: >>> On 04/1

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

2018-04-16 Thread Marcin Wojtas
Hi Laszlo, 2018-04-16 21:41 GMT+02:00 Laszlo Ersek <ler...@redhat.com>: > On 04/16/18 07:40, Ard Biesheuvel wrote: >> (+ Laszlo) >> >> On 16 April 2018 at 07:09, Marcin Wojtas <m...@semihalf.com> wrote: >>> Recent changes in the EDK2 mainline resulted

[edk2] [platforms PATCH 3/3] Marvell/Armada7k8k: Hook NvVarStoreFormattedLib into VariableRuntimeDxe

2018-04-16 Thread Marcin Wojtas
As MvFvbDxe driver is ready, we can now link NvVarStoreFormattedLib into VariableRuntimeDxe via NULL class resolution for all Armada7k8k platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Arma

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

2018-04-16 Thread Marcin Wojtas
Hi Ard, 2018-04-16 7:40 GMT+02:00 Ard Biesheuvel <ard.biesheu...@linaro.org>: > (+ Laszlo) > > On 16 April 2018 at 07:09, Marcin Wojtas <m...@semihalf.com> wrote: >> Recent changes in the EDK2 mainline resulted in breaking >> of compilation and booting of Armad

[edk2] [platforms PATCH 0/2] Armada7k8k adjustments to EDK2

2018-04-15 Thread Marcin Wojtas
/MarvellEmbeddedProcessors/edk2-open-platform/commits/adjustments-r20180416 I'm looking forward to your feedback. Best regards, Marcin Marcin Wojtas (2): Marvell/Drivers: MvFvbDxe: Adjust to new dependencies Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid Silicon/Marvell

[edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

2018-04-15 Thread Marcin Wojtas
explicit dependency to ArmPkg/Drivers/CpuDxe drivers in order to enable successful calling of gDS->SetMemorySpaceAttributes Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe

[edk2] [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid

2018-04-15 Thread Marcin Wojtas
der: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTim

[edk2] [platforms: PATCH 2/2] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

2018-02-16 Thread Marcin Wojtas
bution Agreement 1.1 Signed-off-by: Evan Wang <xsw...@marvell.com> Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 216 +++- Silicon/Marvell/Library/Com

[edk2] [platforms: PATCH 1/2] Marvell/Armada7k8k: Add basic sample at reset library

2018-02-16 Thread Marcin Wojtas
block. It will be needed for proper configuration during the PCIE SerDes training. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Igal Liberman <ig...@marvell.com> Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Silicon/Marvell/Armada7k8k/Librar

[edk2] [platforms: PATCH 0/2] Armada7k8k x4/x2 PCIE fix

2018-02-16 Thread Marcin Wojtas
Hi, This short (although not small) patchset adds a fix for the PCIE SerDes link problems when using x4/x2 end points. Because it relies on the boot time HW configuration of the reference clock, a new library is introduced for obtaining sample at reset configuration. Later it will be reused e.g.

Re: [edk2] [platforms: PATCH v3 0/7] Armada 7k/8k files reorganization

2017-12-08 Thread Marcin Wojtas
2017-12-08 16:33 GMT+01:00 Ard Biesheuvel <ard.biesheu...@linaro.org>: > On 8 December 2017 at 14:57, Marcin Wojtas <m...@semihalf.com> wrote: >> Hi, >> >> I submit v3 of the reorganization patchset. Answering the review, >> the Spi folder got reshuffled an

[edk2] [platforms: PATCH v3 7/7] Marvell/Drivers: Drop 'PciEmulation' naming

2017-12-08 Thread Marcin Wojtas
Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 4 +-- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +-- Silicon/M

[edk2] [platforms: PATCH v3 6/7] Marvell/Drivers: Modify location and rename the MvEeprom driver

2017-12-08 Thread Marcin Wojtas
: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 +- S

[edk2] [platforms: PATCH v3 5/7] Marvell/Drivers: Modify MvPhyDxe location

2017-12-08 Thread Marcin Wojtas
MvPhyDxe driver nesting into additional Phy directory under Silicon/Marvell/Drivers/Net is redundant. Align its level with MvMdioDxe and Pp2Dxe. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Platform/Marvell/Armada

[edk2] [platforms: PATCH v3 2/7] Marvell/Armada7k8k: Use '7k8k' prefix in the SoC drivers/libraries

2017-12-08 Thread Marcin Wojtas
As a part of files reorganization, switch to using '7k8k' in all SoC-specific driver/library code instead of '70x0'/'7040', so that to ensure consistent naming for entire SoC family. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.

[edk2] [platforms: PATCH v3 3/7] Marvell/Armada70x0Db: Rename fd file

2017-12-08 Thread Marcin Wojtas
Hitherto fd file name was pretty generic, so use one, which reflects actual board model. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas <m...@semihalf.com> --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- 1 file changed, 1 insertion(+), 1 de

<    1   2   3   4   5   6   7   8   >