Reviewed-by: Supreeth Venkatesh
Thanks,
Supreeth
-Original Message-
From: Eric Jin
Sent: Tuesday, April 2, 2019 10:17 AM
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch 1/1] SctPkg/UEFI: Remove redefined macro
Remove the macros which are already defined
Reviewed-by: Supreeth Venkatesh
and pushed as 6acb58dab3f5ca44c6ab5d85bcacbfb311a74631
Thanks,
Supreeth
-Original Message-
From: Eric Jin
Sent: Saturday, March 30, 2019 2:26 AM
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix inf
Thanks Kilian.
There was no issue. This patch was sent in error.
However, I will look into this feedback - "The GenBin.c should be extended by a
manual BIN2TXT translation."
Supreeth
From: Minnow Ware
Sent: Friday, March 29, 2019 9:29 AM
To: Jin, Eric ; Supreeth Venkatesh
; edk2-d
Thank you very much for the comments/feedback.
I will check this in after taking care of your feedback.
Supreeth
-Original Message-
From: Jin, Eric
Sent: Friday, March 29, 2019 4:04 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Jin, Eric
Subject: RE: [edk2-test][PATCH v1 30
Sorry. This was sent in error. I was testing my new Desktop with git send-email.
Please ignore.
Supreeth
-Original Message-
From: Jin, Eric
Sent: Friday, March 29, 2019 3:32 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Jin, Eric
Subject: RE: [edk2] [edk2-test][PATCH v2
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
uefi-sct/SctPkg/UEFI/UEFI.dec | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/SimpleFileSystemBBTest.inf | 29 +++
1 file changed, 17 insertions(+), 12
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../PxeBaseCode/BlackBoxTest/Dependency/Config/Config.inf | 2 ++
1 file changed, 2 insertions
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/LoadedImageBBTest.inf| 27 ++-
1 file changed, 14 insertions(+), 13
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Protocol/PciIo/BlackBoxTest/Dependency/Config/Config.inf | 3 ++-
.../PciRootBridgeIo/BlackBoxTest
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/SimpleTextInBBTest.inf | 27 -
.../BlackBoxTest
Fix compilation issues in definition file when compiled against edk2
stable tag edk2-stable201903 to avoid mutliple definitions of structures
and enumerations which conflict with MdePkg definitions.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/HIIConfigAccessBBTest.inf| 30
.../BlackBoxTest
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/DevicePathBBTest.inf | 32
.../BlackBoxTest
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/Dependency/CompressedFile1/CompressedFile1.inf | 2 ++
.../BlackBoxTest/Dependency
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/DebugSupportBBTest.inf | 30 +--
1 file changed, 14 insertions(+), 16
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/Dependency/InvalidImage1/InvalidImage1.inf | 2 ++
.../BlackBoxTest/Dependency
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../RIVL/Protocol/Udp6/Udp6/Udp6ENTSTest.inf | 31 +--
.../Udp6ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../RIVL/Protocol/Udp4/Udp4/Udp4ENTSTest.inf | 31 +--
.../Udp4ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../RIVL/Protocol/Tcp6/Tcp6/Tcp6ENTSTest.inf | 30 +--
.../Tcp6ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../RIVL/Protocol/Tcp4/Tcp4/Tcp4ENTSTest.inf | 31 +--
.../Tcp4ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../SimpleNetwork/SimpleNetworkENTSTest.inf | 31 +--
1 file changed, 15 insertions(+), 16
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../PXEBaseCode/PXEBaseCodeENTSTest.inf | 31 +--
1 file changed, 15 insertions(+), 16
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Protocol/Mtftp6/Mtftp6/Mtftp6ENTSTest.inf | 30 +-
.../Mtftp6ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Protocol/Mtftp4/Mtftp4/Mtftp4ENTSTest.inf | 31 +--
.../Mtftp4ServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../ManagedNetwork/MNP/MnpENTSTest.inf| 30 +--
.../ManagedNetwork/MNPSB
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../InternetProtocol6/Ip6/Ip6ENTSTest.inf | 32 -
.../Ip6Config/Ip6ConfigENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../InternetProtocol4/Ip4/Ip4ENTSTest.inf | 30 +-
.../Ip4Config/Ip4ConfigENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../RIVL/Protocol/Http/Http/HttpENTSTest.inf | 31 +--
.../HttpServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Protocol/Dhcp6/Dhcp6/Dhcp6ENTSTest.inf| 31 +--
.../Dhcp6/Dhcp6SB
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Protocol/Dhcp4/Dhcp4/Dhcp4ENTSTest.inf| 30 +--
.../Dhcp4/Dhcp4SB
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../Arp/ArpENTSTest.inf | 30 +--
.../ArpServiceBindingENTSTest.inf
Fix compilation issues in inf files when compiled against edk2 stable
tag edk2-stable201903.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.../BlackBoxTest/IhvDevicePathBBTest.inf | 25 +++---
.../IhvSimpleFileSystemBBTest.inf
1. Modify build scripts to ignore Ebc protocol tests temporarily.
2. Cosmetic changes to fix the text when sct is generated to correctly
identify "UEFI SCT" and "IHV SCT".
3. Remove SctGuildLib as it is unused.
Contributed-under: TianoCore Contribution Agreement 1.1
Sig
1. Ignore Ebc protocol test cases for AArch64 temporarily.
2. Fix AARCH64_CC_FLAGS to remove direct inclusion of MdePkg/Include.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 18 --
uefi-sct
ging logic of Trim and Getline functions used
in GenBin source code.
Cc: Supreeth Venkatesh
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Lokesh B V
---
Changes since v1:
* Adopted changes suggested by Supreeth.
* modified Copyright content
uefi-sct/SctPkg/Tools/Sou
Thanks for bringing this up.
Thanks,
Supreeth
From: Ashish Singhal
Sent: Wednesday, March 27, 2019 3:10 PM
To: edk2-devel@lists.01.org
Cc: Eric Jin ; Supreeth Venkatesh
Subject: Build SCT with edk2
Hello,
It seems building SCT is supported with edk2 UDK2017 and not something recent.
When I tried bu
Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Eric Jin
Sent: Sunday, March 10, 2019 9:43 PM
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch 1/1] uefi-sct/SctPkg:Implement iSCSI
DevicePathToText Test
It is the new checkpoint of iSCSI
)
$(LINKER) -o $(APPLICATION) $(BUILD_LFLAGS) $(OBJECTS)
-L$(MAKEROOT)/libs $(LIBS)
-$(OBJECTS): ../Include/Common/BuildVersion.h
+$(OBJECTS): $(MAKEROOT)/Include/Common/BuildVersion.h
Thanks,
Supreeth
From: Meenakshi Aggarwal
Sent: Tuesday, March 19, 2019 12:19 AM
To: Supreeth Venkatesh ; edk2-devel
hat
I can look into that first and let you know.
Thanks,
Supreeth
From: Meenakshi Aggarwal
Sent: Tuesday, March 19, 2019 12:19 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Dong Wei ; Jin, Eric ; Udit Kumar
; Varun Sethi
Subject: RE: [edk2-test] SctPkg compilation is failing
Hi Su
ased.
This patch corrects this by calculating size in bytes to be erased
using "EraseLengthGranularity" and "BlockSize".
or Something similar.
With that
Reviewed-by: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
>
LBA.
> The fix considers this case.
>
Please add a comment in the commit log to indicate there are whitepace
changes in the patch as part of the cleanup, not just the above case.
With that,
Acked-by: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
&
/GenBin
Also,
Build instructions need update, since UTWG decided to use edk2 stable releases
tag.
I will update the instructions today.
Thanks,
Supreeth
From: Meenakshi Aggarwal
Sent: Monday, March 18, 2019 1:42 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh
Subject: SctPkg compilation is failing
locatePages() in test.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
Minor comment about parenthesis to make multiple conditions priority
more readable. Please fix this. With that
Reviewed-by: Supreeth Venkatesh
>
On Thu, 2019-03-07 at 15:05 +0800, Eric Jin wrote:
> revisit BlueTooth checkpoint for UEFI2.7 spec update
> with LE support
> Change original test to classic/low energy checkpoints
> Add marco MAX_LENGTH for pre-defined string value
> (yes or no) in EfiCompliant.ini.
>
> C
22, 2019 2:54 AM
To: Jin, Eric ; Supreeth Venkatesh
Subject: RE: edk2-test: SctPkg: Build failure when compiled with latest edk2
Hi Eric,
Thanks for your reply. Will send a fix patch for this compilation issue.
Regards,
Thomas.
> -Original Message-
> From: Jin, Eric
> Sent
On Tue, 2018-11-27 at 13:57 +0800, Eric Jin wrote:
> The patch is applied to the IHV part.
>
> Fix bug - set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit
> in Enable parameter to make sure Multicast is enabled.
> Add one checkpoint when MCastFilterCount is zero
>
> C
ICAST bit
> in Enable parameter to make sure Multicast is enabled.
> Add one checkpoint when MCastFilterCount is zero
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
Acked-by: Supreeth Venkatesh
> ---
> .../EFI/Pr
On Tue, 2018-11-27 at 13:30 +0800, Eric Jin wrote:
> Fix all GUID values defined in invalid format.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
Reviewed-by: Supreeth Venkatesh
> ---
> .../IHV/P
y, January 15, 2019 1:23 AM
To: Sakar Arora ; Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; Jin, Eric
Subject: RE: [edk2][edk2-test][RFC] Integrating SBBR tests into SCT - A design
proposal
Hi Sakar,
Thank for the clarification.
Now, I understand that the SBBR wants to add/modify in existi
Lets wait for additional comments from Eric.
Thanks,
Supreeth
-Original Message-
From: Sakar Arora
Sent: Monday, December 31, 2018 12:50 AM
To: edk2-devel@lists.01.org; eric@intel.com; Supreeth Venkatesh
Cc: Prasanth Pulla
Subject: [edk2][edk2-test][RFC] Integrating SBBR test
articularly useful.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Supreeth Venkatesh
> ---
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalon
> eMmCoreEntryPoint.c | 2 --
> 1 file changed, 2 deletions
On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote:
> PE/COFF section names are ASCII strings so use %a not %s.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Supreeth Venkatesh
> ---
> Stand
On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote:
> StandaloneMmCoreEntryPoint calls SerialPortInitialize() explicitly,
> so add SerialPortLib to its list of LibraryClasses.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Review
t; Signed-off-by: Ard Biesheuvel
Reviewed-by: Supreeth Venkatesh
> ---
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> | 2 +-
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> | 6 +++---
> StandaloneMmPkg/Drivers/StandaloneM
On Fri, 2018-12-14 at 20:57 +0100, Laszlo Ersek wrote:
> On 12/14/18 18:12, Supreeth Venkatesh wrote:
> > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote:
> > > On 12/14/18 11:59, Leif Lindholm wrote:
> > > > Hmm, this gets me thinking...
> > > >
On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote:
> On 12/14/18 11:59, Leif Lindholm wrote:
> > Hmm, this gets me thinking...
> >
> > We were discussing before about doing a line ending conversion in
> > edk2, and let the git gools provide native line endings (as
> > designed).
> >
> > Is
No functionality change.
Change line endings to CR LF (windows style) and avoid mixing unix and
windows line endings for all source files with the exception for shell
script files.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
.gitignore
ng standards specification.
> Change the following macro from variable style
> HwErrRecVariableNameLength
> HwErrRecVariableNamePrefixLength
> HwErrRecVariableNameIndexLength
> to macro style.
> HW_ERR_REC_VARIABLE_NAME_LEN
> HW_ERR_REC_VARIABLE_NAME_PREFIX_LEN
> HW_ERR_REC_VA
t; hash of content, the signer's certificate was not
> found in RevokedDb, and was found in AllowedDb.
> b)Signer is found in both AllowedDb and RevokedDb,
> the signing was allowed by reference to TimeStampDb,
> and no hash matching content hash was found in RevokedDb.
>
> Cc: Sup
r 10, 2018 11:37 AM
To: Supreeth Venkatesh ; Jin, Eric
; Leif Lindholm ; Kinney, Michael
D
Cc: edk2-devel@lists.01.org; Dong Wei
Subject: RE: SCT bugzilla topic?
Supreeth,
I have created the "EDK2 Test" product with the "UEFI-SCT" component.
Please review and let me kn
if Lindholm ; Kinney, Michael D
Cc: Supreeth Venkatesh ; edk2-devel@lists.01.org;
Dong Wei
Subject: RE: SCT bugzilla topic?
Hi Leif,
We had better use "UEFI SCT" as the component.
Other SCTs or test suites may be arranged in the EDK2-Test in future as the
intention of EDK2-Test if my un
Message-
From: Leif Lindholm
Sent: Monday, December 3, 2018 8:47 AM
To: edk2-devel@lists.01.org
Cc: Eric Jin ; Supreeth Venkatesh
; Michael D Kinney
Subject: SCT bugzilla topic?
Hi Eric, Supreeth, Mike,
I was looking to raise a feature request on UEFI SCT and didn't spot such a
product
Commit message to mention what this patch is imlementing.
In addition, there is cleanup to remove #if 0 block below.
Both of this should be in commit message.
On Thu, 2018-11-29 at 16:46 +0800, Eric Jin wrote:
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreeme
at 16:42 +0800, Eric Jin wrote:
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
> ---
> .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c |2 +
> .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h |7 +
usable with this version of EFI.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lokesh B V
> ---
> uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h |
> 3 +++
> 1 file changed, 3 insertions(+)
>
On Wed, 2018-11-28 at 15:00 +0530, Lokesh B V wrote:
> As the GenBin tool is necessary for SCT build, it is appropriate to
> support it's build in the SCT build procedure.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lo
Changed to "consider the presence of carriage return(\r)"
> results
> in incorrect format error.
>
> Fixed this issue by changing logic of Trim and Getline functions used
> in GenBin source code.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribu
On Wed, 2018-11-28 at 14:59 +0530, Lokesh B V wrote:
> Fix all GUID values that are defined with a invalid GUID
> value format.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lokesh B V
Reviewed-by: Supreeth
On Wed, 2018-11-28 at 15:00 +0530, Lokesh B V wrote:
> Ignore *.o and *.d untracked files.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lokesh B V
Reviewed-by: Supreeth Venkatesh
Pushed.
> ---
> .gitignore | 1 +
On Wed, 2018-11-28 at 20:35 +, Supreeth Venkatesh wrote:
On Wed, 2018-11-28 at 14:59 +0530, Lokesh B V wrote:
> Fix all GUID values that are defined with a invalid GUID
> value format.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1
ider
> the presence
> of carraige return(\r) in line feed. So this results in incorrect
Please fix the commit message with "carriage return" (same comment as
given by Philippe)
> format error.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1
As the GenBin tool is necessary for SCT build, it is appropriate to
> support it's build in the SCT build procedure.
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lokesh B V
> ---
> .gitignore | 1 +
Why did
Lokesh,
I had applied the GenBin tool rebuild patch before this.
I will check again on my side but please recheck on your side.
Thanks,
Supreeth
-Original Message-
From: Lokesh Belathur Veerappa
Sent: Tuesday, November 27, 2018 2:04 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh ;
eric@intel.com
Cc: Lokesh Belathur Veerappa
Subject: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection
by GenBin tool
Some windows editors uses "\r\n" for line feed. While processing uef
Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Lokesh B V
Sent: Tuesday, November 20, 2018 12:51 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh ;
eric@intel.com
Cc: Lokesh Belathur Veerappa
Subject: [edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build
Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Lokesh B V
Sent: Tuesday, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh ;
eric@intel.com
Cc: Lokesh Belathur Veerappa
Subject: [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error
Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Eric Jin
Sent: Tuesday, November 20, 2018 8:13 PM
To: edk2-devel@lists.01.org
Cc: Supreeth Venkatesh
Subject: [edk2-test][Patch] uefi-sct/SctPkg:Remove old unused files in
EfiCompliant test
Cc: Supreeth Venkatesh
Contributed
Thanks Lokesh for the patch.
Has this been compiled and sanity tested against latest edk2?
Let me know SHA of edk2 tested, so that I can test it against that SHA and push
it.
If so, Reviewed-by: Supreeth Venkatesh
-Original Message-
From: Lokesh B V
Sent: Tuesday, November 20, 2018 12
Reviewed-by: Supreeth Venkatesh
Thanks for the patch.
One minor comment inline, which can be in its own patch later.
On Mon, 2018-11-12 at 16:37 +0800, Eric Jin wrote:
> Correct BlueTooth Io Protocol Guid and
> BlueTooth Config Protocol Guid with the values
> defined in the UEFI spe
On Tue, 2018-11-06 at 17:46 +, Leif Lindholm wrote:
> On Tue, Nov 06, 2018 at 02:17:41PM +0530, Sakar Arora wrote:
> > From: John Powell
> >
> > Tests SBBR requirements 3.4.1 and 3.4.4.
It would be better if we add comments on how SBBR requirements 3.4.1
and 3.4.4 relate to the UEFI
nt KeyData.KeyState values are exposed."
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
> ---
> .../Protocol/SimpleTextInputEx/BlackBoxTest/Guid.c | 7 +-
> .../Protocol/SimpleTextInpu
Thanks.
Reviewed-by: Supreeth Venkatesh
On Fri, 2018-11-02 at 03:08 -0500, Eric Jin wrote:
> The LUN is an 8 byte array that is displayed in hexadecimal
> format with byte 0 first (i.e., on the left) and byte 7 last
> (i.e, on the right).
>
> Cc: Supreeth Venkatesh
>
oke data
> available. Current KeyData.KeyState values are exposed."
>
> Cc: Supreeth Venkatesh
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Jin
> ---
> .../Protocol/SimpleTextInputEx/BlackBoxTest/Guid.c | 7 +-
>
On Wed, 2018-11-07 at 06:45 +, Jin, Eric wrote:
> Hi Supreeth,
>
> Thank for comment. The magic num 7 will be removed in the v2 patch.
Thanks.
>
> Best Regards
> Eric
>
> -Original Message-
> From: Supreeth Venkatesh
> Sent: Monday, October 15,
On Tue, 2018-11-06 at 06:45 -0600, Leif Lindholm wrote:
> Hi Sakar,
>
> Glad to see you guys already contributing to the newly(ish) open SCT.
Indeed.
>
> I do have some comments on this patch - starting with: please cc the
> maintainers. I have added Eric/Supreeth to this reply.
We (me and Eric)
Reviewed-by: Supreeth Venkatesh
There are some unintentional indentation changes in "switch" statement.
Please take care of that before (if intentional, ok as well) commit.
On Thu, 2018-11-01 at 10:52 +0800, Eric Jin wrote:
> Add definition of HwErrRecVariableNam
guity in my eye.
How about to document the clear comments in the key process? It is more help
for reading by someone new and sustaining.
Best Regards
Eric
-Original Message-
From: Supreeth Venkatesh
Sent: Thursday, November 1, 2018 12:24 AM
To: Jin, Eric ; edk2-devel@lists.01.org
Cc: Wu,
ocumentation to get going.
>
>
> Best Regards
> Eric
>
> -Original Message-
> From: Supreeth Venkatesh
> Sent: Wednesday, October 31, 2018 1:00 AM
> To: Jin, Eric ; edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; supreeth.venkat...@arm.com
> Subject: Re: [edk2-test
Reviewed-by: Supreeth Venkatesh
If the below magic number comments(inline) are fixed before commit.
On Tue, 2018-10-30 at 16:38 +0800, Eric Jin wrote:
> Make the HwErrRecVariableName as valid the string.
> Ensure the HwErrRecVariable could be deleted before the test exit.
>
>
FYI
On 10/15/2018 03:08 AM, Supreeth Venkatesh wrote:
Commit Message less than 80 cols please.
On 10/13/2018 04:51 PM, Eric Jin wrote:
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution
Reviewed-by: Supreeth Venkatesh
On 10/14/2018 02:58 AM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/Library/SctLib/Print.c | 6 --
1 file changed, 4 insertions(+), 2
are mistakenly erased.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../EraseBlockBBTestConformance.c | 25 +-
.../BlackBoxTest/EraseBlockBBTestFunction.c | 600 --
.../BlackBoxTest
Commit Message less than 80 cols please.
On 10/13/2018 04:51 PM, Eric Jin wrote:
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
FYI
On 10/15/2018 02:33 AM, Supreeth Venkatesh wrote:
Please use a commit message less than 80 Cols.
On 10/13/2018 04:42 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
On 10/13/2018 05:21 PM, Eric Jin wrote:
UEFI Spec clarify the Toggle state
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../SimpleTextInputEx/BlackBoxTest/Guid.c | 7 +-
.../SimpleTextInputEx/BlackBoxTest
On 10/14/2018 03:25 AM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../DevicePathToTextBBTestCoverage.c | 43 ++-
.../BlackBoxTest/DevicePathToTextBBTestMain.c | 26
Reviewed-by: Supreeth Venkatesh
On 10/13/2018 04:30 PM, Eric Jin wrote:
The Results output from ExtractConfigFunction() may be different during two
calls in some case.
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
Please use a commit message less than 80 Cols.
On 10/13/2018 04:42 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
...rTaskPriorityServicesBBTestCreateEventEx.c | 26
On 10/13/2018 05:33 PM, Eric Jin wrote:
Cc: Supreeth Venkatesh
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Jin
---
.../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
1 - 100 of 357 matches
Mail list logo
