Re: [edk2] [PATCH] BaseTools: Parse decimal format INF_VERSION incorrect

2018-07-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, July 25, 2018 11:41 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: Parse

Re: [edk2] [PATCH] BaseTools/Ecc: Add some new checkpoints

2018-07-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, July 23, 2018 2:03 PM To: edk2-devel@lists.01.org Cc: Chen, Hesheng Subject: [edk2] [PATCH] BaseTools/Ecc: Add

Re: [edk2] [PATCH] BaseTools: Fix build report for *P and *M flag incorrectly

2018-07-24 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, July 23, 2018 4:49 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: Fix build

Re: [edk2] [PATCH v1 1/1] BaseTools: AutoGen - change class variable to funciton variable

2018-07-24 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, July 20, 2018 1:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: AutoGen - change class variable to funciton variable

Re: [edk2] [PATCH] BaseTools/GenC: Update Standalone MM EPs for StandaloneMmPkg.

2018-07-23 Thread Zhu, Yonghong
We already have a similar patch created by supreeth.venkat...@arm.com, and pushed. Best Regards, Zhu Yonghong -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Monday, July 23, 2018 7:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong

Re: [edk2] [Patch] BaseTools Script: Add the script to generate Structure PCD setting

2018-07-23 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, July 17, 2018 11:42 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools Script: Add the script

Re: [edk2] [Patch V3] BaseTools: enable FixedAtBuild (VOID*) PCD use in the [DEPEX] section

2018-07-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, July 17, 2018 10:29 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch V3] BaseTools: enable

Re: [edk2] [PATCH 07/14] BaseTools: Use absolute import in BPDG

2018-07-11 Thread Zhu, Yonghong
Hi Gary, I got below error: Traceback (most recent call last): File "C:\TCWork\Edk2\BaseTools\Source\Python\BPDG\BPDG.py", line 34, in from . import StringTable as st ValueError: Attempted relative import in non-package Best Regards, Zhu Yonghong -Original Message-

Re: [edk2] [Patch] BaseTools: Clean up source files

2018-07-08 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, July 5, 2018 9:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Clean up source files 1. Do not use tab characters 2. No trailing white space

Re: [edk2] [Patch V2] BaseTools: enable FixedAtBuild (VOID*) PCD use in the [DEPEX] section

2018-07-05 Thread Zhu, Yonghong
In GetGuidValue() function it already have this logic to handle it. Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, July 06, 2018 9:55 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch V2] BaseTools: enable FixedAtBuild (VOID*) PCD

Re: [edk2] [PATCH 3/3] BaseTools: Read the env variable PYTHON_DEFAULT

2018-07-05 Thread Zhu, Yonghong
Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, June 27, 2018 6:08 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH 3/3] BaseTools: Read the env variable PYTHON_DEFAULT When PYTHON_DEFAULT is set as "py

Re: [edk2] [Patch] BaseTools: Clean up source files

2018-07-05 Thread Zhu, Yonghong
The copyright year of the changed files should be updated. Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, July 5, 2018 9:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Clean up source files 1. Do not use tab characters

Re: [edk2] [PATCH v1 1/1] BaseTools: AutoGen - move constructor out of loop

2018-06-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, June 28, 2018 12:11 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: AutoGen - move constructor out of loop Create the 2

Re: [edk2] [PATCH v1 1/1] BaseTools: AutoGen - clean up access

2018-06-29 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, June 28, 2018 5:28 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: AutoGen - clean up access 1) add a property so others can

Re: [edk2] [Patch V2] BaseTools: Fix parsing multiple nest !include issue

2018-06-28 Thread Zhu, Yonghong
When I commit this patch, I will change it to use TAB_INCLUDE. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, June 29, 2018 4:48 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: RE: [edk2] [Patch V2

Re: [edk2] [PATCH v1 1/1] BaseTools: Move variable out of Global

2018-06-26 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, June 27, 2018 8:13 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: Move variable out of Global Move single use list from

Re: [edk2] [PATCH v4 00/20] BaseTools: One step toward python3

2018-06-25 Thread Zhu, Yonghong
Hi Gary, The V4 patches are good to me. I will push this series in recent days if no other comment from community. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Monday, June 25, 2018 6:31 PM To: edk2-devel@lists

Re: [edk2] [PATCH v1 1/1] BaseTools: AutoGen - Remove unused variables.

2018-06-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, June 26, 2018 7:18 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1] BaseTools: AutoGen - Remove unused variables. There are 2 variables

Re: [edk2] [Patch] BaseTools: Fix two drivers include the same file issue

2018-06-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, June 25, 2018 8:48 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: [edk2] [Patch

Re: [edk2] [PATCH] BaseTools/PackageDocumentTools: Correct INI parse condition check

2018-06-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, June 26, 2018 8:57 AM To: edk2-devel@lists.01.org Cc: Chen, Pai-chingX ; c...@ml01.01.org Subject: [edk2] [PATCH

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-24 Thread Zhu, Yonghong
You're correct, it is Patch 13 cause the 'long' type issue. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Monday, June 25, 2018 11:35 AM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
No. I tried to only patch 1 to 15, it still report this failure. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 5:48 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
Any comment on which patch may cause this issue ? I revert all the 20 patches, OVMF could build PASS. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Friday, June 22, 2018 5:22 PM To: 'Gary Lin' Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu, Yonghong

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
= gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorag eVariableBase + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 5:13 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
Hi Gary, My test env is Windows. I applied Patch 16, and seems this patch only for Linux. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 4:46 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re

Re: [edk2] unknown section type handling in ElfConvert

2018-06-22 Thread Zhu, Yonghong
Hi Michael, We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section. Best Regards, Zhu Yonghong -Original Message- From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Friday, June 08, 2018 11:46 PM To: edk2-devel-01 Cc: Zhu

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-21 Thread Zhu, Yonghong
-package Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 10:04 AM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions On Thu, Jun 21, 2018

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-21 Thread Zhu, Yonghong
Hi Gary, Python 2.7 doesn't have the module builtins, if we apply this patch now, it will cause build failure on Python 2.7. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Thursday, June 21, 2018 12:44 PM To: edk2-devel@lists.01.org Cc: Zhu

Re: [edk2] [PATCH v2 00/20] BaseTools: One step toward python3

2018-06-20 Thread Zhu, Yonghong
Hi Paolo and Gary, The patches are good and helpful. But it is out of date, so could you help to recreate the patches ? Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paolo Bonzini Sent: Wednesday, June 20, 2018 2

Re: [edk2] [Patch] FDF Spec: clean up the and usage in spec

2018-06-19 Thread Zhu, Yonghong
Yes, I will separate it into two. Best Regards, Zhu Yonghong -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, June 19, 2018 8:33 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Kinney, Michael D ; Shaw, Kevin W ; Gao, Liming Subject: Re

Re: [edk2] [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.

2018-06-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Sunday, June 17, 2018 12:16 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH] BaseTools/WorkspaceCommon: Import used

Re: [edk2] [Patch] FDF spec: Add the syntax to describe structure pcd usage

2018-06-14 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, June 05, 2018 3:33 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] FDF spec: Add the syntax to describe structure pcd usage Contributed-under: TianoCore

Re: [edk2] [Patch] BaseTools Conf: Update tools_def and build_rule to remove IPF setting

2018-06-14 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Wednesday, June 13, 2018 2:47 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools Conf: Update tools_def and build_rule to remove IPF setting Contributed-under

Re: [edk2] [Patch] BaseTools: Fix one bug of nest !include parser

2018-06-12 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, June 12, 2018 9:01 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: [edk2] [Patch

Re: [edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

2018-06-12 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, May 18, 2018 8:07 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

Re: [edk2] [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks

2018-06-11 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, June 09, 2018 2:15 PM To: edk2-devel@lists.01.org Cc: Sun, Yanyan ; Zhu, Yonghong ; Gao, Liming ; Kinney, Michael D Subject: [Patch 0/5] BaseTools/BinToPcd: Multiple

Re: [edk2] [PATCH] BaseTools: Remove dsc nested include checking.

2018-06-11 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com] Sent: Wednesday, May 09, 2018 5:03 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Lin, Derek (HPS UEFI Dev) Subject: [PATCH] BaseTools: Remove dsc

Re: [edk2] [Patch] BaseTools: Sort PCD by token space first then by PcdCName

2018-06-05 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, June 05, 2018 1:31 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: [edk2] [Patch

Re: [edk2] [Patch] FDF spec: Correct the example with SET statement in [FD] section

2018-06-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, June 04, 2018 5:22 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zhu, Yonghong Subject: [Patch] FDF spec: Correct the example with SET statement in [FD] section Region base

Re: [edk2] [Patch 1/5] Build Spec: Add !error statement support

2018-05-31 Thread Zhu, Yonghong
Hi Laszlo, I didn't add Bugzilla info for !error bug. When I commit this patch, I will add this Bugzilla info. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, May 31, 2018 6:27 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org

Re: [edk2] [Patch] BaseTools/GenFds: Remove redundant GetRealFileLine call

2018-05-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, May 25, 2018 7:59 AM To: edk2-devel@lists.01.org Cc: zurc...@ml01.01.org; Z

Re: [edk2] [PATCH v1 1/1] BaseTools: Add missing content to EOT tool.

2018-05-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, May 24, 2018 10:18 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v2 1/1] BaseTools: loop to retry remove when it fails.

2018-05-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, May 10, 2018 11:15 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com&

Re: [edk2] [PATCH] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Zhu, Yonghong
The patch looks good. Please send V2 to remove the space change. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Saturday, May 19, 2018 5:28 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.

Re: [edk2] [Patch] BaseTools: Library PCD type will inherit from the driver

2018-05-21 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Sunday, May 20, 2018 8:56 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@

Re: [edk2] [Patch] BaseTools: Report more clear error message when PCD type mismatch

2018-05-21 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Sunday, May 20, 2018 8:58 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@

Re: [edk2] [Patch] BaseTools: Fix bug PCD type in component is not same with Pcd section

2018-05-21 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Sunday, May 20, 2018 8:55 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@

Re: [edk2] [Patch] BaseTools: Separate HOST and PREFIX env for GCC tool chain

2018-05-20 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, April 25, 2018 6:12 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-16 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com] Sent: Wednesday, May 09, 2018 5:03 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Lin

Re: [edk2] [PATCH] BaseTools: Fix python error with --genfds-multi-thread.

2018-05-10 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com] Sent: Wednesday, May 09, 2018 5:03 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Lin

Re: [edk2] [Patch] BaseTools: Fix generating array's size is incorrect in AutoGen.c

2018-05-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, May 09, 2018 3:41 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

2018-05-09 Thread Zhu, Yonghong
Hi Derek, Please refer below link to add Contributed-under and Signed-off-by info. We can use BaseTools\Scripts\PatchCheck.py to check the patch format. Thanks. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format Best Regards, Zhu Yonghong -Original Message

Re: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

2018-05-08 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, May 09, 2018 12:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v3 1/1] BaseTools: Ecc - add dict for config file to internal translation

2018-05-04 Thread Zhu, Yonghong
It looks good to me. I will strip the trailing space when push this patch. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, May 05, 2018 6:43 AM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org C

Re: [edk2] [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile

2018-05-03 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, May 04, 2018 1:28 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com> Subject: [Patch] BaseTools: Retrieve /U and

Re: [edk2] [PATCH v1 00/42] BaseTools: refactoring patches

2018-05-03 Thread Zhu, Yonghong
This series patch are good to me. Only one comment for Patch 34, it should use DataType.PACK_CODE_BY_SIZE but not directly use PACK_CODE_BY_SIZE because it use " import Common.DataType as DataType" in the header. I will correct it when push this patch. Reviewed-by: Yonghong Zhu

Re: [edk2] [PATCH v2 19/27] BaseTools: Replace Binary File type strings with predefined constant

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 12:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subjec

Re: [edk2] [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 22/27] BaseTools: remove redundant if comparison

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 14/27] BaseTools: Define and use a set for common list

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v3 16/27] BaseTools: Replace EDK Component strings with predefined constant

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 10:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v2 11/27] BaseTools: Workspace/MetaFileParser - refactor dicts

2018-05-02 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 10:04 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH] BaseTools: Fix regression bug by 3378782691af

2018-05-01 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Saturday, April 28, 2018 9:00 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [PATCH v2 18/27] BaseTools: Replace PCD type strings with predefined constant

2018-04-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 12:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v2 21/27] BaseTools: replace string with predefined constant

2018-04-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 12:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v2 13/27] BaseTools: replace string constants used for module types

2018-04-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 27, 2018 12:58 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH] BaseTools: Fix regression issue by 1eb72acddd61

2018-04-26 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, April 27, 2018 12:29 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743

2018-04-26 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, April 25, 2018 11:09 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [PATCH v1 20/27] BaseTools: remove duplicate variable

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 09/27] BaseTools: AutoGen - remove unused variables.

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 27/27] BaseTools: CommonClass - remove unused classes

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 03/27] BaseTools: Share RegEx between files

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 24/27] BaseTools: GenFds - simplify testing for Hex number

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 10/27] BaseTools: Remove extra .keys()

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Sub

Re: [edk2] [PATCH v1 02/27] BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple compiling

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 07/27] BaseTools: Workspace - refactor GetStructurePcdInfo

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 12/27] BaseTools: remove dict from DscBuildData

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 08/27] BaseTools: AutoGen - remove dictionary populated, but never accessed

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 05/27] BaseTools: Autogen - replace string constants with those from DataType

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subjec

Re: [edk2] [PATCH v1 06/27] BaseTools: simplify if call

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 04/27] BaseTools: Workspace - refactor RegEx to minimize multiple compiling

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 01/27] BaseTools: Misc - refactor RegEx to minimize multiple compiling

2018-04-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Sub

Re: [edk2] [PATCH v1 21/27] BaseTools: replace string with predefined constant

2018-04-25 Thread Zhu, Yonghong
Should use DT.PLATFORM_COMPONENT_TYPE_LIBRARY_CLASS, because current in the file header it use "import Common.DataType as DT". Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Limi

Re: [edk2] [PATCH v1 18/27] BaseTools: Replace PCD type strings with predefined constant

2018-04-25 Thread Zhu, Yonghong
GenFdsGlobalVariable.py: should use DataType.TAB_PCDS_FIXED_AT_BUILD format, because it use import Common.DataType as DataType in file header. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao

Re: [edk2] [PATCH v1 13/27] BaseTools: replace string constants used for module types

2018-04-24 Thread Zhu, Yonghong
Hi Jaben, two comments on this patch, please check it. thanks. 1. Check.py: it should use DT.SUP_MODULE_BASE 2. DataSection.py: need import DataType file, and update copyright year. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM

Re: [edk2] [PATCH v1 16/27] BaseTools: Replace EDK Component strings with predefined constant

2018-04-24 Thread Zhu, Yonghong
? besides, whether we need cover the other report type, not only the "LIBRARY" ? Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yo

Re: [edk2] [PATCH v1 19/27] BaseTools: Replace Binary File type strings with predefined constant

2018-04-24 Thread Zhu, Yonghong
have any suggestions on the naming conventions ? Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [PA

Re: [edk2] [PATCH v2 2/2] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants.

2018-04-22 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 17, 2018 10:45 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v2 1/1] BaseTools: remove EdkIIWorkspace as its not used.

2018-04-22 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 19, 2018 11:13 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v2 1/1] BaseTools: remove PlatformClass as it's not used

2018-04-22 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 19, 2018 11:13 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v1 1/1] BaseTools: remove EdkIIWorkspace as its not used.

2018-04-19 Thread Zhu, Yonghong
Hi Jaben, Forgot to update the Makefile. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 19, 2018 6:13 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [

Re: [edk2] [PATCH v1 1/1] BaseTools: remove PlatformClass as it's not used

2018-04-19 Thread Zhu, Yonghong
The makefile also need update. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 19, 2018 6:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [PATCH v1 1/1] BaseT

Re: [edk2] [PATCH] BaseTools: Support DSC component !include PCD items

2018-04-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, April 18, 2018 4:56 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [PATCH v2 1/3] BaseTools: refactor and remove more keys() usage

2018-04-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, April 18, 2018 10:22 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v1 1/1] BaseTools: Eot - Remove FvImage file

2018-04-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 17, 2018 1:48 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v1 1/3] BaseTools: refactor and remove more keys() usage

2018-04-18 Thread Zhu, Yonghong
] +for ((PcdName,TokenSpaceGuid),PcdSetting) in PcdValueDict.iteritems(): Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 10, 2018 10:20 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@

Re: [edk2] [PATCH v3 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

2018-04-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 17, 2018 10:40 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v2 2/3] BaseTools: use predefined constants instead of local strings

2018-04-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Monday, April 16, 2018 9:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject

Re: [edk2] [PATCH v1 1/4] BaseTools: remove duplicate function name

2018-04-18 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

<    1   2   3   4   5   >