Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-11 Thread Ming Huang
bugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c >>>>> >>>>> Does your implementation generate the same CRC16 as above one? >>>> >>>> It is not the same with above one. >>>> >>>>> >>>>>> -Origin

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-11 Thread Gao, Liming
t; Michael D > Cc: huangmin...@huawei.com; Dong, Eric ; > zhangjinso...@huawei.com; wanghuiqi...@huawei.com; > wai...@126.com; Zeng, Star ; huangda...@hisilicon.com > Subject: Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API > CalculateCrc16() > > > > On

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-02 Thread Ming Huang
;> Gao, Liming >> Cc: huangmin...@huawei.com; Dong, Eric ; >> zhangjinso...@huawei.com; wanghuiqi...@huawei.com; >> wai...@126.com; Zeng, Star ; huangda...@hisilicon.com >> Subject: Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API >> CalculateCrc16() >&g

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-02 Thread Ming Huang
;> ; Gao, Liming >>>> Cc: huangmin...@huawei.com; Dong, Eric ; >>>> zhangjinso...@huawei.com; Zeng, Star ; >>>> wai...@126.com; wanghuiqi...@huawei.com; huangda...@hisilicon.com >>>> Subject: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new A

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-01 Thread Gao, Liming
.@lists.linaro.org; edk2-devel@lists.01.org; Kinney, Michael > >> D > >> ; Gao, Liming > >> Cc: huangmin...@huawei.com; Dong, Eric ; > >> zhangjinso...@huawei.com; Zeng, Star ; > >> wai...@126.com; wanghuiqi...@huawei.com; huangda...@hisilicon.com

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-01 Thread Ard Biesheuvel
gt;> Cc: huangmin...@huawei.com; Dong, Eric ; > >> zhangjinso...@huawei.com; Zeng, Star ; > >> wai...@126.com; wanghuiqi...@huawei.com; huangda...@hisilicon.com > >> Subject: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API > >> CalculateCrc16()

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-01-31 Thread Ming Huang
t;> zhangjinso...@huawei.com; Zeng, Star ; >> wai...@126.com; wanghuiqi...@huawei.com; huangda...@hisilicon.com >> Subject: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API >> CalculateCrc16() >> >> CalculateCrc16() bases on the initialized mCrcTable. When Calculat

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-01-31 Thread Ni, Ray
2019 2:02 PM > To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Kinney, Michael D > ; Gao, Liming > Cc: huangmin...@huawei.com; Dong, Eric ; > zhangjinso...@huawei.com; Zeng, Star ; > wai...@126.com; wanghuiqi...@huawei.com; huangda...@hisilicon.com > Subject: [edk2]

[edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-01-31 Thread Ming Huang
CalculateCrc16() bases on the initialized mCrcTable. When CalculateCrc16() is used, mCrcTable16 will take 512Bytes size in the image. When CalculateCrc16() is not used, mCrcTable16 will not be built in the image, and no size impact. Contributed-under: TianoCore Contribution Agreement 1.1