Re: [edk2] [PATCH] BaseTools: Fix GenFds error doesn't break build.

Hi Bob, Please try attached patch. Based on today's master. Thanks, Derek -Original Message- From: Feng, Bob C [mailto:bob.c.f...@intel.com] Sent: Wednesday, December 19, 2018 8:25 AM To: Lin, Derek (HPS SW) ; edk2-devel@lists.01.org; Zhao, ZhiqiangX Subject: RE: [PATCH] BaseTools:

Re: [edk2] [PATCH] BaseTools: Fix GenFds error doesn't break build.

Thanks. This patch works. Reviewed-by: Bob Feng Thanks, Bob -Original Message- From: Lin, Derek (HPS SW) [mailto:derek.l...@hpe.com] Sent: Wednesday, December 19, 2018 9:55 AM To: Feng, Bob C ; edk2-devel@lists.01.org; Zhao, ZhiqiangX Subject: RE: [PATCH] BaseTools: Fix GenFds error

Re: [edk2] [PATCH] BaseTools: Fix GenFds error doesn't break build.

Hi Derek, This patch looks good to me. But I failed to apply this patch on master. Could you update this patch? Thanks, Bob -Original Message- From: Lin, Derek (HPS SW) [mailto:derek.l...@hpe.com] Sent: Tuesday, December 18, 2018 4:52 PM To: edk2-devel@lists.01.org; Feng, Bob C ; Zhao,

[edk2] [PATCH] BaseTools: Fix GenFds error doesn't break build.

Fix a bug because of b3497bad1221704a5dbc5da0b10f42625f1ad2ed. Before the patch, when GenFds fail, the build continue and return success. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- BaseTools/Source/Python/build/build.py | 7 +-- 1 file changed, 5 ins