Hi Laszlo & Dandan,
Here is the updated patch for your review. Thank you!
https://lists.01.org/pipermail/edk2-devel/2019-January/035954.html
Regards,
Neo
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, January 29, 2019 2:57 AM
> To: Hsueh, Hong-chihX
On 01/29/19 06:13, Bi, Dandan wrote:
> Hi Neo,
>
> Thank you very much for the patch.
>
> Some minor comments
> 1) Besides the skip check in this patch, could you help to add additional
> check for RelocDir->Size before calling PeCoffLoaderImageAddress to calculate
> the RelocBase and RelocBas
On 01/29/19 00:22, Neo Hsueh wrote:
> Skip runtime relocation for PE images that provide invalid relocation
> infomation
> (ex: RelocDir->Size = 0) to fix a hang observed while booting Windows.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Signed-off-by: Neo Hsueh
> Cc: Michae
On 01/29/19 00:40, Hsueh, Hong-chihX wrote:
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Monday, January 28, 2019 2:17 PM
>> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org
>> Cc: Kinney, Michael D ; Gao, Liming
>> ; Bi, Dandan
>> Subject: Re: [PATCH] Mde
Hi Neo,
Thank you very much for the patch.
Some minor comments
1) Besides the skip check in this patch, could you help to add additional
check for RelocDir->Size before calling PeCoffLoaderImageAddress to calculate
the RelocBase and RelocBaseEnd?
Since when RelocDir->Size==0, we can just retur
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, January 28, 2019 2:17 PM
> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan
> Subject: Re: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
> rel
Skip runtime relocation for PE images that provide invalid relocation infomation
(ex: RelocDir->Size = 0) to fix a hang observed while booting Windows.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Neo Hsueh
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Dandan Bi
Cc: Laszlo
On 01/28/19 19:40, Neo Hsueh wrote:
> Skip runtime relocation for PE images that provide invalid relocation
> infomation
> (ex: RelocDir->Size = 0) to fix a hang observed while booting
> Windows.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Signed-off-by: Neo Hsueh
> Cc: Mich
; To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Bi, Dandan
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
> relocation info is invalid.
>
> On 01/25/19 00:18, Neo Hsueh wrote:
> > 1.Skip runtime relo
Skip runtime relocation for PE images that provide invalid relocation infomation
(ex: RelocDir->Size = 0) to fix a hang observed while booting
Windows.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Neo Hsueh
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Dandan Bi
Cc: Laszlo
On 01/25/19 00:18, Neo Hsueh wrote:
> 1.Skip runtime relocation for PE images that provide invalid relocation
> infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting
> Windows.
> 2.Add a magic number check for PE32+ image.
>
> Contributed-under: TianoCore Contribution Agreem
1.Skip runtime relocation for PE images that provide invalid relocation
infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting
Windows.
2.Add a magic number check for PE32+ image.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Neo Hsueh
Cc: Michael D
12 matches
Mail list logo
