Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Laszlo Ersek
On 10/18/16 16:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: Tim Lewis [mailto:tim.le...@insyde.com] >> Sent: Tuesday, October 18, 2016 5:44 AM >> To: Laszlo Ersek ; edk2-devel-01 > de...@ml01.01.org> >>

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Tuesday, October 18, 2016 5:44 AM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org> > Cc: Carsey, Jaben ; Ni,

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Tim Lewis
Reviewed-by: Tim Lewis -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 18, 2016 4:07 AM To: edk2-devel-01 Cc: Jaben Carsey ; Ruiyu Ni ; Tim Lewis

[edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Laszlo Ersek
The destination GUID comes first; from "MdePkg/Include/Library/BaseMemoryLib.h": > GUID * > EFIAPI > CopyGuid ( > OUT GUID *DestinationGuid, > IN CONST GUID *SourceGuid > ); Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and "Guid" is where