Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Qiu, Shumin
Good comment. -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, August 27, 2015 6:58 AM To: Qiu, Shumin Cc: edk2-devel@lists.01.org; Carsey, Jaben Subject: Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command. Hi, On Wed, Aug 26

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Leif Lindholm
Hi, On Wed, Aug 26, 2015 at 10:45:35AM +0800, Qiu Shumin wrote: > Initialize the local pointer to avoid to free a dangling pointer. > > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin > --- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dr

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-26 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, August 25, 2015 7:46 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command. > Importance: High > > Initialize the local

[edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

2015-08-25 Thread Qiu Shumin
Initialize the local pointer to avoid to free a dangling pointer. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ShellPkg/Library/U