Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-03 Thread Laszlo Ersek
On 12/03/15 06:35, Qiu Shumin wrote: > In some platform 'map -r' may cost more than 1 min. This patch filter the > target handles by > BlockIO and SimpleFileSystem protocol to reduce the time cost. Hijacking this thread and asking a more general question -- I noticed recently that the "devices"

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-03 Thread Carsey, Jaben
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 3:26 AM > To: Qiu, Shumin ; edk2-de...@ml01.01.org > Cc: Carsey, Jaben > Subject: Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-03 Thread Laszlo Ersek
On 12/03/15 18:04, Carsey, Jaben wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, December 03, 2015 3:26 AM >> To: Qiu, Shumin ; edk2-de...@ml01.01.org >> Cc: Carsey, Jaben >> Subject: Re:

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-03 Thread Laszlo Ersek
On 12/03/15 18:03, Carsey, Jaben wrote: > Shumin, > > Could we loop over a list of handles made by > 1) LocateHandleBuffer on BlockIO > 2) LocateHandleBuffer on SimpleFileSystem > 3) Combine these lists (removing duplicates) So this is exactly the use case that I had in mind (regardless of

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-03 Thread Carsey, Jaben
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 9:16 AM > To: Carsey, Jaben ; Qiu, Shumin > ; edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce

[edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-02 Thread Qiu Shumin
In some platform 'map -r' may cost more than 1 min. This patch filter the target handles by BlockIO and SimpleFileSystem protocol to reduce the time cost. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin