Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

gt; > > > > > Hi, > > > > > > > > As per commit 0961002352e9115b72f544dded239ad226efe87b > > > > > > > > Tftp command will be maintained to extend internal commands and > > > > > > > > ShellPkg/DynamicCommand/TftpDynamicCom

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

<siyuan...@intel.com>; ard.biesheu...@linaro.org > Subject: Re: [edk2] [PATCH] Tftp assert fix for openfile failure case > Importance: High > > Jaben, > > The patch was not accepted last time because as per Leif > " > > > > > > > This shell command was i

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

t; ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > > > > Looks like a copy of ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > > > > So, below fix is needed in this case as well. > > > > Please suggest, so we can send the updated patch [incorporating Leif's > &g

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

Kumar > > Sent: Thursday, November 09, 2017 10:13 AM > > To: Leif Lindholm <leif.lindh...@linaro.org> > > Cc: ruiyu...@intel.com; ard.biesheu...@linaro.org; ting...@intel.com; > edk2- > > de...@lists.01.org; jaben.car...@intel.com; siyuan...@intel.com > > Subject: Re: [ed

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

olm <leif.lindh...@linaro.org> > Cc: ruiyu...@intel.com; ard.biesheu...@linaro.org; ting...@intel.com; edk2- > de...@lists.01.org; jaben.car...@intel.com; siyuan...@intel.com > Subject: Re: [edk2] [PATCH] Tftp assert fix for openfile failure case > > > > > -

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, November 08, 2017 8:52 PM > To: Udit Kumar > Cc: Vabhav Sharma ; edk2-devel@lists.01.org; > ruiyu...@intel.com; jaben.car...@intel.com;

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

On Wed, Nov 08, 2017 at 05:15:49AM +, Udit Kumar wrote: > > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > > > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > > > index fbde3bf..6425fc5 100755 > > > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > > > +++

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, November 07, 2017 11:25 PM > To: Vabhav Sharma > Cc: edk2-devel@lists.01.org; ruiyu...@intel.com; jaben.car...@intel.com; > ard.biesheu...@linaro.org;

Re: [edk2] [PATCH] Tftp assert fix for openfile failure case

On Fri, Nov 03, 2017 at 07:56:32PM +0530, Vabhav wrote: > Issue: > when file open is failed, assert was seen due to freeing 0 size page > > Reason: > DataSize is remain zero if error is reported in ShellOpenFileByName > > Fix: > Update DataSize as soon as FileSize is available > >

[edk2] [PATCH] Tftp assert fix for openfile failure case

Issue: when file open is failed, assert was seen due to freeing 0 size page Reason: DataSize is remain zero if error is reported in ShellOpenFileByName Fix: Update DataSize as soon as FileSize is available Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Udit Kumar