Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Jordan Justen
On 2017-11-13 05:09:03, Laszlo Ersek wrote: > given that I'm opposed to calling any library functions before we reach > the ProcessLibraryConstructorList() call lower down in > SecCoreStartupWithStack(), I cannot agree to calling SetJump() either. Good point. -Jordan

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Jordan Justen
On 2017-11-13 04:34:05, Laszlo Ersek wrote: > AsmReadSp() is IPF only (the BaseLib class header says so, and the tree > agrees). > > AsmReadEsp() and AsmReadRsp() do not exist in BaseLib, and they would > only be implementable for x86. I think platform-dependent library > *interfaces* don't

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Laszlo Ersek
On 11/13/17 13:34, Laszlo Ersek wrote: > I guess I could live with BASE_LIBRARY_JUMP_BUFFER. Actually: > More specific comments: > >> diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c >> index f7fec3d8c0..077f7d6563 100644 >> --- a/OvmfPkg/Sec/SecMain.c >> +++ b/OvmfPkg/Sec/SecMain.c

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Laszlo Ersek
On 11/13/17 11:09, Ard Biesheuvel wrote: > On 13 November 2017 at 09:08, Jordan Justen > wrote: >> On 2017-11-12 02:58:37, Ard Biesheuvel wrote: >>> On 11 November 2017 at 22:04, Jordan Justen >>> wrote: On 2017-11-11 12:38:21, Jordan

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Ard Biesheuvel
On 13 November 2017 at 09:08, Jordan Justen wrote: > On 2017-11-12 02:58:37, Ard Biesheuvel wrote: >> On 11 November 2017 at 22:04, Jordan Justen >> wrote: >> > On 2017-11-11 12:38:21, Jordan Justen wrote: >> >> On 2017-11-10 07:49:04,

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-13 Thread Jordan Justen
On 2017-11-12 02:58:37, Ard Biesheuvel wrote: > On 11 November 2017 at 22:04, Jordan Justen wrote: > > On 2017-11-11 12:38:21, Jordan Justen wrote: > >> On 2017-11-10 07:49:04, Laszlo Ersek wrote: > >> > The first three patches enable the PEI_CORE to report OVMF's temp

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-12 Thread Ard Biesheuvel
On 11 November 2017 at 22:04, Jordan Justen wrote: > On 2017-11-11 12:38:21, Jordan Justen wrote: >> On 2017-11-10 07:49:04, Laszlo Ersek wrote: >> > The first three patches enable the PEI_CORE to report OVMF's temp >> > SEC/PEI stack and heap usage. >> > >> > - This

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-11 Thread Jordan Justen
On 2017-11-11 12:38:21, Jordan Justen wrote: > On 2017-11-10 07:49:04, Laszlo Ersek wrote: > > The first three patches enable the PEI_CORE to report OVMF's temp > > SEC/PEI stack and heap usage. > > > > - This depends on the new fixed PCD "PcdInitValueInTempStack", > > recently added for >

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-11 Thread Jordan Justen
On 2017-11-10 07:49:04, Laszlo Ersek wrote: > The first three patches enable the PEI_CORE to report OVMF's temp > SEC/PEI stack and heap usage. > > - This depends on the new fixed PCD "PcdInitValueInTempStack", > recently added for >

Re: [edk2] [PATCH 0/4] OvmfPkg: measure temp stack usage, restore temp RAM to 64KB

2017-11-11 Thread Ard Biesheuvel
On 10 November 2017 at 15:49, Laszlo Ersek wrote: > The first three patches enable the PEI_CORE to report OVMF's temp > SEC/PEI stack and heap usage. > > - This depends on the new fixed PCD "PcdInitValueInTempStack", > recently added for >