Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
On 11/04/16 16:29, Paolo Bonzini wrote: > > > On 04/11/2016 16:22, Laszlo Ersek wrote: What does this *KVM internal error. Suberror: 1* mean? >> The key message is "emulation failure" -- it means that the processor >> exits to the hypervisor (KVM) because it finds some code that it cannot

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
On 11/04/16 14:50, Paolo Bonzini wrote: > > > On 04/11/2016 14:28, Yao, Jiewen wrote: >> I tried below way. But it does not help too much. It still takes more >> than 1 minutes to boot with SMP=8. >> >> SendSmiIpiAllExcludingSelf (); >> IoWrite8 (ICH9_APM_STS, DataPort== NULL ? 0 :

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
On 11/04/16 04:14, Yao, Jiewen wrote: > Mike > > You are right. > > After I turn on this, I saw all APs. > > > > However, the system becomes extremely slow. Intolerable. > > > > I suggest to add more description around below on why it is set to 0x01 > by default, and what is the impact

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
On 11/04/16 02:15, Yao, Jiewen wrote: > Thank you, Mike. > Yes, I reproduced the issue and found out what is wrong. Here is detail: > > It seems OVMF never puts AP in SMM mode, even *before my patch series*. > I rollback all my update and use e9d093. > > I add some debug message in

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Paolo Bonzini
On 04/11/2016 16:22, Laszlo Ersek wrote: >> > What does this *KVM internal error. Suberror: 1* mean? > The key message is "emulation failure" -- it means that the processor > exits to the hypervisor (KVM) because it finds some code that it cannot > execute in guest mode natively, so the

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
n, Feng <feng.t...@intel.com>; Radim Krčmář <rkrc...@redhat.com>; > edk2-de...@ml01.01.org; Kinney, Michael D <michael.d.kin...@intel.com>; Paolo > Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff....@intel.com>; Zeng, Star > <star.z...@intel.com>

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Laszlo Ersek
o Jiewen > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, November 4, 2016 5:43 AM > To: Yao, Jiewen <jiewen@intel.com> > Cc: Tian, Feng <feng.t...@intel.com>; Radim Krčmář <rkrc...@redhat.com>; > edk

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Paolo Bonzini
On 04/11/2016 14:28, Yao, Jiewen wrote: > I tried below way. But it does not help too much. It still takes more > than 1 minutes to boot with SMP=8. > > SendSmiIpiAllExcludingSelf (); > IoWrite8 (ICH9_APM_STS, DataPort== NULL ? 0 : *DataPort); > IoWrite8 (ICH9_APM_CNT, CommandPort ==

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Yao, Jiewen
ichael D <michael.d.kin...@intel.com>; Laszlo Ersek <ler...@redhat.com> Cc: Tian, Feng <feng.t...@intel.com>; Radim Kr?má? <rkrc...@redhat.com>; edk2-de...@ml01.01.org; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [P

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-04 Thread Yao, Jiewen
tel.com> Subject: Re: [edk2] [PATCH 0/6] Enable SMM page level protection. On 11/03/16 07:53, Jiewen Yao wrote: > This series patch enables SMM page level protection. > Features are: > 1) PiSmmCore reports SMM PE image code/data information > in EdkiiPiSmmMemoryAttributeTable, if

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
@intel.com>; Radim Kr?má? <rkrc...@redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection. Jiewen, Here is the com

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
gt;; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Radim Kr?má? <rkrc...@redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [ed

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Kinney, Michael D
an, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection. Jiewen, I remember now. Ovmf uses a different PCD setting for PcdCpuSmmSyncMode. !if $(SMM_REQUIRE) == TRUE gU

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Kinney, Michael D
redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection. Thanks Mike. I added "-cpu Nehalem -global ICH9-LPC.disable_s3=1", an

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
t;; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Radim Kr?má? <rkrc...@redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [e

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Kinney, Michael D
..@redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection. Thank you, Mike. Yes, I reproduced the issue and found out wha

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
c: Tian, Feng <feng.t...@intel.com>; Radim Kr?má? <rkrc...@redhat.com>; edk2-de...@ml01.01.org; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff....@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Kinney, Michael D
...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/6] Enable SMM page level protection. Hi Laszlo I appreciate your help to validate the patch for me. Yes, I am using a windows QEMU

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
; edk2-de...@ml01.01.org; Kinney, Michael D <michael.d.kin...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; Fan, Jeff <jeff....@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH 0/6] Enable SMM page level protection. On 11/03/16 07:53, Jiewen Yao wrote: &g

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Laszlo Ersek
On 11/03/16 07:53, Jiewen Yao wrote: > This series patch enables SMM page level protection. > Features are: > 1) PiSmmCore reports SMM PE image code/data information > in EdkiiPiSmmMemoryAttributeTable, if the SMM image is page aligned. > 2) PiSmmCpu consumes EdkiiPiSmmMemoryAttributeTable > and

Re: [edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Yao, Jiewen
ao > Sent: Thursday, November 3, 2016 2:54 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Fan, Jeff > <jeff@intel.com>; Zeng, Star <star.z...@intel

[edk2] [PATCH 0/6] Enable SMM page level protection.

2016-11-03 Thread Jiewen Yao
This series patch enables SMM page level protection. Features are: 1) PiSmmCore reports SMM PE image code/data information in EdkiiPiSmmMemoryAttributeTable, if the SMM image is page aligned. 2) PiSmmCpu consumes EdkiiPiSmmMemoryAttributeTable and set XD for data page and RO for code page. 3)