Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

Sorry for the trivial comments. "@param[in] ResetType Base reset type as defined in UEFI spec." needs to be removed for ResetPlatformSpecificGuid. There is "in in" in the comments for the implementation of GetResetPlatformSpecificGuid(). May should be one "in" only? Thanks, Star On

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

Another minor comments is to remove below sentences in ResetUtilityLib.inf. > +# The application pops up a menu showing all the boot options referenced by > +# BootOrder NV variable and user can choose to boot from one of them. Thanks, Star On 2018/2/7 20:28, Zeng, Star wrote: On

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney The library class that provides services to generate a GUID specific reset, parse the GUID from a GUID specific reset, and build the ResetData buffer for any type of reset that requires extra data. Cc:

[edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

From: Michael D Kinney The library class that provides services to generate a GUID specific reset, parse the GUID from a GUID specific reset, and build the ResetData buffer for any type of reset that requires extra data. Cc: Liming Gao