Re: [edk2] [PATCH 3/4] ArmPkg/GenericWatchdogDxe: clean up the code

2018-12-18 Thread Leif Lindholm
On Tue, Dec 18, 2018 at 04:19:20PM +0100, Ard Biesheuvel wrote: > > > @@ -178,8 +186,8 @@ WatchdogSetTimerPeriod ( > > > > > >// if TimerPeriod is 0, this is a request to stop the watchdog. > > >if (TimerPeriod == 0) { > > > -mNumTimerTicks = 0; > > > -WatchdogDisable (); > > > +

Re: [edk2] [PATCH 3/4] ArmPkg/GenericWatchdogDxe: clean up the code

2018-12-18 Thread Ard Biesheuvel
On Tue, 18 Dec 2018 at 14:43, Leif Lindholm wrote: > > On Tue, Dec 18, 2018 at 02:10:13PM +0100, Ard Biesheuvel wrote: > > Clean up the code, by adding missing STATIC modifiers, drop > > redundant casts, and get rid of the 'success handling' anti > > pattern in the entry point code. > > > >

Re: [edk2] [PATCH 3/4] ArmPkg/GenericWatchdogDxe: clean up the code

2018-12-18 Thread Leif Lindholm
On Tue, Dec 18, 2018 at 02:10:13PM +0100, Ard Biesheuvel wrote: > Clean up the code, by adding missing STATIC modifiers, drop > redundant casts, and get rid of the 'success handling' anti > pattern in the entry point code. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] [PATCH 3/4] ArmPkg/GenericWatchdogDxe: clean up the code

2018-12-18 Thread Ard Biesheuvel
Clean up the code, by adding missing STATIC modifiers, drop redundant casts, and get rid of the 'success handling' anti pattern in the entry point code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---