Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-07 Thread Laszlo Ersek
On 03/07/16 04:51, Jordan Justen wrote: > On 2016-03-06 06:28:26, Laszlo Ersek wrote: [snip] >> So here's what I would like, in decreasing order of preference: >> >> * Keep the patch, as is. (Most preferred.) >> >> * Keep the library instance under OvmfPkg, but set MODULE_TYPE to >>

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-06 Thread Jordan Justen
On 2016-03-06 06:28:26, Laszlo Ersek wrote: > On 03/05/16 00:47, Kinney, Michael D wrote: > > Jordan, > > > > Given these libs are Base type, a Dynamic PCD could not be used. Only a > > fixed > > or patchable PCD could be used, and if you go through path, you might as > > well > > pick the

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-06 Thread Laszlo Ersek
On 03/05/16 00:47, Kinney, Michael D wrote: > Jordan, > > Given these libs are Base type, a Dynamic PCD could not be used. Only a fixed > or patchable PCD could be used, and if you go through path, you might as well > pick the right lib in the DSC at build time and get smaller size and better >

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-04 Thread Kinney, Michael D
Jordan, Given these libs are Base type, a Dynamic PCD could not be used. Only a fixed or patchable PCD could be used, and if you go through path, you might as well pick the right lib in the DSC at build time and get smaller size and better performance. If we wanted to restrict the use of this

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-04 Thread Laszlo Ersek
On 03/04/16 22:05, Laszlo Ersek wrote: > On 03/04/16 21:38, Jordan Justen wrote: >> On 2016-03-04 06:46:32, Laszlo Ersek wrote: >>> This library is a trivial unification of the following two PciLib >>> instances (and the result is easily diffable against each): >>> - MdePkg/Library/BasePciLibCf8

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-04 Thread Laszlo Ersek
On 03/04/16 21:38, Jordan Justen wrote: > On 2016-03-04 06:46:32, Laszlo Ersek wrote: >> This library is a trivial unification of the following two PciLib >> instances (and the result is easily diffable against each): >> - MdePkg/Library/BasePciLibCf8 >> - MdePkg/Library/BasePciLibPciExpress >> >

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-04 Thread Jordan Justen
On 2016-03-04 06:46:32, Laszlo Ersek wrote: > This library is a trivial unification of the following two PciLib > instances (and the result is easily diffable against each): > - MdePkg/Library/BasePciLibCf8 > - MdePkg/Library/BasePciLibPciExpress > Mike, what would you think about a