Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Zhichao
Sorry, I am not familiar with EBC. I only keep the original logic of it. Thanks, Zhichao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, March 25, 2019 4:26 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Wang, Jian J ; Wu, Hao > A ;

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Ard Biesheuvel
On Fri, 22 Mar 2019 at 04:09, Zhichao Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 > > The IA32 ARCH need cache flush function during capsule update. > Both arm ARCH and IA32 do not need flush cache function, so > merge the CapsuleCacheWriteBack() to one file. And add a

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Zhichao
Liming, Both IA32 and X64 ARCH need flush function. My fault to use IA32 to represent the X86 and X64 ARCH. I will clarify it in the commit message later. Thanks, Zhichao > -Original Message- > From: Gao, Liming > Sent: Monday, March 25, 2019 2:59 PM > To: Gao, Zhichao ;

Re: [edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-25 Thread Gao, Liming
Zhichao: Could you help clarify the commit message? Does IA32 and X64 Arch implementation need flush function or not? >The IA32 ARCH need cache flush function during capsule update. >Both arm ARCH and IA32 do not need flush cache function, Thanks Liming >-Original Message- >From:

[edk2] [PATCH V2 1/2] MdeModulePkg/CapsuleRuntimeDxe: IA32 add cache flush function

2019-03-21 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462 The IA32 ARCH need cache flush function during capsule update. Both arm ARCH and IA32 do not need flush cache function, so merge the CapsuleCacheWriteBack() to one file. And add a null version for EBC. Contributed-under: TianoCore