Re: [edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-26 Thread Gao, Zhichao
Thanks for your reply. The variable "mVaListNull" I prefer to keep it as a module data even though there is only one source file in this DebugLib inf. Thanks, Zhichao > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, March 26, 2019 8:19 PM > To

Re: [edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-26 Thread Ard Biesheuvel
On Tue, 26 Mar 2019 at 13:19, Leif Lindholm wrote: > > Hi Zhichao, > > Apologies for delay in responding, due to holiday and stuff. > > On the whole this looks fine (one comment below), but I don't actually > have any platform on which to test this. > > Ard: maybe it's time to retire this componen

Re: [edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-26 Thread Leif Lindholm
Hi Zhichao, Apologies for delay in responding, due to holiday and stuff. On the whole this looks fine (one comment below), but I don't actually have any platform on which to test this. Ard: maybe it's time to retire this component? On Thu, Mar 21, 2019 at 10:04:50PM +0800, Zhichao Gao wrote: >

[edk2] [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs

2019-03-21 Thread Zhichao Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib instance. These APIs would expose print routines with VaList parameter and BaseList parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zh