Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

OK, I will modify the subject line and drop the change about PlatformIntelBdsLib. Also other comments will be handled. On 2018/1/23 18:28, Leif Lindholm wrote: > I don't agree with this subject line - there is no optimization going > on here. > > "Break BMC SetBoot option out into separate

Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

I don't agree with this subject line - there is no optimization going on here. "Break BMC SetBoot option out into separate library" would be a more accurate subject line. For the record, I think this is good cleanup even without the dual-BDS support. On Thu, Jan 18, 2018 at 11:01:32PM +0800,

Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

The sources will be modified following below comments. On 2018/1/20 18:41, Ard Biesheuvel wrote: > On 18 January 2018 at 15:01, Ming Huang wrote: >> Modify the feature of BMC set boot option as switching generic >> BDS. Move main functions to BmcConfigBootLib. >> >>

Re: [edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

On 18 January 2018 at 15:01, Ming Huang wrote: > Modify the feature of BMC set boot option as switching generic > BDS. Move main functions to BmcConfigBootLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang >

[edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

Modify the feature of BMC set boot option as switching generic BDS. Move main functions to BmcConfigBootLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/D03.dsc