Re: [edk2] [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4

2018-01-23 Thread Leif Lindholm
The patch is good, but the subject is too broad, and the message could be more descriptive. Subject should say something like "Indicate use of ProcessorFamily2 in type 4 table". Message should point out that ProcessorFamily2 is already specified as ProcessorFamilyARM in the existing table.

Re: [edk2] [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4

2018-01-20 Thread Ard Biesheuvel
On 18 January 2018 at 15:01, Ming Huang wrote: > modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, > indicator to obtain the processor family from the Processor Family 2 field. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

[edk2] [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4

2018-01-18 Thread Ming Huang
modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, indicator to obtain the processor family from the Processor Family 2 field. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo