Re: [edk2] [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-22 Thread Leif Lindholm
On Wed, Aug 22, 2018 at 10:54:54PM +0800, Ming wrote: > > > On 8/22/2018 5:49 PM, Leif Lindholm wrote: > > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: > >> Add PcdCoreCount to fix build issue while add binary components. > > > > This commit message fails to describe what is

Re: [edk2] [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-22 Thread Ming
On 8/22/2018 5:49 PM, Leif Lindholm wrote: > On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: >> Add PcdCoreCount to fix build issue while add binary components. > > This commit message fails to describe what is being done, apart from a > single thing that should be a separate

Re: [edk2] [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-22 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 04:08:32PM +0800, Ming Huang wrote: > Add PcdCoreCount to fix build issue while add binary components. This commit message fails to describe what is being done, apart from a single thing that should be a separate patch. Pleas add a proper commit message describing which

[edk2] [PATCH edk2-platforms v2 12/43] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-14 Thread Ming Huang
Add PcdCoreCount to fix build issue while add binary components. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 7 +++ Platform/Hisilicon/D06/D06.fdf