Re: [edk2] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-23 Thread Ming
On 8/23/2018 5:44 PM, Leif Lindholm wrote: > On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote: >> >> >> On 8/22/2018 11:33 PM, Leif Lindholm wrote: >>> On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote: Add some Lpc macro to LpcLib.h for D06. >>> >>> Unaddressed feedback

Re: [edk2] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-23 Thread Leif Lindholm
On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote: > > > On 8/22/2018 11:33 PM, Leif Lindholm wrote: > > On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote: > >> Add some Lpc macro to LpcLib.h for D06. > >> > > > > Unaddressed feedback from v1: > > > > I have no issue with this

Re: [edk2] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-23 Thread Ming
On 8/22/2018 11:33 PM, Leif Lindholm wrote: > On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote: >> Add some Lpc macro to LpcLib.h for D06. >> > > Unaddressed feedback from v1: > > I have no issue with this patch, but can you explain when these macros > are intended to be used? And

[edk2] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

2018-08-14 Thread Ming Huang
Add some Lpc macro to LpcLib.h for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/LpcLib.h | 51 +++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git