Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-23 Thread Leif Lindholm
On Fri, Nov 17, 2017 at 05:42:30PM +, Ard Biesheuvel wrote: > On 17 November 2017 at 16:10, Leif Lindholm wrote: > > And use a local variable Pin, initialized to > > FixedPcdGet32 (PcdClearSettingsGpioPin) - 1? > > (You could then also have an assert verifying

Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-17 Thread Ard Biesheuvel
On 17 November 2017 at 16:10, Leif Lindholm wrote: > On Fri, Nov 10, 2017 at 02:21:22PM +, Ard Biesheuvel wrote: >> Ordinary computers typically have a physical switch or jumper on the >> board that allows non-volatile settings to be cleared. Let's implement >> the

Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-17 Thread Leif Lindholm
On Fri, Nov 10, 2017 at 02:21:22PM +, Ard Biesheuvel wrote: > Ordinary computers typically have a physical switch or jumper on the > board that allows non-volatile settings to be cleared. Let's implement > the same using DIP switch #1 on block #3, and clear the EFI variable > store if it is

Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-17 Thread Ard Biesheuvel
On 17 November 2017 at 15:51, Leif Lindholm wrote: > On Fri, Nov 10, 2017 at 02:21:22PM +, Ard Biesheuvel wrote: >> Ordinary computers typically have a physical switch or jumper on the >> board that allows non-volatile settings to be cleared. Let's implement >> the

Re: [edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-17 Thread Leif Lindholm
On Fri, Nov 10, 2017 at 02:21:22PM +, Ard Biesheuvel wrote: > Ordinary computers typically have a physical switch or jumper on the > board that allows non-volatile settings to be cleared. Let's implement > the same using DIP switch #1 on block #3, and clear the EFI variable > store if it is

[edk2] [PATCH edk2-platforms v4 29/34] Silicon/SynQuacer: implement 'clear NVRAM' feature using a DIP switch

2017-11-10 Thread Ard Biesheuvel
Ordinary computers typically have a physical switch or jumper on the board that allows non-volatile settings to be cleared. Let's implement the same using DIP switch #1 on block #3, and clear the EFI variable store if it is set to ON at boot time. Contributed-under: TianoCore Contribution