Re: [edk2] [PATCH edk2-platforms v4 3/6] Platform/HiKey960: enable virtual keyboard

2018-05-21 Thread Leif Lindholm
On Mon, May 14, 2018 at 12:34:30PM +0800, Haojian Zhuang wrote: > Enable virtual keyboard on HiKey960 platform. It checks two > conditions, such as pattern in memory and GPIO pin setting. Please add a comment to commit message regarding use of hardcoded values from reference code, same as for 2/6.

[edk2] [PATCH edk2-platforms v4 3/6] Platform/HiKey960: enable virtual keyboard

2018-05-13 Thread Haojian Zhuang
Enable virtual keyboard on HiKey960 platform. It checks two conditions, such as pattern in memory and GPIO pin setting. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang --- Platform/Hisilicon/HiKey960/HiKey960.dsc