Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

2018-04-26 Thread Laszlo Ersek
On 04/26/18 05:12, Haojian Zhuang wrote: > On 26 April 2018 at 00:10, Laszlo Ersek wrote: >> (4) In both patches, in both of the CreatePlatformBootOptionFromPath() >> and CreatePlatformBootOptionFromGuid() helper functions, the >> "DevicePath" variable is leaked when >>

Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

2018-04-25 Thread Haojian Zhuang
On 26 April 2018 at 00:10, Laszlo Ersek wrote: > Hello Haojian, > > On 04/25/18 06:59, Haojian Zhuang wrote: >> Changelog: >> v5: >> * Avoid to merge device path and grub's file path in driver. >> Merge them directly in DSC file. >> * Avoid duplicated code to create

Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

2018-04-25 Thread Laszlo Ersek
Hello Haojian, On 04/25/18 06:59, Haojian Zhuang wrote: > Changelog: > v5: > * Avoid to merge device path and grub's file path in driver. > Merge them directly in DSC file. > * Avoid duplicated code to create boot options. > * Use goto to handle error condition. > v4: > * Add

[edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

2018-04-24 Thread Haojian Zhuang
Changelog: v5: * Avoid to merge device path and grub's file path in driver. Merge them directly in DSC file. * Avoid duplicated code to create boot options. * Use goto to handle error condition. v4: * Add BootCount parameter in the interface. v3: * Move in initilization of boot