Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Carsey, Jaben
22, 2018 5:52 AM > To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set > > Yes. I also check V1. It also pass patchchecker. > > > -Original Message- > > From: Marvin Häuser [mailto:marvin

Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Gao, Liming
around who has an idea what the issue > > could be? > > > > > > Thanks, > > > Marvin > > > > > > > -Original Message- > > > > From: edk2-devel On Behalf Of > > > > Marvin Häuser > > > > Sent:

Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Marvin Häuser
ong even though the CMD clearly shows the cc. > > > > Is there maybe some git expert around who has an idea what the issue > could be? > > > > Thanks, > > Marvin > > > > > -Original Message- > > > From: edk2-devel On Behalf Of

Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Gao, Liming
alf Of Marvin > > Häuser > > Sent: Tuesday, May 22, 2018 1:48 PM > > To: edk2-devel@lists.01.org > > Cc: liming@intel.com > > Subject: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set > > > > Commit 88252a90d1ca7846731cd2e4e8e860454f7d97a3

Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Marvin Häuser
around who has an idea what the issue could be? Thanks, Marvin > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Tuesday, May 22, 2018 1:48 PM > To: edk2-devel@lists.01.org > Cc: liming@intel.com > Subject: [edk2] [PATCH v2] BaseTools/Work

[edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

2018-05-22 Thread Marvin Häuser
Commit 88252a90d1ca7846731cd2e4e8e860454f7d97a3 changed ValueChain from a dict to a set, but also changed the (former) key type from a touple to two separate values, which was probably unintended and also breaks build for packages involving Structured PCDs, because add() only takes one argument. Th