Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Wang, Jian J
<star.z...@intel.com> > Subject: RE: [edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old > Visual Studio > > Please also update the "This patch change them to decimal to fix it" in the > commit log accordingly, with that fixed, Reviewed-by: Star Zeng &

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Zeng, Star
ian J Wang Sent: Monday, November 20, 2017 1:41 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old Visual Studio > v2 >

[edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old Visual Studio

2017-11-19 Thread Jian J Wang
> v2 > a. Change an incorrect comment on return value > b. Change constants to macros The build error is introduced by following check in: 2930ef9809976ce693d1d377851344c3b06bd926 235a4490c8ce8b6dbac49e6ae3559cb73d6bf620 The Visual Studio older than 2015 doesn't support constant integer in