subject:"\[edk2\] \[PATCH v2 4\/5\] OvmfPkg\: include UefiCpuPkg\/CpuMpPei"

Re: [edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-13 Thread Laszlo Ersek

On 07/13/16 02:40, Fan, Jeff wrote: > Laszlo, > > Even I have r-b this patch before, I have one comment now. :-) > > It's better to move PeiCpuExceptionHandlerLib instance from CpuMpPei to > > [LibraryClasses.common.PEIM] > + >

Re: [edk2] [PATCH v2 4/5] OvmfPkg: include UefiCpuPkg/CpuMpPei

2016-07-12 Thread Fan, Jeff

Laszlo, Even I have r-b this patch before, I have one comment now. :-) It's better to move PeiCpuExceptionHandlerLib instance from CpuMpPei to [LibraryClasses.common.PEIM] + CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf It's more generic and