subject:"\[edk2\] \[PATCH v3 3\/6\] MdeModulePkg\/Core\/Dxe\: Add EndOfDxe workaround"

Re: [edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Wang, Jian J

Thanks for the feedback. Please see my comments below. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:35 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Yao, >

Re: [edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Zeng, Star

Some comments to this patch. 1. How about using lower TPL TPL_CALLBACK instead of TPL_NOTIFY for the notification? 2. Should GCD SetMemorySpaceCapabilities + SetMemorySpaceAttributes be used instead of gCpu->SetMemoryAttributes()? Thanks, Star -Original Message- From: Wang, Jian J

[edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

2017-09-27 Thread Jian J Wang

One of issue caused by enabling NULL pointer detection is that some PCI device OptionROM, binary drivers and binary OS boot loaders may have NULL pointer access bugs, which will prevent BIOS from booting and is almost impossible to fix. BIT7 of PCD PcdNullPointerDetectionPropertyMask is used as a