Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-06 Thread Meenakshi Aggarwal
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, March 06, 2018 4:41 PM > To: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDH

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-06 Thread Ard Biesheuvel
On 6 March 2018 at 05:14, Meenakshi Aggarwal wrote: > Hi, > > I am using Mmc Driver implemented in " EmbeddedPkg/Universal/MmcDxe/" for my > SD/MMC controller and my controller is not on PCI bus. > > I am a bit confused if i should move to SD implementation available

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-03-05 Thread Meenakshi Aggarwal
tel.com>; Wu, > Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org; > leif.lindh...@linaro.org; Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers > > On 30 January 2018 at 01:24, Zeng, Sta

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-30 Thread Ard Biesheuvel
On 30 January 2018 at 01:24, Zeng, Star wrote: > Reviewed-by: Star Zeng > > Thanks Hao's investigation and Ard's contribution. > Thanks all Pushed as 864701886fc3..b23fc39cd3c3 > > Star > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-30 Thread Ni, Ruiyu
Ard, No more comments from my side. Thanks/Ray > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, January 29, 2018 4:26 PM > To: Wu, Hao A ; Zeng, Star ; Ni, > Ruiyu > Cc:

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-29 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks Hao's investigation and Ard's contribution. Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, January 29, 2018 4:26 PM To: Wu, Hao A ; Zeng, Star ;

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-29 Thread Ard Biesheuvel
On 29 January 2018 at 05:13, Wu, Hao A wrote: > One minor comment, please help to remove the line (around line 1067): > @param[in] Capability The capability of the slot. > > within function description comment for SdMmcHcInitHost() in file: >

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-28 Thread Wu, Hao A
One minor comment, please help to remove the line (around line 1067): @param[in] Capability The capability of the slot. within function description comment for SdMmcHcInitHost() in file: MdeModulePkg\Bus\Pci\SdMmcPciHcDxe\SdMmcPciHci.c Other than that, the series is good to me: Reviewed-by:

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2018-01-08 Thread Ard Biesheuvel
: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Kinney, >> Michael D; Zeng, Star >> Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers >> >> On 7 December 2017 at 22:43, Ard Biesheuvel <

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2017-12-12 Thread Ard Biesheuvel
: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Kinney, >> Michael D; Zeng, Star >> Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers >> >> On 7 December 2017 at 22:43, Ard Biesheuvel <

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2017-12-12 Thread Wu, Hao A
> Michael D; Zeng, Star > Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers > > On 7 December 2017 at 22:43, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: > > Many SDHCI implementations exist that are almost spec complicant, and > > co

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2017-12-11 Thread Ard Biesheuvel
On 7 December 2017 at 22:43, Ard Biesheuvel wrote: > Many SDHCI implementations exist that are almost spec complicant, and > could be driven by the generic SD/MMC host controller driver except > for some minimal necessary init time tweaks. > > Adding such tweaks to the

[edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

2017-12-07 Thread Ard Biesheuvel
Many SDHCI implementations exist that are almost spec complicant, and could be driven by the generic SD/MMC host controller driver except for some minimal necessary init time tweaks. Adding such tweaks to the generic driver is undesirable. On the other hand, forking the driver for every platform