Re: [edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

2016-11-08 Thread Haojian Zhuang
On 9 November 2016 at 04:43, Leif Lindholm wrote: > On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote: >> Declare fields in ECSD structure. And drop the original 128 words >> arrary. > > Functionality-wise, I'm happy with this, if it is moved to directly >

Re: [edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

2016-11-08 Thread Leif Lindholm
On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote: > Declare fields in ECSD structure. And drop the original 128 words > arrary. Functionality-wise, I'm happy with this, if it is moved to directly after "add SPEC_VERS field in CSD structure". A few comments inline with regards to

[edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

2016-11-08 Thread Haojian Zhuang
Declare fields in ECSD structure. And drop the original 128 words arrary. Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 157 ++- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 4 +- 2 files changed, 158