Re: [edk2] [Patch] BaseTools: Fixed some small issues 1. The structure pcd default value should use the default value under sku. 2. Incorrect VpdOffset value for those un-used in module Vpd 3. Add a c

2018-01-23 Thread Gao, Liming
Bob: Patch title is < 80. Please move the information in the commit message. >-Original Message- >From: Feng, Bob C >Sent: Tuesday, January 23, 2018 11:35 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch]

Re: [edk2] [Patch] BaseTools: Fixed some small issues 1. The structure pcd default value should use the default value under sku. 2. Incorrect VpdOffset value for those un-used in module Vpd 3. Add a c

2018-01-22 Thread Zhu, Yonghong
Hi Bob, Please use PatchCheck.py script to check the patch, current it will report following error. The commit message format is not valid: * First line of commit message (subject line) is too long. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel