Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Ok, Reviewed-by: Star Zeng to this patch. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, November 14, 2017 3:54 AM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Dong, Eric

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Star, The specific USB mass storage device that demonstrated this issue has a Protocol of 0x00 (CBI), and the PEI phase USB recovery seems to only support a Protocol of 0x50 (BOT). So I am not able to reproduce the issue in PEI recovery path. >From code review, the PEI request sense API

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Star, No. I have not evaluated the PEI use case. I will test that and provide an updated patch if needed. Thanks, Mike > -Original Message- > From: Zeng, Star > Sent: Monday, November 13, 2017 1:22 AM > To: Kinney, Michael D ; edk2- > de...@lists.01.org >

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

Mike, Have you evaluated whether the code in PeiUsbRequestSense() of PeiAtapi.c also needs to be updated? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Thursday, November 9, 2017 6:03 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

[edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Fix USB Mass Storage detection

https://bugzilla.tianocore.org/show_bug.cgi?id=766 Update logic to not return an error from UsbBootRequestSense() if a Request Sense command responds with no sense information. It is legal for a USB mass storage device to respond to a Request Sense command with a SenseKey of