Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

t; > > -Original Message- > > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] > > On Behalf Of Zeng, Star > > Sent: Monday, November 13, 2017 2:03 AM > > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2- > > de...@lists.

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

ber 13, 2017 2:03 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- > de...@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] [Patch] > MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN val

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

tel.com>; Zeng, Star > <star.z...@intel.com> > Subject: Re: [edk2] [Patch] > MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value > > Mike, > > Just curious about what is the value returned for MaxLun > in the case you met before this patch? > > Could *MaxLun &a

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Mike, Just curious about what is the value returned for MaxLun in the case you met before this patch? Could *MaxLun &= USB_BOT_MAX_LUN work? Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, November 13, 2017 5:45 PM To: Kinney, Michael D ;

Re: [edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

Reviewed-by: Star Zeng How about also adding the compatibility info(now in commit log) to the code comments? For example, +// +// If MaxLun is larger than the maximum LUN value (0x0f) supported by the +// USB Mass Storage Class Bulk-Only Transport Spec, then

[edk2] [Patch] MdeModulePkg/UsbMassStorageDxe: Verify Get Max LUN value

The USB Mass Storage Class Specification states that a maximum LUN value larger than 0x0F is invalid. Add a check to make sure this maximum LUN value is in this valid range, and if it is not, then assume that the device does not support multiple LUNs and return a maximum LUN value of 0. This