Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-16 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, June 15, 2016 4:26 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Zeng, > Star > Subject: [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig > > This patch is used to fix u

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-16 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, June 15, 2016 4:34 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting Subject: RE: [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig Thanks for catching. I will update it be

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-15 Thread Wu, Jiaxin
Thanks for catching. I will update it before commit. /Jiaxin. > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 15, 2016 4:32 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Zeng, > Star > Subject: RE: [Patch] NetworkPkg: Fix unspecified address

Re: [edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-15 Thread Zeng, Star
Please also update the comments below in SPD_ENTRY_INDEXER structure. UINTNIndex;// Used only if Name is NULL. With the comments updated, you can have my Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Jiaxin Sent: Wednesday, June 15, 2016 4:26 PM To: edk2-dev

[edk2] [Patch] NetworkPkg: Fix unspecified address use case in IpsecConfig

2016-06-15 Thread Jiaxin Wu
This patch is used to fix unspecified address use case in ConstructSpdIndexer() function. Indexer->Name for ConstructSpdIndexer is unspecified, that will be a problem for UnicodeStrToAsciiStr. This patch also refine the code by removing ASSERT and user error handling. Cc: Fu Siyuan Cc: Ye Ting