Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

Liming, Please add /Oi to MemoryInitPei.inf for now. Thanks, Mike From: Gao, Liming Sent: Monday, April 11, 2016 5:26 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Subject: RE: [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit This

Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

This way still requires to include Library\BaseMemoryLib.h. Another way is to append /Oi option in [BuildOptions] section for VS tool chain. It has no change to memory init code. Thanks Liming From: Kinney, Michael D Sent: Tuesday, April 12, 2016 7:54 AM To: Gao, Liming ;

Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

Liming, I think I would prefer we minimize changes to the memory init C sources. Maybe it would be better if we added #define memset() to SetMem() in meminit_utils.h based on a define name set in a [BuildOptions] section of MemoryInitPei.inf Thanks, Mike > -Original Message- > From:

[edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

Use BaseMemoryLib ZeroMem replace memset function. Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- QuarkSocPkg/QuarkNorthCluster/MemoryInit/Pei/meminit.c | 11 ++- 1 file changed,