Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-12-06 Thread Carsey, Jaben
Liming > Subject: Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard > shared variable for '*' > Importance: High > > How about undo those and push the remaining? Since that's a very small > change. > > -Jaben > > > -Original Message- > &g

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-12-06 Thread Carsey, Jaben
How about undo those and push the remaining? Since that's a very small change. -Jaben > -Original Message- > From: Zhu, Yonghong > Sent: Monday, December 3, 2018 5:53 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong > > Subject: RE: [Patch v1 1/1]

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-12-03 Thread Zhu, Yonghong
Yes. I prefer not to change it. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Monday, December 03, 2018 11:19 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [Patch v1 1/1] BaseTools: create and use a standard shared variable for

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-12-03 Thread Carsey, Jaben
I was trying to change all use of *, without regard to the usage of it. Do you think that mathematical * should not be changed? -Jaben > -Original Message- > From: Zhu, Yonghong > Sent: Sunday, December 02, 2018 6:31 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Gao, Liming ;

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-12-02 Thread Zhu, Yonghong
Hi Jaben, In this patch, it also changed the mathematics multiplicative '*' (used in expression) to TAB_STAR, is it by on purpose? Eg: -NonLetterOpLst = ['+', '-', '*', '/', '%', '&', '|', '^', '~', '<<', '>>', '!', '=', '>', '<', '?', ':'] +NonLetterOpLst = ['+', '-', TAB_STAR, '/',

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-11-27 Thread Feng, Bob C
Reviewed-by : Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, November 16, 2018 11:40 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared

Re: [edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-11-27 Thread Carsey, Jaben
Poke. Any comments on this one? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jaben Carsey > Sent: Friday, November 16, 2018 7:40 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch v1 1

[edk2] [Patch v1 1/1] BaseTools: create and use a standard shared variable for '*'

2018-11-16 Thread Jaben Carsey
add a variable for the string '*' and then use it instead of lots of '*' Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 54 ++--