Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-24 Thread Gao, Liming
vel@lists.01.org > Subject: RE: [edk2] [RFC] Formalize source files to follow DOS format > > We could do something like we do for compiler flags... append or overwrite > depending on syntax. > > > -Original Message- > > From: Gao, Liming > > Sent: Thursday

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-24 Thread Carsey, Jaben
el.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [RFC] Formalize source files to follow DOS format > Importance: High > > Mike: > I agree your comments. On default file set, this script can have the default > ones. User can specify more set to append the def

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-24 Thread Carsey, Jaben
.org > Subject: RE: [edk2] [RFC] Formalize source files to follow DOS format > Importance: High > > Jaben: > What difference of statement for file read/write? > > Besides, we use .encode() here to support python 3. After we move to > python 3, this script is not chan

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-24 Thread Gao, Liming
8 6:59 AM >To: Carsey, Jaben <jaben.car...@intel.com>; Kinney, Michael D ><michael.d.kin...@intel.com> >Cc: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org >Subject: RE: [edk2] [RFC] Formalize source files to follow DOS format > >Jaben, > >Yes. With

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-24 Thread Gao, Liming
ming <liming@intel.com>; edk2-devel@lists.01.org >Subject: RE: [edk2] [RFC] Formalize source files to follow DOS format > >Liming, > >One Pep8 thing. >Can you change to use the with statement for the file read/write? > >Other small thoughts. >I think that

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Kinney, Michael D
: Gao, Liming <liming@intel.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] [RFC] Formalize source files to > follow DOS format > > Mike, > > Perhaps a default set of file extensions that can be > overridden? > > -Jaben > > > > On May 21, 201

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Carsey, Jaben
Message- >> From: edk2-devel [mailto:edk2-devel- >> boun...@lists.01.org] On Behalf Of Carsey, Jaben >> Sent: Monday, May 21, 2018 7:50 AM >> To: Gao, Liming <liming@intel.com>; edk2- >> de...@lists.01.org >> Subject: Re: [edk2] [RFC] Formaliz

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Kinney, Michael D
-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Carsey, Jaben > Sent: Monday, May 21, 2018 7:50 AM > To: Gao, Liming <liming@intel.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] [RFC] Formalize source files to > follow DOS format > > Liming, &

Re: [edk2] [RFC] Formalize source files to follow DOS format

2018-05-21 Thread Carsey, Jaben
to python 3 we will have fewer changes to make. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Sunday, May 20, 2018 9:52 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [RFC] Formalize source files to

[edk2] [RFC] Formalize source files to follow DOS format

2018-05-20 Thread Liming Gao
FormatDosFiles.py is added to clean up dos source files. It bases on the rules defined in EDKII C Coding Standards Specification. 5.1.2 Do not use tab characters 5.1.6 Only use CRLF (Carriage Return Line Feed) line endings. 5.1.7 All files must end with CRLF No trailing white space in one line.