Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-25 Thread Tian, Feng
arsey, Jaben Sent: Wednesday, August 26, 2015 01:14 To: Tian, Feng; Anbazhagan, Baraneedharan; Zeng, Star Cc: edk2-devel@lists.01.org; Tian, Feng; Carsey, Jaben Subject: RE: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens What about other error return valu

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-25 Thread Carsey, Jaben
Behalf Of > Tian, Feng > Sent: Monday, August 24, 2015 8:17 PM > To: Anbazhagan, Baraneedharan ; Zeng, Star > > Cc: edk2-devel@lists.01.org; Tian, Feng > Subject: Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer > ring when timeout happens > > Thanks for

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-25 Thread Zeng, Star
On 2015/8/25 11:16, Tian, Feng wrote: Thanks for your comments, Baranee. I updated the patch as below. Please review again. --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 75 +++--- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 193 + MdeModulePkg/Bus/Pci/XhciDxe/X

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-25 Thread Anbazhagan, Baraneedharan
k2-devel@lists.01.org; Tian, Feng > Subject: Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring > when > timeout happens > > Thanks for your comments, Baranee. I updated the patch as below. Please review > again. > > --- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-24 Thread Tian, Feng
m the Stopped to the Running + state. + + @param Xhc The XHCI device. + @param Urb The urb which doesn't get completed in a specified timeout range. + + @retval EFI_SUCCESS The dequeuing of the TDs is successful. + @retval Others

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-24 Thread Anbazhagan, Baraneedharan
gust 24, 2015 12:53 AM > To: star.z...@intel.com > Cc: edk2-devel@lists.01.org; Feng Tian > Subject: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when > timeout happens > > The error handling for timeout case is enhanced to remove TDs from transfer > ring. &

[edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-23 Thread Tian Feng
The error handling for timeout case is enhanced to remove TDs from transfer ring. The original code only removed s/w URB, but the h/w transfer descriptor TDs didn't get removed. It would cause data lost for data stream peripheral, such as usb-to-serial device, from the s/w perspective. Contributed