Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-16 Thread Nikita Leshenko
> On 13 Sep 2018, at 15:15, Laszlo Ersek wrote: > > On 09/13/18 14:27, Nikita Leshenko wrote: >> >> Thanks for the detailed explanation. I guess we have no choice >> but to copy BaseCachingPciExpressLib (renamed to >> DxePciExpressLibCaching) from ArmVirt to OVMF as well. > > Uhh, hold on

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-13 Thread Laszlo Ersek
On 09/13/18 14:27, Nikita Leshenko wrote: > > >> On 11 Sep 2018, at 15:34, Laszlo Ersek wrote: >> >> "BasePciExpressLib" has the prefix "Base", meaning that it is supposed >> to be usable in all types of firmware modules, even in SEC and PEIMs -- >> which may not have access to writeable memory

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-13 Thread Nikita Leshenko
> On 11 Sep 2018, at 15:34, Laszlo Ersek wrote: > > "BasePciExpressLib" has the prefix "Base", meaning that it is supposed > to be usable in all types of firmware modules, even in SEC and PEIMs -- > which may not have access to writeable memory except stack (i.e. > writeable global

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-11 Thread Laszlo Ersek
On 09/07/18 19:01, Liran Alon wrote: > > >> On 7 Sep 2018, at 11:44, Laszlo Ersek wrote: >> >> (+Ard) >> >> On 09/06/18 21:08, Nikita Leshenko wrote: >>> Hi, >>> >>> We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the >>> flow >>> of the bug: >>> >>> 1.

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-07 Thread Liran Alon
> On 7 Sep 2018, at 11:44, Laszlo Ersek wrote: > > (+Ard) > > On 09/06/18 21:08, Nikita Leshenko wrote: >> Hi, >> >> We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the >> flow >> of the bug: >> >> 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-07 Thread Laszlo Ersek
(+Ard) On 09/06/18 21:08, Nikita Leshenko wrote: > Hi, > > We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the > flow > of the bug: > > 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a BAR. It > raises >TPL to TPL_HIGH_LEVEL to avoid timer

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-06 Thread Ni, Ruiyu
Nikita > Leshenko > Sent: Friday, September 7, 2018 3:09 AM > To: edk2-devel@lists.01.org > Cc: Liran Alon > Subject: [edk2] PciBusDxe: PCI-Express bug with dynamic > PcdPciExpressBaseAddress > > Hi, > > We ran into a bug in EDK2 relating to PCI-Express in PciBus

[edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-06 Thread Nikita Leshenko
Hi, We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the flow of the bug: 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a BAR. It raises TPL to TPL_HIGH_LEVEL to avoid timer interrupts while probing the BAR and calls PciIo->Pci.Write. 2.