Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-30 Thread Yao, Jiewen
:56 AM To: Kinney, Michael D; Yao, Jiewen; Fan, Jeff Cc: Justen, Jordan L; edk2-devel-01 Subject: Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei On 10/29/15 18:30, Kinney, Michael D wrote: > Laszlo, > > Thanks for the very detailed and complete root cause on this issue.

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-30 Thread Kinney, Michael D
t;From: Yao, Jiewen >Sent: Friday, October 30, 2015 7:18 AM >To: Laszlo Ersek; Kinney, Michael D; Fan, Jeff >Cc: Justen, Jordan L; edk2-devel-01 >Subject: RE: [edk2] about the SMM_S3_RESUME_SMM_64 branch in >S3Resume2Pei > >Yes, first, thanks the great analysis from Laszlo. >

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-29 Thread Laszlo Ersek
aching agreements in the pending debates - addressing patch feedback and securing reviews. Thank you Laszlo > > For "RSM from 64-bit mode ", I have already confirmed with IA32 SDM owner > that it is just typo. > RSM should work in 64bit mode, so this patch is unnecessary, I believe

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-29 Thread Kinney, Michael D
Jiewen; Kinney, Michael D; Fan, Jeff >Cc: Justen, Jordan L; edk2-devel-01 >Subject: Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in >S3Resume2Pei > >Hi Jiewen, > >On 10/29/15 03:28, Yao, Jiewen wrote: >> Thanks for the info. I think we might have to dig out why LONG_JU

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-29 Thread Laszlo Ersek
015 9:50 AM > To: Yao, Jiewen; Kinney, Michael D; Fan, Jeff > Cc: edk2-devel-01 > Subject: Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei > > On 10/29/15 02:32, Laszlo Ersek wrote: >> On 10/29/15 01:31, Yao, Jiewen wrote: >>> Hi Ersek >>>

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Kinney, Michael D
Laszlo, I do not believe any X64 PEI testing has not been performed with this module. We will investigate a fix. Thanks, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, October 28, 2015 8:57 AM >To: Fan, Jeff; Yao, Jiewen >Cc: edk2-devel-01;

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Laszlo Ersek
On 10/28/15 17:54, Kinney, Michael D wrote: > Laszlo, > > I do not believe any X64 PEI testing has not been performed with this module. > We will investigate a fix. Thank you. In any case, in OVMF we might be able to use this module nonetheless, with the OvmfPkgIa32X64.dsc build (== 32-bit

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Laszlo Ersek
On 10/29/15 01:31, Yao, Jiewen wrote: > Hi Ersek > I think S3ResumePei supports Ia32 and Ia32X64. It does not support X64. So I > believe Ia32X64 crash is a bug somewhere. > > Since you already run into SmmRestoreCpu(), would you please help to check > where is last instruction causing crash?

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Yao, Jiewen
October 29, 2015 9:50 AM To: Yao, Jiewen; Kinney, Michael D; Fan, Jeff Cc: edk2-devel-01 Subject: Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei On 10/29/15 02:32, Laszlo Ersek wrote: > On 10/29/15 01:31, Yao, Jiewen wrote: >> Hi Ersek >> I think S3ResumePei supports

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Laszlo Ersek
On 10/29/15 02:32, Laszlo Ersek wrote: > On 10/29/15 01:31, Yao, Jiewen wrote: >> Hi Ersek >> I think S3ResumePei supports Ia32 and Ia32X64. It does not support X64. So I >> believe Ia32X64 crash is a bug somewhere. >> >> Since you already run into SmmRestoreCpu(), would you please help to check

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-28 Thread Laszlo Ersek
On 10/28/15 23:41, Laszlo Ersek wrote: > On 10/28/15 23:26, Yao, Jiewen wrote: >> Right. It seems S3Resume2Pei does not consider X64 mode. I found at least 3 >> functions need enhancement on mode transition: >> 1) S3RestoreConfig2() - S3Resume <-> SmmCpu (DXE mode); >> 2)