Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

Hi Tzy Way, On Thu, Feb 28, 2019 at 08:39:32AM +, Ooi, Tzy Way wrote: > Thanks for your comment. I will modify the driver to comply to UEFI > driver model. Excellent, thanks. > I would like to ask why this driver should be submitted to edk2- > platforms instead of edk2? This driver is a

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

Hi Leif, Thanks for your comment. I will modify the driver to comply to UEFI driver model. I would like to ask why this driver should be submitted to edk2- platforms instead of edk2? This driver is a generic driver which is target to work on various platform. Best regards, Tzy Way On Thu,

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

Hi Tzy Way, Thank you for this contribution. I do have some high-level comments. First of all, my best guess is that you have used Lan9118Dxe for reference when developing this driver. This is somewhat unfortunate. I am reminded that a) we badly need to migrate that driver (and Lan91xDxe) to