Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-10 Thread Paulo Alcantara
t;ler...@redhat.com> Subject: Re: [edk2] [PATCH 0/4] read-only UDF file system support (heh - forgot to answer your question about the GUID :-) ) On 8/9/2017 10:26 AM, Paulo Alcantara wrote: Hi Ray, Thanks for the review. My comments below. On 8/9/2017 3:05 AM, Ni, Ruiyu wrote: Paulo,

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Ni, Ruiyu
d...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Justen, >Jordan L <jordan.l.jus...@intel.com>; >Andrew Fish <af...@apple.com>; Gao, Liming <liming@intel.com>; Kinney, >Michael D <michael.d.kin...@intel.com>; >Laszlo Ersek <ler...@redhat.com> >Subje

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Paulo Alcantara
(heh - forgot to answer your question about the GUID :-) ) On 8/9/2017 10:26 AM, Paulo Alcantara wrote: Hi Ray, Thanks for the review. My comments below. On 8/9/2017 3:05 AM, Ni, Ruiyu wrote: Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Paulo Alcantara
Hi Ray, Thanks for the review. My comments below. On 8/9/2017 3:05 AM, Ni, Ruiyu wrote: Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you please separate the patch to modify MdePkg and MdeModulePkg? Sure. 2. UDF_CDROM_VOLUME_IDENTIFIER is also

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Ni, Ruiyu
Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you please separate the patch to modify MdePkg and MdeModulePkg? 2. UDF_CDROM_VOLUME_IDENTIFIER is also defined in Eltorito.h as CDVOL_ID. Maybe we could redefine CDVOL_ID to

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-08 Thread Zeng, Star
Cc Ray and Hao. -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Wednesday, August 9, 2017 3:32 AM To: edk2-devel@lists.01.org Cc: Paulo Alcantara ; Laszlo Ersek ; Justen, Jordan L ; Andrew Fish