Re: [edk2] [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs

2016-01-28 Thread Laszlo Ersek
On 01/28/16 02:32, Tian, Feng wrote: > Laszlo, > > Thanks for your particular elaborations on this issue. I am ok with your > change. > > Reviewed-by: Feng Tian > > Feng Thank you very much! Since this change seems to be justified in general, independently of the OVMF

Re: [edk2] [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs

2016-01-27 Thread Laszlo Ersek
Hi Feng, On 01/27/16 05:24, Tian, Feng wrote: > Hi, Laszlo > > I am ok with the format string change. > > I just have a concern about the DEBUG level change. According to > comments, if debug msg impacts boot performance, we should use > DEBUG_VERBOSE. Does it impact OVMF boot performance

Re: [edk2] [PATCH 1/3] MdeModulePkg: NvmExpressDxe: clean up NvmeRead() / NvmeWrite() debug msgs

2016-01-26 Thread Tian, Feng
Hi, Laszlo I am ok with the format string change. I just have a concern about the DEBUG level change. According to comments, if debug msg impacts boot performance, we should use DEBUG_VERBOSE. Does it impact OVMF boot performance significantly? If yes, I agree to change it to VERBOSE.