Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

2018-01-30 Thread Laszlo Ersek
On 01/29/18 20:48, Laszlo Ersek wrote: > On 01/29/18 10:02, Wang, Jian J wrote: >> Hi Laszlo, >> >> I don't know the history of these code but I guess they're converted >> from .asm file. That may be why there's "DB 66h" prefix. I think >> you're right these tricks should be replaced with more

Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

2018-01-29 Thread Laszlo Ersek
On 01/29/18 10:02, Wang, Jian J wrote: > Hi Laszlo, > > I don't know the history of these code but I guess they're converted > from .asm file. That may be why there's "DB 66h" prefix. I think > you're right these tricks should be replaced with more formal ways. > Please submit a bz tracker for it.

Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

2018-01-29 Thread Wang, Jian J
> Kr?má? <rkrc...@redhat.com> > Subject: Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if > it's supported > > Hello Jian, > > On 01/15/18 09:54, Jian J Wang wrote: > > If PcdDxeNxMemoryProtectionPolicy is set to enable protection for memory > >

Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

2018-01-28 Thread Laszlo Ersek
Hello Jian, On 01/15/18 09:54, Jian J Wang wrote: > If PcdDxeNxMemoryProtectionPolicy is set to enable protection for memory > of EfiBootServicesCode, EfiConventionalMemory, the BIOS will hang at a page > fault exception triggered by PiSmmCpuDxeSmm. > > The root cause is that PiSmmCpuDxeSmm will

Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

2018-01-16 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Monday, January 15, 2018 4:55 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Ni, Ruiyu ; > Dong, Eric ; Laszlo Ersek