On Tue, Dec 04, 2018 at 10:33:23AM +0100, Ard Biesheuvel wrote:
> > +#pragma pack(push, 1)
>
> I don't see this #pragma making any difference to the structs below,
> can it be dropped?
> >>>
> >>> The pragma pack is defensive. Without it, we rely on the compiler
> >>> packing
> On 4 Dec 2018, at 02:44, Chris Co wrote:
>
>
>
>> -Original Message-
>> From: Leif Lindholm
>> Sent: Monday, December 3, 2018 1:43 AM
>> To: Chris Co
>> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
>> Michael D Kinney
>>
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, December 3, 2018 1:43 AM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
> Michael D Kinney
> Subject: Re: [PATCH edk2-platforms 09/27] Silicon/NXP: Add headers for SoC-
> speci
On Sat, Dec 01, 2018 at 12:22:17AM +, Chris Co wrote:
> > If using EFI_ACPI prefix, these #defines really should be in edk2 MdePkg.
> > And
> > CSRT itself is, so that might not be a bad idea.
> >
> > > +
> > > +#pragma pack(push, 1)
> >
> > I don't see this #pragma making any difference to
Hi Leif,
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, November 1, 2018 11:20 AM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
> Michael D Kinney
> Subject: Re: [PATCH edk2-platforms 09/27] Silicon/NXP: Add headers for SoC-
>
On Fri, Sep 21, 2018 at 08:26:00AM +, Chris Co wrote:
> This adds common headers for other NXP i.MX SoC packages.
> More specifically, this adds i.MX-generic GPIO, IoMux, and
> Platform definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co
>
6 matches
Mail list logo
