Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

2017-12-04 Thread Leif Lindholm
On Mon, Dec 04, 2017 at 05:17:15PM +, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: > > On 4 December 2017 at 17:13, Leif Lindholm wrote: > > > D02, D03 and D05 all have nice conditional clauses to only include > > > the

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

2017-12-04 Thread Ard Biesheuvel
On 4 December 2017 at 17:17, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: >> On 4 December 2017 at 17:13, Leif Lindholm wrote: >> > D02, D03 and D05 all have nice conditional clauses to only include >>

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

2017-12-04 Thread Leif Lindholm
On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: > On 4 December 2017 at 17:13, Leif Lindholm wrote: > > D02, D03 and D05 all have nice conditional clauses to only include > > the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND). > > > >

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

2017-12-04 Thread Ard Biesheuvel
On 4 December 2017 at 17:13, Leif Lindholm wrote: > D02, D03 and D05 all have nice conditional clauses to only include > the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND). > > Unfortunately, they all explicitly set DEFINE INCLUDE_TFTP_COMMAND=1 in > their